From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE12E3368B1 for ; Thu, 26 Mar 2026 14:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533941; cv=none; b=ff/n+Mm6Mg9FBxl8LAQxzovu1BcbuXBhyazdPs7JN/WUjUjf14lLCfGclutgZl68PxMwvCixUp5Nx+mhjRdbRPFj+wmt8INwhKN2T/zVU1TQnHaMEfw0RiN0idw7F/lYNstz+PtycsMDmdJ/SfO92rj/f1UUVdrmQbxoAFy88Vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533941; c=relaxed/simple; bh=+P/UaSSOrZzUsHGMRUaucczR4HHnEzzY5ibe0fyS/zY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ouozK9R20IzJQLJb7EQ5rCmlyPSDipDJABIG41toB1ybCIyxqs5IcZdXtKNoWjVWujXxTDb55h9w428BzO5PXYqqQeXva1GJVS/fhiCxpick02dUd5aeKdvbvq4yz1rvBtUf7IlYhsC/R4z0EpCe/GStX9PdK4Uio4C2R1aopmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fSBbFzzB; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fSBbFzzB" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b9b1df1a6b3so113722166b.0 for ; Thu, 26 Mar 2026 07:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774533936; x=1775138736; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LHl7tocSnGmIBgBLm+xo8yjHEwMa3jnz1csUCNaWtac=; b=fSBbFzzBrm2ZZrbtwsqEJOXnicMSW0NLxvNaoSm7Pz75vsudXAh5U2LoGcSN3+Fc7b Asp7JVm1kUCvgdUYHYLyOJ/SWUWoLfAMLf3FSxsIflcLPcfgBTYCXvA4l9OunaxyxoAc mp20mLHw1iiskjRGdk/9nK3xpib0cZfrw585TarBJFakvs6mjVHpUmrNVHCV9Cawka6c RndZabTREjJQxwQzPMeo9ffyudlDRZu30qjs3nne+0s3DAbePln5zgBd4t9lXMXHueV6 3CzMf5EBRhywS7Q15v9rioDKJJnom5vnbxdqHGKjXGoXoZPURWXZOR/854LmAr9F7OXn /EjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774533936; x=1775138736; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LHl7tocSnGmIBgBLm+xo8yjHEwMa3jnz1csUCNaWtac=; b=K/ic+KJKWobFgcRhI/jkkDIIecu45ZvV1gOqUabqeisbxvBqM2Tqre3VDoEHzkG6Fr xx0Yyxro5ADZGbGfBR/BhVYJuqcGzrQSVpqM6js1o3LkASJ+yclMXDZAERUL/YD2OBNT X993RDM+s1Brx2OPUEmEJDq0Y4WnlbplArJdRKFNmB7s0K7QOTV6+uFZvAzQVuobiLhC GtNwIZmEtkObAwR9B92cisaOgoUl6ZWcqRkibpnX0mo//5WmoUUsWk1CsTov0NjGhejp UCNp4kHZNJTws0CqNx1OCU6Bwz965fJsuhTDMH39iyaUd2XwqNO3FaLooZXr0zWnRzCC Cotg== X-Forwarded-Encrypted: i=1; AJvYcCWpWg5CtaCVv63Zo3UAkbeYiSZ8xvj6oA12+NN2QvJZh+SqXw8yTqDuTXiaiRkaXO4bbbOmg1Woouk2XdA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5bCD5xyKKCpkE6Cv0fYplh6ldGkEIss6kscjti46+METASqQa 1oidv89A7nNTG1nhKPTt1sEZi/pUZ8oc7h2NVumL3pye1B3K96HG0KEp X-Gm-Gg: ATEYQzxw5k+u48i5oA6KsaWfjf/vGYhHbUuKBGKv882JGVC9b50SqE3Y42vMQaO8rHZ EWlmbW9AyF9BibPUmfmnVcVwa/dV+Q16xNuhCrWQE1paHo1R+z2DOQt/d0y97G5J3xlnZ7/G2YN 9CK+kW8WyLxA6aZunDb9VnRJCZQH9Xdgd7SU1aXkN7Ef5LKBf6CnDnRrJJCvoxRsvKyoQXZuCl3 py1X5ROKzews8V654skxT7lmaW+IkOS0FrCu7b0qL5gUFbHePYWdEfN+qR4drThdC/na8Q00rxh Il2ZySUe+XSWn0eibtJS9JfJRTMDpUPQOjccyV1s/svF9n+DBsXvgkxpjzvtbli/bYqLvGI25+s pYu1iWe5RRePxMvs3FOx8vPuVO3S9WoPlub18IJ1NlVdMKbP4EsRqZXYiYPNbIqpvT50xQbfgX2 Y2YpSein/h0NTq8qsH0LzUbqJ9F4FybxlIuOCqLOdmSy7s7EiGMqTjjupgwGGYfIZFtd/izU4bE U/4Bg== X-Received: by 2002:a17:907:c30e:b0:b97:bc8a:f45e with SMTP id a640c23a62f3a-b9a3f1665d2mr499473466b.1.1774533936094; Thu, 26 Mar 2026 07:05:36 -0700 (PDT) Received: from ?IPV6:2a02:a03f:a75e:9a00:41b0:4bee:eddb:bf6a? ([2a02:a03f:a75e:9a00:41b0:4bee:eddb:bf6a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203eeeccsm127701166b.44.2026.03.26.07.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 07:05:35 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 15:05:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/ipv6: ioam6: prevent schema length wraparound in trace fill To: Pengpeng Hou , "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325074152.17064-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Justin Iurman In-Reply-To: <20260325074152.17064-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 08:41, Pengpeng Hou wrote: > ioam6_fill_trace_data() stores the schema contribution to the trace > length in a u8. With bit 22 enabled and the largest schema payload, > sclen becomes 1 + 1020 / 4, wraps from 256 to 0, and bypasses the > remaining-space check. __ioam6_fill_trace_data() then positions the > write cursor without reserving the schema area but still copies the > 4-byte schema header and the full schema payload, overrunning the trace > buffer. > > Keep sclen in an unsigned int so the remaining-space check and the write > cursor calculation both see the full schema length. > > Fixes: 8c6f6fa67726 ("ipv6: ioam: IOAM Generic Netlink API") ... should be: Fixes: 9ee11f0fff20 ("ipv6: ioam: Data plane support for Pre-allocated Trace") Respin needed? Otherwise, LGTM. Reviewed-by: Justin Iurman > Signed-off-by: Pengpeng Hou > --- > net/ipv6/ioam6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv6/ioam6.c b/net/ipv6/ioam6.c > index b76f89d92e7b..3978773bec42 100644 > --- a/net/ipv6/ioam6.c > +++ b/net/ipv6/ioam6.c > @@ -708,7 +708,7 @@ static void __ioam6_fill_trace_data(struct sk_buff *skb, > struct ioam6_namespace *ns, > struct ioam6_trace_hdr *trace, > struct ioam6_schema *sc, > - u8 sclen, bool is_input) > + unsigned int sclen, bool is_input) > { > struct net_device *dev = skb_dst_dev(skb); > struct timespec64 ts; > @@ -939,7 +939,7 @@ void ioam6_fill_trace_data(struct sk_buff *skb, > bool is_input) > { > struct ioam6_schema *sc; > - u8 sclen = 0; > + unsigned int sclen = 0; > > /* Skip if Overflow flag is set > */