From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ivan Sergeev <ivan8215145640@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2
Date: Sun, 5 Jan 2025 11:27:23 +0100 [thread overview]
Message-ID: <a184e97e-4537-4379-b78f-e651dd66a2d8@kernel.org> (raw)
In-Reply-To: <20250105-bigtreetech-cb2-v5-2-923f911b10c0@gmail.com>
On 05/01/2025 11:01, Ivan Sergeev wrote:
> +
> +&spi3 {
> + pinctrl-0 = <&spi3m1_cs0 &spi3m1_pins>;
> +};
> +
> +&pcie2x1 {
> + reset-gpios = <&gpio1 RK_PB2 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie_reset_h>;
> + vpcie3v3-supply = <&vcc3v3_pcie>;
> + status = "okay";
> +};
> +
> +&pinctrl {
> + sd {
> + sdmmc0_pwr_h: sdmmc0-pwr-h {
> + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> + pmic {
> + pmic_int: pmic_int {
Not fixed here and in multiple other places. Please fix the same issue
everywhere, not in one place I commented under.
>
Best regards,
Krzysztof
prev parent reply other threads:[~2025-01-05 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 10:01 [PATCH v5 0/2] arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2 Ivan Sergeev
2025-01-05 10:01 ` [PATCH v5 1/2] dt-bindings: arm: " Ivan Sergeev
2025-01-05 10:01 ` [PATCH v5 2/2] arm64: dts: " Ivan Sergeev
2025-01-05 10:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a184e97e-4537-4379-b78f-e651dd66a2d8@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=ivan8215145640@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox