RE: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

Yuan, Perry
2021-03-23T06:21:34Z

Hi Randy.

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Tuesday, March 23, 2021 1:15 AM
> To: Yuan, Perry; pobrn@protonmail.com; pierre-
> louis.bossart@linux.intel.com; oder_chiou@realtek.com; perex@perex.cz;
> tiwai@suse.com; hdegoede@redhat.com; mgross@linux.intel.com;
> Limonciello, Mario
> Cc: lgirdwood@gmail.com; broonie@kernel.org; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
>
>
> [EXTERNAL EMAIL]
>
> On 3/22/21 2:38 AM, Perry Yuan wrote:
> > From: Perry Yuan <perry_yuan@dell.com>
> >
>
> > diff --git a/drivers/platform/x86/dell/Kconfig
> > b/drivers/platform/x86/dell/Kconfig
> > index e0a55337f51a..0e0f1eb35bd6 100644
> > --- a/drivers/platform/x86/dell/Kconfig
> > +++ b/drivers/platform/x86/dell/Kconfig
> > @@ -204,4 +204,20 @@ config DELL_WMI_SYSMAN
> > To compile this driver as a module, choose M here: the module will
> > be called dell-wmi-sysman.
> >
> > +config DELL_PRIVACY
> > + tristate "Dell Hardware Privacy Support"
> > + depends on ACPI
> > + depends on ACPI_WMI
> > + depends on INPUT
> > + depends on DELL_LAPTOP
> > + depends on LEDS_TRIGGER_AUDIO
> > + select DELL_WMI
> > + help
> > + This driver provides support for the "Dell Hardware Privacy" feature
> > + of Dell laptops.
> > + Support for a micmute and camera mute privacy will be provided as
>
> better:
> are provided as
>
> > + hardware button Ctrl+F4 and Ctrl+F9 hotkey.
>
> Does that say that Ctrl+F4 is a hardware button and that Ctrl+F9 is a hotkey?
> If so, what's the difference? and why? Are they different hardware
> implementations? Does the user care?

They all use the Ctrl button,
Ctrl +F4 requires that the Ctrl button and F4 button are pressed at the same time. F9+ctrl also have the same meaning.
They are belonging to same hardware privacy solution, just use different keys combination to activate different privacy function .

>
> > +
> > + To compile this driver as a module, choose M here: the module will
> > + be called dell_privacy.
> > endif # X86_PLATFORM_DRIVERS_DELL
> thanks.
> --
> ~Randy