Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

Pierre-Louis Bossart
2021-03-23T18:58:11Z

Minor comments below.

On 3/22/21 4:38 AM, Perry Yuan wrote:
> From: Perry Yuan <perry_yuan@dell.com>
>
> add support for Dell privacy driver for the Dell units equipped
> hardware privacy design, which protect users privacy of audio and
> camera from hardware level. Once the audio or camera privacy mode
> activated, any applications will not get any audio or video stream
> when user pressed ctrl+F4 hotkey, audio privacy mode will be
> enabled, micmute led will be also changed accordingly
> The micmute led is fully controlled by hardware & EC(embedded controller)
> and camera mute hotkey is Ctrl+F9. Currently design only emmits

typo: emits

> SW_CAMERA_LENS_COVER event while the camera lens shutter will be
> changed by EC & hw(hadware) control

typo: hardware
>
> *The flow is like this:
> 1) User presses key. HW does stuff with this key (timeout timer is started)
> 2) WMI event is emitted from BIOS to kernel
> 3) WMI event is received by dell-privacy
> 4) KEY_MICMUTE emitted from dell-privacy
> 5) Userland picks up key and modifies kcontrol for SW mute
> 6) Codec kernel driver catches and calls ledtrig_audio_set, like this:
> ledtrig_audio_set(LED_AUDIO_MICMUTE,
> rt715->micmute_led ? LED_ON :LED_OFF);
> 7) If "LED" is set to on dell-privacy notifies EC,
> and timeout is cancelled, HW mic mute activated.

what happens if there is timeout? You have an explicit description of
the timer handling in the success case, but not what happens on a timeout...

> diff --git a/Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi b/Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi
> new file mode 100644
> index 000000000000..20c15a51ec38
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi
> @@ -0,0 +1,32 @@
> +What: /sys/bus/wmi/devices/6932965F-1671-4CEB-B988-D3AB0A901919/devices_supported
> +Date: Feb 2021
> +KernelVersion: 5.12

5.13 now?

> +static int dell_privacy_micmute_led_set(struct led_classdev *led_cdev,
> + enum led_brightness brightness)
> +{
> + struct privacy_acpi_priv *priv = privacy_acpi;
> + acpi_status status;
> + acpi_handle handle;
> + static char *acpi_method = (char *)"ECAK";
> +
> + handle = ec_get_handle();
> + if (!handle)
> + return -EIO;
> + if (!acpi_has_method(handle, acpi_method))
> + return -EIO;
> + status = acpi_evaluate_object(handle, acpi_method, NULL, NULL);
> + if (ACPI_FAILURE(status)) {
> + dev_err(priv->dev, "Error setting privacy EC ack value: %s\n",
> + acpi_format_exception(status));
> + return -EIO;
> + }
> + pr_debug("set dell privacy micmute ec ack event done\n");

can we use dev_dbg() here? Same for all occurrences of pr_debug and
pr_err below, it's cleaner and easier to filter.

> + return 0;
> +}
> +
> +static int dell_privacy_acpi_remove(struct platform_device *pdev)
> +{
> + struct privacy_acpi_priv *priv = dev_get_drvdata(privacy_acpi->dev);
> +
> + led_classdev_unregister(&priv->cdev);
> +
> + return 0;
> +}
> +/*
> + * Pressing the mute key activates a time delayed circuit to physically cut
> + * off the mute. The LED is in the same circuit, so it reflects the true
> + * state of the HW mute. The reason for the EC "ack" is so that software
> + * can first invoke a SW mute before the HW circuit is cut off. Without SW
> + * cutting this off first does not affect the time delayed muting or status
> + * of the LED but there is a possibility of a "popping" noise.
> + *
> + * If the EC receives the SW ack, the circuit will be activated before the
> + * delay completed.
> + *
> + * Exposing as an LED device allows the codec drivers notification path to
> + * EC ACK to work
> + */
> +static int dell_privacy_leds_setup(struct device *dev)
> +{
> + struct privacy_acpi_priv *priv = dev_get_drvdata(dev);
> + int ret = 0;

useless init

> +
> + priv->cdev.name = "dell-privacy::micmute";
> + priv->cdev.max_brightness = 1;
> + priv->cdev.brightness_set_blocking = dell_privacy_micmute_led_set;
> + priv->cdev.default_trigger = "audio-micmute";
> + priv->cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
> + ret = devm_led_classdev_register(dev, &priv->cdev);
> + if (ret)
> + return ret;
> + return 0;
> +}
> +
> +static int dell_privacy_acpi_probe(struct platform_device *pdev)
> +{
> + int ret;
> +
> + platform_set_drvdata(pdev, privacy_acpi);
> + privacy_acpi->dev = &pdev->dev;
> + privacy_acpi->platform_device = pdev;
> +
> + ret = dell_privacy_leds_setup(&pdev->dev);
> + if (ret)
> + return -EIO;

any reason to hard-code -EIO, woud 'return ret' be enough?

> +
> + return 0;
> +}
> +
> +static struct platform_driver dell_privacy_platform_drv = {
> + .driver = {
> + .name = PRIVACY_PLATFORM_NAME,
> + },
> + .probe = dell_privacy_acpi_probe,
> + .remove = dell_privacy_acpi_remove,
> +};
> +
> +int __init dell_privacy_acpi_init(void)

is the __init necessary? You call this routine from another which
already has this qualifier.

> +{
> + int err;
> + struct platform_device *pdev;
> +
> + if (!wmi_has_guid(DELL_PRIVACY_GUID))
> + return -ENODEV;
> +
> + privacy_acpi = kzalloc(sizeof(*privacy_acpi), GFP_KERNEL);
> + if (!privacy_acpi)
> + return -ENOMEM;
> +
> + err = platform_driver_register(&dell_privacy_platform_drv);
> + if (err)
> + goto pdrv_err;
> +
> + pdev = platform_device_register_simple(
> + PRIVACY_PLATFORM_NAME, PLATFORM_DEVID_NONE, NULL, 0);
> + if (IS_ERR(pdev)) {
> + err = PTR_ERR(pdev);
> + goto pdev_err;
> + }
> +
> + return 0;
> +
> +pdev_err:
> + platform_device_unregister(pdev);
> +pdrv_err:
> + kfree(privacy_acpi);
> + return err;
> +}
> +
> +void __exit dell_privacy_acpi_exit(void)

is the __exit required here?

> +{
> + struct platform_device *pdev = to_platform_device(privacy_acpi->dev);
> +
> + platform_device_unregister(pdev);
> + platform_driver_unregister(&dell_privacy_platform_drv);
> + kfree(privacy_acpi);
> +}
> +
> +MODULE_AUTHOR("Perry Yuan <perry_yuan@dell.com>");
> +MODULE_DESCRIPTION("DELL Privacy ACPI Driver");
> +MODULE_LICENSE("GPL");