From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281C51EB1A9 for ; Wed, 12 Mar 2025 15:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741792524; cv=none; b=F9yBVeN40/S3AgnNQl6F4bPK4kFBlsZbjYTxm0xTI9yDXLmfqYV5jNpw9dH4wofb02Yb9xJZ+fH8BqCRa/zePNroNAprDsw/fqK+tKZrv/CY4czhJGPa+Y7Dv7J/rwnxjjymZlC+jJ6LQAtgIGffQ9Fj+EsPZW/6jcliHTeAzBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741792524; c=relaxed/simple; bh=rQCyYo1q5LlHeQmc/jvBgqAwBqok1aeeDQVozDHX8OE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=in/a9VrCBv+udnocv07qspaKAdfioY0M3Wx8ueRROGYwv11shI6R/um0suAsj0Kq4G3ime72NC+u0+mJeO18iTJs3RjOK46I444yfABt3d8vwaV7M9/NtlLlGg+y9U1tDgF1e9PW2So0GK0IMmfv4hzyWwgEDHGT7+zQTs2qHIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZNiITNCF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZNiITNCF" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52CA9Pdo007562 for ; Wed, 12 Mar 2025 15:15:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sX4AAf7m5Hmzy6uxAgPsldQmewUW0wWhuO0d0xDGmO8=; b=ZNiITNCFHf76RD2d BJkcFBoTieDJGgtaZS2gQ2IZlTyTr5pKwG0dBaC9+MDHtzlXyajYlBG/DwOIvm6s pIBfhL8TylWKsX6J49MiXrMFfDkqVRykdaZcG2hdMJuOMHW+ZdO5JSrbcOqaMo/C EO3B64YRsoEMyk56ct9O8CZkbbPLqgQE0kb9bLU4ZRi9A/ZvCVQBMDDWBlI/ebBn AldGDf1exSUTGX/hZh2eN/VHbsnP8om+07/D5DtYenSgPRns1XWrNLJHiGkP1Nq1 Au+trOHPDMvWDcwyNE+8zOyNiZoLyHOGJKFKOaba66q8+TkHKKhQJVZpfLohO4Ub 8R1u8A== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45au2qjtfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Mar 2025 15:15:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2242ca2a4a5so70200285ad.2 for ; Wed, 12 Mar 2025 08:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741792521; x=1742397321; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sX4AAf7m5Hmzy6uxAgPsldQmewUW0wWhuO0d0xDGmO8=; b=JRfPw/uhqdL1beOb2CVF/NpQK14hTKCdIeQv0yjxj9OJi7Dxe9TnejLaky5N7duchR /3yIp1BzxL6alUs1GaL/hnA9ABmhutLx9Wba8A5aoLZPkKVi17hdU811Tm5El/zDzxcH dOisK4fAyDqrFZvlfhMXkLdD+9wNyZElJAXwjn9Klh0xxYmlo4ZKaV+JXgsXGnOQ8Dqt mZMVKR1W0h6ct9W3aI3vHwdmNgMNFQdxbblB2YkI/zLRWmmrS74UI+FqWRbuHp4JztZK kg8ACwJbQzffP8fckz1U+2bHADvPIpfLapcrMjrqUfkjZTaUxtx9DwBYjhdSLJyvhGcj NyHw== X-Forwarded-Encrypted: i=1; AJvYcCU3L1GxEcFD3PGFB4WKv+/bu5WEVV8K2GUhLr5PpgVAQxrkuBdYGmgp+HnzT5twmlKIEIYLes21IyXVuCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9pL3C8wx5cCns7f7402iNmIC/DhHn+HQ4VnAGwLgTgH9zcJ+H Dezid2pBqxrvrcMf+yLV4DGkJU6mEu3/6i/WsTMFnQQJ+okXwU9XKTM6lNIhJchxjzkxfTWOgML KtRLjFJYpyT8YKJPrc6LFoXlqC2LoNpm69f8CB+bzzVPT3g5+70n1Ru+/W5EydY0= X-Gm-Gg: ASbGncuMaoG65vMZFuSscp3nhvL1iFAqW9R1z6/SxIx83V+/zu+GXKcR6CELLnJfhtZ U6wrchjEfLFaAsiDddRXyHExlyHrrtSmDDvcloF2BRyfQnyVTEOoVhy12v9uKuhuYGFdo7bYGpN vSmQ8W2C6GvGAFKJd3OMNPuUw93lw8QywZ15cnK/jYKWtvLlkO0wwSVawgm/nMjHfnAnzOGaW0c pDW4lCBBzqptb+1mc6OXIa4sqVX15LYdTuW3tRrgJ2gQbcSrt0i5MyjwraUOG5D/vAD2y6k6nwA S28xo29GwjDr1pJRFyWv3X2ZWsNl4udMx/NDGhjwCCMRAKLYBQMWs3SNMjhv8tzUkNqkq/c= X-Received: by 2002:a17:903:32c5:b0:224:249f:9734 with SMTP id d9443c01a7336-2242887ecd7mr325197675ad.4.1741792520672; Wed, 12 Mar 2025 08:15:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOdNtgjzF0uLcKmrq8uktA9l8TaPAfGY6t6+ICMeOkLWYWs6gFJGHlW3ZY4NQTKvR6YiogdA== X-Received: by 2002:a17:903:32c5:b0:224:249f:9734 with SMTP id d9443c01a7336-2242887ecd7mr325197275ad.4.1741792520273; Wed, 12 Mar 2025 08:15:20 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736c78389d7sm7863261b3a.4.2025.03.12.08.15.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 08:15:19 -0700 (PDT) Message-ID: Date: Wed, 12 Mar 2025 08:15:18 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] wifi: iwlwifi: Fix uninitialized variable with __free() To: Dan Carpenter , Miri Korenblit Cc: Johannes Berg , Anjaneyulu , Emmanuel Grumbach , Avraham Stern , Yedidya Benshimol , Daniel Gabay , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: GxkrbrHQ2wwfxLe3axPFsSq1HTo5Pxfw X-Authority-Analysis: v=2.4 cv=G5ccE8k5 c=1 sm=1 tr=0 ts=67d1a509 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=KKAkSRfTAAAA:8 a=-Q16Wm--JIC0Ijc-Z3AA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: GxkrbrHQ2wwfxLe3axPFsSq1HTo5Pxfw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-12_05,2025-03-11_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=862 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503120104 On 3/12/2025 1:31 AM, Dan Carpenter wrote: > Pointers declared with the __free(kfree) attribute need to be initialized > because they will be passed to kfree() on every return path. There are > two return statement before the "cmd" pointer is initialized so this > leads to an uninitialized variable bug. > > Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver") > Signed-off-by: Dan Carpenter > --- > drivers/net/wireless/intel/iwlwifi/mld/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c > index c759c5c68dc0..1d4b2ad5d388 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c > +++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c > @@ -556,8 +556,8 @@ iwl_dbgfs_vif_twt_setup_write(struct iwl_mld *mld, char *buf, size_t count, > }; > struct ieee80211_vif *vif = data; > struct iwl_mld_vif *mld_vif = iwl_mld_vif_from_mac80211(vif); > + struct iwl_dhc_cmd *cmd __free(kfree) = NULL; hmm, I thought the recommended convention was to define __free() pointers at the point of allocation. cleanup.h explicitly says: * Given that the "__free(...) = NULL" pattern for variables defined at * the top of the function poses this potential interdependency problem * the recommendation is to always define and assign variables in one * statement and not group variable definitions at the top of the * function when __free() is used. > struct iwl_dhc_twt_operation *dhc_twt_cmd; > - struct iwl_dhc_cmd *cmd __free(kfree); > u64 target_wake_time; > u32 twt_operation, interval_exp, interval_mantissa, min_wake_duration; > u8 trigger, flow_type, flow_id, protection, tenth_param;