From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751791AbdITHJe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Sep 2017 03:09:34 -0400
Received: from mout.web.de ([212.227.15.14]:54293 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751578AbdITHJb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Sep 2017 03:09:31 -0400
Subject: Re: [PATCH 4/6] [media] go7007: Use common error handling code in
 s2250_probe()
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <b36ece3f-0f31-9bb6-14ae-c4abf7cd23ee@users.sourceforge.net>
 <c4d2e584-39ca-6e30-43ee-56088905149e@users.sourceforge.net>
 <20170919084216.ctvwpmswr3ckhwzc@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a2259b43-381e-b59f-5e5d-082ae4e80d5e@users.sourceforge.net>
Date: Wed, 20 Sep 2017 09:09:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170919084216.ctvwpmswr3ckhwzc@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:CozNHGxvR+CSHeGUtjRHCHbPzgG3ryaSLnLl/SThfLzN1hTkP2H
 3eojByblXtAGI5pAbFfp3EvX5tHypdDUixlIM/x4+UKxItCKD7rzcLEKKlTPoTG2YDntQgq
 OQcBsu/o6Kxw5bQuvT1wgD5at0NY66kg+iTv8ZY6VTd0EeMWsF2/Hnd0DODzrvYkIbJIVVt
 nH/2u9+eV9NYT739u+TEg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:dQp09gOa2Ik=:xeZe8SCGXfzvjhc7Ruqj3U
 KIWeDU2tfYJ5+p+MB5Vi58O39AlJz6J6DdnXPVflke582idchYtUZSTAq60XwgIrGRJs+ZmfV
 ZIr1brzJpDdIpXE98WEW5+A9UftOV73tUYRaN9K3V6DpIw/F2ySEFJVDgmH7B6U3OYJzvMto+
 D216Y99OLyV4SS54rigROEIRSzSO0O/FItb4F7Qb3wadYCu84PucAzmmOCyOtlHSk2S8T/Tpa
 7R1ySQj1IB5DqiKahq4hLml64nFsZpvZrVpHKQCSSSLp+a5TTsflpbbb+h4+QZqPwGjPmFG6B
 0ZwEU0QPgjz5yRs0BgYoi8l3RJijF9viad6QS87U4j3l78065f9dlomjSVTNNofcrUGef3d03
 EcRlOFYDu3Ro5pquijIUDPtbWpELbZSiV8CqeROC2h5JGyx3uXsjIt989OJ87PKRJtrIyggBN
 Qhr6p70/XDNufrFAJUtMdnB/Bnb7NzRji22TJ9nKQavyJ0s+T8aiSbaO+Gf1loEMHgM4jVXss
 Bi7QL6syv0EuPdLWib6rr2A/q/7DWJaBxYvscyS72DWOeWogPK8pvX3/cfACdK1MfKgKI805I
 N6Ga7JQiwRqGcjXi+feV10VVr5Yr/9QP9rr0BIUEdIOnYz0wq3KObrAKN3RTV3XfrUj6fiQOh
 uE5qivwPMzeuJI/zkxVx4Yt/rNARxnewkpuQaKBWwtNme+xxMMbH9KNDA+ldgr4LiHp47qHAK
 /CUatMKDsxyMZ/eCHdo5p6at92Q0OxWT8LUpKexos6yaQsUJqi5Ut5hnpInOUQ1ZcjSiwoSSn
 D/YOeRkO5hw/5GZwjjjBsjvo+RqzLDFjXaDOtZwaO0Nf0bhYNs=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client,
>>  	/* initialize the audio */
>>  	if (write_regs(audio, aud_regs) < 0) {
>>  		dev_err(&client->dev, "error initializing audio\n");
>> -		goto fail;
>> +		goto e_io;
> 
> Preserve the error code.

Do you suggest then to adjust the implementation of the function "write_regs"
so that a more meaningful value would be used instead of the failure indication "-1"?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/go7007/s2250-board.c?h=v4.14-rc1#n302
http://elixir.free-electrons.com/linux/v4.14-rc1/source/drivers/media/usb/go7007/s2250-board.c#L298

Regards,
Markus