From: Joe Perches <joe@perches.com>
To: Vitor Soares <ivitro@gmail.com>, Andy Whitcroft <apw@canonical.com>
Cc: Vitor Soares <vitor.soares@toradex.com>,
linux-kernel@vger.kernel.org,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] checkpatch: add .dtso to DT compatible string vendor check
Date: Wed, 13 May 2026 12:18:23 -0700 [thread overview]
Message-ID: <a236018191f0798ed4ebb43cdcf1144e2d829e68.camel@perches.com> (raw)
In-Reply-To: <20260513171514.889168-2-ivitro@gmail.com>
On Wed, 2026-05-13 at 18:15 +0100, Vitor Soares wrote:
> Extend the DT compatible documentation check to match .dtso files so
> that vendor-prefixed compatibles in overlay files trigger the
> UNDOCUMENTED_DT_STRING warning when the vendor is absent from
> vendor-prefixes.yaml.
>
> Assisted-by: Claude:claude-sonnet-4.6
> Signed-off-by: Vitor Soares <[vitor.soares@toradex.com](mailto:vitor.soares@toradex.com)>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3774,7 +3774,7 @@ sub process {
>
> # check for DT compatible documentation
> if (defined $root &&
> - (($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
> + (($realfile =~ /\.(dts|dtsi|dtso)$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
Use (?:...) to avoid capture groups.
And presumably all checks for dts.? files and locations should be modified
$ git grep -n dts scripts/checkpatch.pl
scripts/checkpatch.pl:3777: (($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
scripts/checkpatch.pl:3807: if ($realfile =~ /\.(dts|dtsi|dtso)$/ &&
scripts/checkpatch.pl:3824: if ($realfile =~ /\.(c|rs|dts|dtsi)$/) {
scripts/checkpatch.pl:3886: next if ($realfile !~ /\.(h|c|rs|s|S|sh|dtsi|dts)$/);
scripts/checkpatch.pl:3985: next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
prev parent reply other threads:[~2026-05-13 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 17:15 [PATCH] checkpatch: add .dtso to DT compatible string vendor check Vitor Soares
2026-05-13 19:18 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a236018191f0798ed4ebb43cdcf1144e2d829e68.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=ivitro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=vitor.soares@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox