public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Frank Wunderlich <wichtig@fw-web.de>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Collabora Kernel ML <kernel@collabora.com>,
	Frank Wunderlich <linux@fw-web.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Hanks Chen <hanks.chen@mediatek.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"
Date: Thu, 20 Aug 2020 08:56:34 +0100	[thread overview]
Message-ID: <a23bac35d20eb002bdfb5263bf5dd213@kernel.org> (raw)
In-Reply-To: <CAGETcx9_A-E5b-JxT2G142mGxqoo8xqFNEgT+CNWt=oOv0Z5+w@mail.gmail.com>

On 2020-08-19 19:51, Saravana Kannan wrote:
> On Wed, Aug 19, 2020 at 9:52 AM Frank Wunderlich <wichtig@fw-web.de> 
> wrote:
>> 
>> hi,
>> 
>> does the fix you've linked to my revert [1] not work in your case?
>> 
>> [1] https://patchwork.kernel.org/patch/11718481/
> 
> Thanks for pointing it out Frank. Also, might want to avoid top
> posting in the future.
> 
> Enric, Can you please try that other fix and see if that solves your 
> issue?

I think Enric was clear that the driver does probe correctly
(meaning that he has the fix in his tree). It is everything else
that breaks, because none of the drivers on the platform are
equipped to defer their own probing.

I think we need to change this works right now, meaning that we can't
blindly change the behaviour of *built-in* drivers. I'll see if I can
come up with something quickly, but I'll otherwise take Enric patch.

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2020-08-20  7:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 16:19 [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver" Enric Balletbo i Serra
     [not found] ` <C9E59107-CE83-4554-9447-5DE5BEE09A3B@fw-web.de>
2020-08-19 18:51   ` Saravana Kannan
2020-08-20  7:56     ` Marc Zyngier [this message]
2020-08-20  8:07       ` Saravana Kannan
2020-08-20 14:53         ` Marc Zyngier
2020-08-20 19:39           ` Saravana Kannan
2020-08-21  9:20           ` Enric Balletbo i Serra
2020-08-21 10:17             ` Marc Zyngier
2020-08-21 14:03               ` Frank Wunderlich
2020-08-25 23:40               ` [tip: irq/urgent] irqchip: Revert modular support for drivers using IRQCHIP_PLATFORM_DRIVER helperse tip-bot2 for Marc Zyngier
  -- strict thread matches above, loose matches on Subject: below --
2020-08-17 14:57 [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver" Frank Wunderlich
2020-08-17 15:04 ` Enric Balletbo Serra
2020-08-21 14:07   ` Frank Wunderlich
2020-08-17 15:27 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a23bac35d20eb002bdfb5263bf5dd213@kernel.org \
    --to=maz@kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=hanks.chen@mediatek.com \
    --cc=hsinyi@chromium.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@fw-web.de \
    --cc=matthias.bgg@gmail.com \
    --cc=saravanak@google.com \
    --cc=tglx@linutronix.de \
    --cc=wichtig@fw-web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox