From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA04C77B60 for ; Mon, 3 Apr 2023 08:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbjDCIec (ORCPT ); Mon, 3 Apr 2023 04:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231375AbjDCIe3 (ORCPT ); Mon, 3 Apr 2023 04:34:29 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EE6C59D2 for ; Mon, 3 Apr 2023 01:34:23 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pjFdi-0006hM-RM; Mon, 03 Apr 2023 10:34:10 +0200 Message-ID: Date: Mon, 3 Apr 2023 10:34:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2] clk: imx: imx6sx: spdif clock rate is too high for asrc Content-Language: en-US To: "Peng Fan (OSS)" , abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: Peng Fan , Shengjiu Wang , linux-kernel@vger.kernel.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230403082138.3195452-1-peng.fan@oss.nxp.com> From: Ahmad Fatoum In-Reply-To: <20230403082138.3195452-1-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Peng, On 03.04.23 10:21, Peng Fan (OSS) wrote: > From: Shengjiu Wang > > spdif clock is one of the asrc clock source, which is used > for ideal ratio mode. when set to 98.304MHz, it cause the > divider of asrc input clock and output clock exceed the > maximum value, and asrc driver saturate the value to maximum > value, which will cause the ASRC's performance very bad. > So we need to set spdif clock to a proper rate. which make asrc > divider not exceed maximum value, at least one of divider not > exceed maximum value. > The target is spdif clock rate / output(or input) sample rate > less than 1024(which is maximum divider). > > Fixes: f1541e15e38e ("clk: imx6sx: Switch to clk_hw based API") Before referenced commit, it looked like this: clk_set_rate(clks[IMX6SX_CLK_SPDIF_PODF], 98304000); I think commit d55135689019 ("ARM: imx: add clock driver for imx6sx") is what you're after. Cheers, Ahmad > Signed-off-by: Shengjiu Wang > Signed-off-by: Peng Fan > --- > > V2: > Add Fixes tag > > drivers/clk/imx/clk-imx6sx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c > index 7cf86707bc39..3face052527d 100644 > --- a/drivers/clk/imx/clk-imx6sx.c > +++ b/drivers/clk/imx/clk-imx6sx.c > @@ -520,7 +520,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) > clk_set_rate(hws[IMX6SX_CLK_PLL4_AUDIO_DIV]->clk, 393216000); > > clk_set_parent(hws[IMX6SX_CLK_SPDIF_SEL]->clk, hws[IMX6SX_CLK_PLL4_AUDIO_DIV]->clk); > - clk_set_rate(hws[IMX6SX_CLK_SPDIF_PODF]->clk, 98304000); > + clk_set_rate(hws[IMX6SX_CLK_SPDIF_PODF]->clk, 24576000); > > clk_set_parent(hws[IMX6SX_CLK_AUDIO_SEL]->clk, hws[IMX6SX_CLK_PLL3_USB_OTG]->clk); > clk_set_rate(hws[IMX6SX_CLK_AUDIO_PODF]->clk, 24000000); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |