linux-next: build failure after merge of the mediatek tree

linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6922 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/soc/mediatek/mtk-scpsys.c:773:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
  773 |   .subsys_clk_prefix = "isp",
      |    ^~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:773:24: warning: initialization of 'unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  773 |   .subsys_clk_prefix = "isp",
      |                        ^~~~~
drivers/soc/mediatek/mtk-scpsys.c:773:24: note: (near initialization for 'scp_domain_data_mt6765[3].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:774:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
  774 |   .bp_table = {
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:775:4: error: implicit declaration of function 'BUS_PROT' [-Werror=implicit-function-declaration]
  775 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:775:13: error: 'IFR_TYPE' undeclared here (not in a function)
  775 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
      |             ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:777:13: error: 'SMI_TYPE' undeclared here (not in a function)
  777 |    BUS_PROT(SMI_TYPE, 0x3C4, 0x3C8, 0, 0x3C0,
      |             ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:787:4: error: 'const struct scp_domain_data' has no member named 'basic_clk_id'
  787 |   .basic_clk_id = {"mm"},
      |    ^~~~~~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:787:3: warning: braces around scalar initializer
  787 |   .basic_clk_id = {"mm"},
      |   ^
drivers/soc/mediatek/mtk-scpsys.c:787:3: note: (near initialization for 'scp_domain_data_mt6765[1].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:787:20: warning: initialization of 'u32' {aka 'unsigned int'} from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  787 |   .basic_clk_id = {"mm"},
      |                    ^~~~
drivers/soc/mediatek/mtk-scpsys.c:787:20: note: (near initialization for 'scp_domain_data_mt6765[1].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:788:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
  788 |   .subsys_clk_prefix = "mm",
      |    ^~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:788:24: error: cannot initialize array of 'enum clk_id' from a string literal with type array of 'char'
  788 |   .subsys_clk_prefix = "mm",
      |                        ^~~~
drivers/soc/mediatek/mtk-scpsys.c:788:24: note: (near initialization for 'scp_domain_data_mt6765[1].clk_id')
drivers/soc/mediatek/mtk-scpsys.c:789:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
  789 |   .bp_table = {
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:789:3: warning: braces around scalar initializer
  789 |   .bp_table = {
      |   ^
drivers/soc/mediatek/mtk-scpsys.c:789:3: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
drivers/soc/mediatek/mtk-scpsys.c:792:4: warning: excess elements in scalar initializer
  792 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:792:4: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
drivers/soc/mediatek/mtk-scpsys.c:794:4: warning: excess elements in scalar initializer
  794 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:794:4: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
drivers/soc/mediatek/mtk-scpsys.c:804:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
  804 |   .bp_table = {
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:804:3: warning: braces around scalar initializer
  804 |   .bp_table = {
      |   ^
drivers/soc/mediatek/mtk-scpsys.c:804:3: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:807:4: warning: excess elements in scalar initializer
  807 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:807:4: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:809:4: warning: excess elements in scalar initializer
  809 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:809:4: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:819:4: error: 'const struct scp_domain_data' has no member named 'basic_clk_id'
  819 |   .basic_clk_id = {"mfg"},
      |    ^~~~~~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:819:3: warning: braces around scalar initializer
  819 |   .basic_clk_id = {"mfg"},
      |   ^
drivers/soc/mediatek/mtk-scpsys.c:819:3: note: (near initialization for 'scp_domain_data_mt6765[2].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:819:20: warning: initialization of 'u32' {aka 'unsigned int'} from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  819 |   .basic_clk_id = {"mfg"},
      |                    ^~~~~
drivers/soc/mediatek/mtk-scpsys.c:819:20: note: (near initialization for 'scp_domain_data_mt6765[2].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:827:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
  827 |   .bp_table = {
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:827:3: warning: braces around scalar initializer
  827 |   .bp_table = {
      |   ^
drivers/soc/mediatek/mtk-scpsys.c:827:3: note: (near initialization for 'scp_domain_data_mt6765[4].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:830:4: warning: excess elements in scalar initializer
  830 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
      |    ^~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:830:4: note: (near initialization for 'scp_domain_data_mt6765[4].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:840:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
  840 |   .subsys_clk_prefix = "cam",
      |    ^~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-scpsys.c:840:24: warning: initialization of 'unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  840 |   .subsys_clk_prefix = "cam",
      |                        ^~~~~
drivers/soc/mediatek/mtk-scpsys.c:840:24: note: (near initialization for 'scp_domain_data_mt6765[6].bus_prot_mask')
drivers/soc/mediatek/mtk-scpsys.c:841:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
  841 |   .bp_table = {
      |    ^~~~~~~~

Caused by commit

  3742fd77013f ("soc: mediatek: add MT6765 scpsys and subdomain support")

I have used the mediatek tree from next-20191213 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Matthias Brugger]

Hi Stephen,

On 15/12/2019 23:03, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mediatek tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/soc/mediatek/mtk-scpsys.c:773:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
>   773 |   .subsys_clk_prefix = "isp",
>       |    ^~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:773:24: warning: initialization of 'unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
>   773 |   .subsys_clk_prefix = "isp",
>       |                        ^~~~~
> drivers/soc/mediatek/mtk-scpsys.c:773:24: note: (near initialization for 'scp_domain_data_mt6765[3].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:774:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
>   774 |   .bp_table = {
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:775:4: error: implicit declaration of function 'BUS_PROT' [-Werror=implicit-function-declaration]
>   775 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:775:13: error: 'IFR_TYPE' undeclared here (not in a function)
>   775 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
>       |             ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:777:13: error: 'SMI_TYPE' undeclared here (not in a function)
>   777 |    BUS_PROT(SMI_TYPE, 0x3C4, 0x3C8, 0, 0x3C0,
>       |             ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:787:4: error: 'const struct scp_domain_data' has no member named 'basic_clk_id'
>   787 |   .basic_clk_id = {"mm"},
>       |    ^~~~~~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:787:3: warning: braces around scalar initializer
>   787 |   .basic_clk_id = {"mm"},
>       |   ^
> drivers/soc/mediatek/mtk-scpsys.c:787:3: note: (near initialization for 'scp_domain_data_mt6765[1].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:787:20: warning: initialization of 'u32' {aka 'unsigned int'} from 'char *' makes integer from pointer without a cast [-Wint-conversion]
>   787 |   .basic_clk_id = {"mm"},
>       |                    ^~~~
> drivers/soc/mediatek/mtk-scpsys.c:787:20: note: (near initialization for 'scp_domain_data_mt6765[1].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:788:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
>   788 |   .subsys_clk_prefix = "mm",
>       |    ^~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:788:24: error: cannot initialize array of 'enum clk_id' from a string literal with type array of 'char'
>   788 |   .subsys_clk_prefix = "mm",
>       |                        ^~~~
> drivers/soc/mediatek/mtk-scpsys.c:788:24: note: (near initialization for 'scp_domain_data_mt6765[1].clk_id')
> drivers/soc/mediatek/mtk-scpsys.c:789:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
>   789 |   .bp_table = {
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:789:3: warning: braces around scalar initializer
>   789 |   .bp_table = {
>       |   ^
> drivers/soc/mediatek/mtk-scpsys.c:789:3: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
> drivers/soc/mediatek/mtk-scpsys.c:792:4: warning: excess elements in scalar initializer
>   792 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:792:4: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
> drivers/soc/mediatek/mtk-scpsys.c:794:4: warning: excess elements in scalar initializer
>   794 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:794:4: note: (near initialization for 'scp_domain_data_mt6765[1].caps')
> drivers/soc/mediatek/mtk-scpsys.c:804:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
>   804 |   .bp_table = {
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:804:3: warning: braces around scalar initializer
>   804 |   .bp_table = {
>       |   ^
> drivers/soc/mediatek/mtk-scpsys.c:804:3: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:807:4: warning: excess elements in scalar initializer
>   807 |    BUS_PROT(IFR_TYPE, 0x2A8, 0x2AC, 0, 0x258,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:807:4: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:809:4: warning: excess elements in scalar initializer
>   809 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:809:4: note: (near initialization for 'scp_domain_data_mt6765[0].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:819:4: error: 'const struct scp_domain_data' has no member named 'basic_clk_id'
>   819 |   .basic_clk_id = {"mfg"},
>       |    ^~~~~~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:819:3: warning: braces around scalar initializer
>   819 |   .basic_clk_id = {"mfg"},
>       |   ^
> drivers/soc/mediatek/mtk-scpsys.c:819:3: note: (near initialization for 'scp_domain_data_mt6765[2].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:819:20: warning: initialization of 'u32' {aka 'unsigned int'} from 'char *' makes integer from pointer without a cast [-Wint-conversion]
>   819 |   .basic_clk_id = {"mfg"},
>       |                    ^~~~~
> drivers/soc/mediatek/mtk-scpsys.c:819:20: note: (near initialization for 'scp_domain_data_mt6765[2].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:827:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
>   827 |   .bp_table = {
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:827:3: warning: braces around scalar initializer
>   827 |   .bp_table = {
>       |   ^
> drivers/soc/mediatek/mtk-scpsys.c:827:3: note: (near initialization for 'scp_domain_data_mt6765[4].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:830:4: warning: excess elements in scalar initializer
>   830 |    BUS_PROT(IFR_TYPE, 0x2A0, 0x2A4, 0, 0x228,
>       |    ^~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:830:4: note: (near initialization for 'scp_domain_data_mt6765[4].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:840:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
>   840 |   .subsys_clk_prefix = "cam",
>       |    ^~~~~~~~~~~~~~~~~
> drivers/soc/mediatek/mtk-scpsys.c:840:24: warning: initialization of 'unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
>   840 |   .subsys_clk_prefix = "cam",
>       |                        ^~~~~
> drivers/soc/mediatek/mtk-scpsys.c:840:24: note: (near initialization for 'scp_domain_data_mt6765[6].bus_prot_mask')
> drivers/soc/mediatek/mtk-scpsys.c:841:4: error: 'const struct scp_domain_data' has no member named 'bp_table'
>   841 |   .bp_table = {
>       |    ^~~~~~~~
> 
> Caused by commit
> 
>   3742fd77013f ("soc: mediatek: add MT6765 scpsys and subdomain support")
> 
> I have used the mediatek tree from next-20191213 for today.
> 

Thanks for the heads-up. I dropped the patch for now until it's dependencies are
all merged. Sorry for the oversight.

Regards
Matthias

Re: linux-next: build failure after merge of the mediatek tree

[Macpaul Lin]

On Mon, 2019-12-16 at 09:49 +0100, Matthias Brugger wrote:
> Hi Stephen,
> 
> On 15/12/2019 23:03, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the mediatek tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/soc/mediatek/mtk-scpsys.c:773:4: error: 'const struct scp_domain_data' has no member named 'subsys_clk_prefix'
> >   773 |   .subsys_clk_prefix = "isp",
> >       |    ^~~~~~~~~~~~~~~~~

[Deleted...]
> > Caused by commit
> > 
> >   3742fd77013f ("soc: mediatek: add MT6765 scpsys and subdomain support")
> > 
> > I have used the mediatek tree from next-20191213 for today.
> > 
> 
> Thanks for the heads-up. I dropped the patch for now until it's dependencies are
> all merged. Sorry for the oversight.
> 
> Regards
> Matthias

Hi Mathhias,

According to the build error, it looks like this patch has a dependency
with the patch https://patchwork.kernel.org/patch/11118347/ .

The patch "[v7,10/13] soc: mediatek: Add subsys clock control for bus
protection" introduced member subsys_clk_prefix and other required
members.

Thanks!

Regards,
Macpaul Lin

linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/soc/mediatek/mtk-svs.c: In function 'svs_get_bank_volts_v3':
drivers/soc/mediatek/mtk-svs.c:887:47: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
  887 |                         svsb->volt[turn_pt] = FIELD_GET(SVSB_VOPS_FLD_VOP0_4, vop30);
      |                                               ^~~~~~~~~
      |                                               FOLL_GET
drivers/soc/mediatek/mtk-svs.c: In function 'svs_set_bank_freq_pct_v2':
drivers/soc/mediatek/mtk-svs.c:1073:25: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
 1073 |         freqpct74_val = FIELD_PREP(SVSB_FREQPCTS_FLD_PCT0_4, svsb->freq_pct[8]) |
      |                         ^~~~~~~~~~

Caused by commit

  a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")

I have used the mediatek tree from next-20220829 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Matthias Brugger]

Hi Stephen,

On 30/08/2022 01:42, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mediatek tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/soc/mediatek/mtk-svs.c: In function 'svs_get_bank_volts_v3':
> drivers/soc/mediatek/mtk-svs.c:887:47: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
>    887 |                         svsb->volt[turn_pt] = FIELD_GET(SVSB_VOPS_FLD_VOP0_4, vop30);
>        |                                               ^~~~~~~~~
>        |                                               FOLL_GET
> drivers/soc/mediatek/mtk-svs.c: In function 'svs_set_bank_freq_pct_v2':
> drivers/soc/mediatek/mtk-svs.c:1073:25: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>   1073 |         freqpct74_val = FIELD_PREP(SVSB_FREQPCTS_FLD_PCT0_4, svsb->freq_pct[8]) |
>        |                         ^~~~~~~~~~
> 
> Caused by commit
> 
>    a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")
> 
> I have used the mediatek tree from next-20220829 for today.
> 

Thanks for the information. We were able to identify the issue (not really 
difficult) and I pushed a fix to my for-next tree. So we should be good by tomorrow.

Cheers,
Matthias

linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (arm64
defconfig) failed like this:

Error: arch/arm64/boot/dts/mediatek/mt6795.dtsi:647.21-22 syntax error
FATAL ERROR: Unable to parse input tree

Maybe caused by commit

  a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")

but I don't know how.

I have reverted that commit (and the following 2) for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 03/04/23 09:52, Stephen Rothwell ha scritto:
> Hi all,
> 
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
> 
> Error: arch/arm64/boot/dts/mediatek/mt6795.dtsi:647.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> Maybe caused by commit
> 
>    a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
> 
> but I don't know how.
> 
> I have reverted that commit (and the following 2) for today.
> 

Matthias, this issue happens because you didn't apply 07/17 [1] from the
6795/xperia-m5 series...

[1]: 
https://lore.kernel.org/all/20230327083647.22017-8-angelogioacchino.delregno@collabora.com/

That contains the mediatek,mt6795-gce.h header that has the definitions used in
a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
....and this is the reason of the syntax error.

Does this commit have to go through devicetree trees?
I'm adding Krzysztof and Rob to the loop for this.

Regards,
Angelo

Re: linux-next: build failure after merge of the mediatek tree

[Krzysztof Kozlowski]

On 03/04/2023 10:43, AngeloGioacchino Del Regno wrote:
> Il 03/04/23 09:52, Stephen Rothwell ha scritto:
>> Hi all,
>>
>> After merging the mediatek tree, today's linux-next build (arm64
>> defconfig) failed like this:
>>
>> Error: arch/arm64/boot/dts/mediatek/mt6795.dtsi:647.21-22 syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Maybe caused by commit
>>
>>    a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
>>
>> but I don't know how.
>>
>> I have reverted that commit (and the following 2) for today.
>>
> 
> Matthias, this issue happens because you didn't apply 07/17 [1] from the
> 6795/xperia-m5 series...
> 
> [1]: 
> https://lore.kernel.org/all/20230327083647.22017-8-angelogioacchino.delregno@collabora.com/

Bindings are supposed to go via subsystem (driver) tree and only via ARM
SoC if the former is not interested in them.

I don't think the issue happens because Matthias did not apply binding
patch. Nothing in the cover letter or the patch mentioned such
dependency, so why he should pick up unrelated patch?

The submitter should clearly mark such dependencies or make patches
independent. It's nothing new, for clock/reset drivers (driver + binding
+ DTS) uncoupling the dependency is pretty often a requirement or
maintainers need to coordinate with cross-tree pulls (and DTS cannot get
pulled into the driver tree/branch).

> 
> That contains the mediatek,mt6795-gce.h header that has the definitions used in
> a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
> ....and this is the reason of the syntax error.
> 
> Does this commit have to go through devicetree trees?

Bindings go via subsystem maintainer, so here rather mailbox. Not DT tree.

> I'm adding Krzysztof and Rob to the loop for this.

I guess now, the easiest would be if Matthias takes the binding change
with mailbox Ack. Assuming there are no conflicts there...


Best regards,
Krzysztof

Re: linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi all,

On Mon, 3 Apr 2023 17:52:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
> 
> Error: arch/arm64/boot/dts/mediatek/mt6795.dtsi:647.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> Maybe caused by commit
> 
>   a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
> 
> but I don't know how.
> 
> I have reverted that commit (and the following 2) for today.

Ping?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Matthias Brugger]

On 11/04/2023 01:24, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 3 Apr 2023 17:52:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the mediatek tree, today's linux-next build (arm64
>> defconfig) failed like this:
>>
>> Error: arch/arm64/boot/dts/mediatek/mt6795.dtsi:647.21-22 syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Maybe caused by commit
>>
>>    a7c7f1fe2fde ("arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks")
>>
>> but I don't know how.
>>
>> I have reverted that commit (and the following 2) for today.
> 
> Ping?
> 

I dropped the corresponding commits and resubmitted. Sorry for the delay, I was 
on holidays and without a computer...

Regards,
Matthias

linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (arm64
defconfig) failed like this:

aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_update_bits':
drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask'
aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_probe':
drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to `cmdq_dev_get_client_reg'
aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_enable_by_cmdq':
drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write'
aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_probe':
drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to `cmdq_dev_get_client_reg'

Caused by commit

  b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)")

I have used the mediatek tree from next-20230331 for today.

There were also the following warnings:

arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not have leading "0x"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not have leading "0x"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format error, expected "10"
arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format error, expected "12"

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 03/04/23 10:15, Stephen Rothwell ha scritto:
> Hi all,
> 
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
> 
> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_update_bits':
> drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_probe':
> drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to `cmdq_dev_get_client_reg'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_enable_by_cmdq':
> drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_probe':
> drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to `cmdq_dev_get_client_reg'
> 
> Caused by commit
> 
>    b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)")
> 

I can recheck why this happens - otherwise we can simply avoid applying that commit
if there's no time.

> I have used the mediatek tree from next-20230331 for today.
> 
> There were also the following warnings:
> 
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not have leading "0x"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not have leading "0x"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format error, expected "10"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format error, expected "12"
> 

Matthias, should I send new versions of the commits, addressing this sad overlook
from my side, or would you fix that, or should I send new commits cleaning that up
on top?

Please let me know how to proceed here.

Thanks,
Angelo

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 03/04/23 10:45, AngeloGioacchino Del Regno ha scritto:
> Il 03/04/23 10:15, Stephen Rothwell ha scritto:
>> Hi all,
>>
>> After merging the mediatek tree, today's linux-next build (arm64
>> defconfig) failed like this:
>>
>> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
>> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function 
>> `mtk_mmsys_update_bits':
>> drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function 
>> `mtk_mmsys_probe':
>> drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to 
>> `cmdq_dev_get_client_reg'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function 
>> `mtk_mutex_enable_by_cmdq':
>> drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function 
>> `mtk_mutex_probe':
>> drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to 
>> `cmdq_dev_get_client_reg'
>>
>> Caused by commit
>>
>>    b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)")
>>
> 
> I can recheck why this happens - otherwise we can simply avoid applying that commit
> if there's no time.
> 

Followup: I've rechecked and sent a solution for that; please check [1].

[1]: 
https://lore.kernel.org/lkml/20230403093304.276418-1-angelogioacchino.delregno@collabora.com/


>> I have used the mediatek tree from next-20230331 for today.
>>
>> There were also the following warnings:
>>
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning 
>> (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not 
>> have leading "0x"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning 
>> (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not 
>> have leading "0x"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning 
>> (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format 
>> error, expected "10"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning 
>> (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format 
>> error, expected "12"
>>
> 
> Matthias, should I send new versions of the commits, addressing this sad overlook
> from my side, or would you fix that, or should I send new commits cleaning that up
> on top?
> 
> Please let me know how to proceed here.
> 
> Thanks,
> Angelo
> 

Re: linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]

Hi all,

On Mon, 3 Apr 2023 18:15:52 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
> 
> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_update_bits':
> drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_probe':
> drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to `cmdq_dev_get_client_reg'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_enable_by_cmdq':
> drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write'
> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_probe':
> drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to `cmdq_dev_get_client_reg'
> 
> Caused by commit
> 
>   b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)")
> 
> I have used the mediatek tree from next-20230331 for today.
> 
> There were also the following warnings:
> 
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not have leading "0x"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not have leading "0x"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format error, expected "10"
> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format error, expected "12"

Ping?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Matthias Brugger]

On 11/04/2023 01:25, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 3 Apr 2023 18:15:52 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the mediatek tree, today's linux-next build (arm64
>> defconfig) failed like this:
>>
>> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
>> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_update_bits':
>> drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function `mtk_mmsys_probe':
>> drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to `cmdq_dev_get_client_reg'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_enable_by_cmdq':
>> drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write'
>> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function `mtk_mutex_probe':
>> drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to `cmdq_dev_get_client_reg'
>>
>> Caused by commit
>>
>>    b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)")
>>
>> I have used the mediatek tree from next-20230331 for today.
>>
>> There were also the following warnings:
>>
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not have leading "0x"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not have leading "0x"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format error, expected "10"
>> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format error, expected "12"
> 
> Ping?
> 

Fix from Angelo applied. Sorry for the delay.

Matthias

linux-next: build failure after merge of the mediatek tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (arm64
defconfig) failed like this:

/tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 syntax error
FATAL ERROR: Unable to parse input tree
make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1

Caused by commit

  d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")

I have used the last version of the mediatek tree from 20240613 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Julien Panis]

On 6/17/24 18:44, Mark Brown wrote:
> Hi all,
>
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
>
> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 syntax error
> FATAL ERROR: Unable to parse input tree
> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>
> Caused by commit
>
>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>
> I have used the last version of the mediatek tree from 20240613 instead.

Hello Mark,

Here is the explanation:
https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/

For some reason, the 2 first commits of the series were not applied
with the dts. These commits are needed because they contain some
definitions used by the dts.

Julien

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 18/06/24 09:49, Julien Panis ha scritto:
> On 6/17/24 18:44, Mark Brown wrote:
>> Hi all,
>>
>> After merging the mediatek tree, today's linux-next build (arm64
>> defconfig) failed like this:
>>
>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 syntax 
>> error
>> FATAL ERROR: Unable to parse input tree
>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>
>> Caused by commit
>>
>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>
>> I have used the last version of the mediatek tree from 20240613 instead.
> 
> Hello Mark,
> 
> Here is the explanation:
> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
> 
> For some reason, the 2 first commits of the series were not applied
> with the dts. These commits are needed because they contain some
> definitions used by the dts.
> 
> Julien

I'm not sure how should I proceed here.

Only the mediatek tree is broken, linux-next is ok... should I pick the
commits from next or should I remove the dts commits from the mediatek trees?

First time happening.... :-)

Regards,
Angelo

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
> Il 18/06/24 09:49, Julien Panis ha scritto:
>> On 6/17/24 18:44, Mark Brown wrote:
>>> Hi all,
>>>
>>> After merging the mediatek tree, today's linux-next build (arm64
>>> defconfig) failed like this:
>>>
>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 
>>> syntax error
>>> FATAL ERROR: Unable to parse input tree
>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>>
>>> Caused by commit
>>>
>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>>
>>> I have used the last version of the mediatek tree from 20240613 instead.
>>
>> Hello Mark,
>>
>> Here is the explanation:
>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>
>> For some reason, the 2 first commits of the series were not applied
>> with the dts. These commits are needed because they contain some
>> definitions used by the dts.
>>
>> Julien
> 
> I'm not sure how should I proceed here.
> 

Reiterating, I'm sure how should I proceed.

I'm removing those patches from mediatek for-next until further notice.

Regards,
Angelo

> Only the mediatek tree is broken, linux-next is ok... should I pick the
> commits from next or should I remove the dts commits from the mediatek trees?
> 
> First time happening.... :-)
> 
> Regards,
> Angelo

Re: linux-next: build failure after merge of the mediatek tree

[Julien Panis]

On 6/18/24 12:20, AngeloGioacchino Del Regno wrote:
> Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
>> Il 18/06/24 09:49, Julien Panis ha scritto:
>>> On 6/17/24 18:44, Mark Brown wrote:
>>>> Hi all,
>>>>
>>>> After merging the mediatek tree, today's linux-next build (arm64
>>>> defconfig) failed like this:
>>>>
>>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: 
>>>> Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 syntax error
>>>> FATAL ERROR: Unable to parse input tree
>>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>>>
>>>> Caused by commit
>>>>
>>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>>>
>>>> I have used the last version of the mediatek tree from 20240613 instead.
>>>
>>> Hello Mark,
>>>
>>> Here is the explanation:
>>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>>
>>> For some reason, the 2 first commits of the series were not applied
>>> with the dts. These commits are needed because they contain some
>>> definitions used by the dts.
>>>
>>> Julien
>>
>> I'm not sure how should I proceed here.
>>
>
> Reiterating, I'm sure how should I proceed.
>
> I'm removing those patches from mediatek for-next until further notice.
>
> Regards,
> Angelo

Just for my information: Should we just wait for another maintainer
to pick the 2 missing patches ? Who is in charge of doing it ?

Julien

Re: linux-next: build failure after merge of the mediatek tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

On Tue, Jun 18, 2024 at 06:45:17PM +0200, Julien Panis wrote:

> Just for my information: Should we just wait for another maintainer
> to pick the 2 missing patches ? Who is in charge of doing it ?

In general this is something the relevant maintainers should coordinate
between themselves.  Generally things tend to work better if everything
goes through the same tree so you don't get bisection issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[Daniel Lezcano]

On 18/06/2024 18:45, Julien Panis wrote:
> On 6/18/24 12:20, AngeloGioacchino Del Regno wrote:
>> Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
>>> Il 18/06/24 09:49, Julien Panis ha scritto:
>>>> On 6/17/24 18:44, Mark Brown wrote:
>>>>> Hi all,
>>>>>
>>>>> After merging the mediatek tree, today's linux-next build (arm64
>>>>> defconfig) failed like this:
>>>>>
>>>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>>>> Error: 
>>>>> /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 
>>>>> syntax error
>>>>> FATAL ERROR: Unable to parse input tree
>>>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] 
>>>>> Error 1
>>>>>
>>>>> Caused by commit
>>>>>
>>>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default 
>>>>> thermal zones")
>>>>>
>>>>> I have used the last version of the mediatek tree from 20240613 
>>>>> instead.
>>>>
>>>> Hello Mark,
>>>>
>>>> Here is the explanation:
>>>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>>>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>>>
>>>> For some reason, the 2 first commits of the series were not applied
>>>> with the dts. These commits are needed because they contain some
>>>> definitions used by the dts.
>>>>
>>>> Julien
>>>
>>> I'm not sure how should I proceed here.
>>>
>>
>> Reiterating, I'm sure how should I proceed.
>>
>> I'm removing those patches from mediatek for-next until further notice.
>>
>> Regards,
>> Angelo
> 
> Just for my information: Should we just wait for another maintainer
> to pick the 2 missing patches ? Who is in charge of doing it ?

I've picked the 2 first patches but they are going through the 
validation process through our CI. They will be available in a couple of 
days in linux-next.

If you want me to drop them and let them go through the Mediatek tree, 
just let me know.

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 18/06/24 20:03, Daniel Lezcano ha scritto:
> On 18/06/2024 18:45, Julien Panis wrote:
>> On 6/18/24 12:20, AngeloGioacchino Del Regno wrote:
>>> Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
>>>> Il 18/06/24 09:49, Julien Panis ha scritto:
>>>>> On 6/17/24 18:44, Mark Brown wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> After merging the mediatek tree, today's linux-next build (arm64
>>>>>> defconfig) failed like this:
>>>>>>
>>>>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>>>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 
>>>>>> syntax error
>>>>>> FATAL ERROR: Unable to parse input tree
>>>>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>>>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>>>>>
>>>>>> Caused by commit
>>>>>>
>>>>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>>>>>
>>>>>> I have used the last version of the mediatek tree from 20240613 instead.
>>>>>
>>>>> Hello Mark,
>>>>>
>>>>> Here is the explanation:
>>>>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>>>>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>>>>
>>>>> For some reason, the 2 first commits of the series were not applied
>>>>> with the dts. These commits are needed because they contain some
>>>>> definitions used by the dts.
>>>>>
>>>>> Julien
>>>>
>>>> I'm not sure how should I proceed here.
>>>>
>>>
>>> Reiterating, I'm sure how should I proceed.
>>>
>>> I'm removing those patches from mediatek for-next until further notice.
>>>
>>> Regards,
>>> Angelo
>>
>> Just for my information: Should we just wait for another maintainer
>> to pick the 2 missing patches ? Who is in charge of doing it ?
> 
> I've picked the 2 first patches but they are going through the validation process 
> through our CI. They will be available in a couple of days in linux-next.
> 
> If you want me to drop them and let them go through the Mediatek tree, just let me 
> know.
> 

Thanks but no, thanks :-)

Please, keep them in the thermal trees where they belong.
I will adjust accordingly.

Cheers,
Angelo

Re: linux-next: build failure after merge of the mediatek tree

[Julien Panis]

On 6/19/24 09:40, AngeloGioacchino Del Regno wrote:
> Il 18/06/24 20:03, Daniel Lezcano ha scritto:
>> On 18/06/2024 18:45, Julien Panis wrote:
>>> On 6/18/24 12:20, AngeloGioacchino Del Regno wrote:
>>>> Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
>>>>> Il 18/06/24 09:49, Julien Panis ha scritto:
>>>>>> On 6/17/24 18:44, Mark Brown wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> After merging the mediatek tree, today's linux-next build (arm64
>>>>>>> defconfig) failed like this:
>>>>>>>
>>>>>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: 
>>>>>>> Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>>>>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 syntax error
>>>>>>> FATAL ERROR: Unable to parse input tree
>>>>>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>>>>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>>>>>>
>>>>>>> Caused by commit
>>>>>>>
>>>>>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>>>>>>
>>>>>>> I have used the last version of the mediatek tree from 20240613 instead.
>>>>>>
>>>>>> Hello Mark,
>>>>>>
>>>>>> Here is the explanation:
>>>>>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>>>>>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>>>>>
>>>>>> For some reason, the 2 first commits of the series were not applied
>>>>>> with the dts. These commits are needed because they contain some
>>>>>> definitions used by the dts.
>>>>>>
>>>>>> Julien
>>>>>
>>>>> I'm not sure how should I proceed here.
>>>>>
>>>>
>>>> Reiterating, I'm sure how should I proceed.
>>>>
>>>> I'm removing those patches from mediatek for-next until further notice.
>>>>
>>>> Regards,
>>>> Angelo
>>>
>>> Just for my information: Should we just wait for another maintainer
>>> to pick the 2 missing patches ? Who is in charge of doing it ?
>>
>> I've picked the 2 first patches but they are going through the validation process through our CI. 
>> They will be available in a couple of days in linux-next.
>>
>> If you want me to drop them and let them go through the Mediatek tree, just let me know.
>>
>
> Thanks but no, thanks :-)
>
> Please, keep them in the thermal trees where they belong.
> I will adjust accordingly.
>
> Cheers,
> Angelo

Hello Angelo,

AFAICS, the dt-bindings patches are now in v6.10.
Would it be possible to re-apply the dts patches please ?

Julien

Re: linux-next: build failure after merge of the mediatek tree

[Kevin Hilman]

AngeloGioacchino Del Regno <angelogioacchino.delregno@kernel.org>
writes:

> Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto:
>> Il 18/06/24 09:49, Julien Panis ha scritto:
>>> On 6/17/24 18:44, Mark Brown wrote:
>>>> Hi all,
>>>>
>>>> After merging the mediatek tree, today's linux-next build (arm64
>>>> defconfig) failed like this:
>>>>
>>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port'
>>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 
>>>> syntax error
>>>> FATAL ERROR: Unable to parse input tree
>>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: 
>>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1
>>>>
>>>> Caused by commit
>>>>
>>>>    d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones")
>>>>
>>>> I have used the last version of the mediatek tree from 20240613 instead.
>>>
>>> Hello Mark,
>>>
>>> Here is the explanation:
>>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@baylibre.com/
>>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@baylibre.com/
>>>
>>> For some reason, the 2 first commits of the series were not applied
>>> with the dts. These commits are needed because they contain some
>>> definitions used by the dts.
>>>
>>> Julien
>> 
>> I'm not sure how should I proceed here.
>> 
>
> Reiterating, I'm sure how should I proceed.

You applied the dts patches but not the bindings, resulting in something
that doesn't build because of changes to #defines in the bindings.

Both of the bindings patches have already been acked by a DT maintainer
(Connor), so you should just apply the bindings along with the DT patches.

> I'm removing those patches from mediatek for-next until further notice.

Rather than remove the DT patches, you should just apply the bindings
patches.

Kevin

Re: linux-next: build failure after merge of the mediatek tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Tue, Jun 18, 2024 at 12:03:44PM +0200, AngeloGioacchino Del Regno wrote:
> Il 18/06/24 09:49, Julien Panis ha scritto:

> > For some reason, the 2 first commits of the series were not applied
> > with the dts. These commits are needed because they contain some
> > definitions used by the dts.

> I'm not sure how should I proceed here.

> Only the mediatek tree is broken, linux-next is ok... should I pick the
> commits from next or should I remove the dts commits from the mediatek trees?

> First time happening.... :-)

linux-next is only OK because I am merging an old version of the
mediatek tree rather than your current one.  The mediatek tree should be
fixed somehow so that it builds, either mechanism should be fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi all,

After merging the mediatek tree, today's linux-next build (arm64
defconfig) failed like this:

arch/arm64/boot/dts/mediatek/mt8188.dtsi:465.15-468.4: ERROR (phandle_references): /sound: Reference to non-existent node or label "accdet"

  also defined at arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi:1063.8-1094.3
ERROR: Input tree has errors, aborting (use -f to force output)

Caused by commit

  691712b065d3 ("arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mediatek tree

[AngeloGioacchino Del Regno]

Il 15/04/25 08:30, Stephen Rothwell ha scritto:
> Hi all,
> 
> After merging the mediatek tree, today's linux-next build (arm64
> defconfig) failed like this:
> 
> arch/arm64/boot/dts/mediatek/mt8188.dtsi:465.15-468.4: ERROR (phandle_references): /sound: Reference to non-existent node or label "accdet"
> 
>    also defined at arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi:1063.8-1094.3
> ERROR: Input tree has errors, aborting (use -f to force output)
> 
> Caused by commit
> 
>    691712b065d3 ("arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet")
> 
> I have reverted that commit for today.
> 

Sorry about that. I have dropped that commit from the tree.

Thanks,
Angelo