From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Alien Wesley <alienwesley51@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529
Date: Mon, 26 Aug 2024 02:42:36 +0200 [thread overview]
Message-ID: <a289cd79-4d48-4ae7-b45d-8b8da756e373@gmail.com> (raw)
In-Reply-To: <324c34e3-3471-4cbe-aa6d-b14244ca48eb@gmail.com>
On 8/26/24 00:43, Alien Wesley wrote:
> Sorry folks, this was supposed to be a v2.
> [PATCH v2] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529
>> Separated assignments for pairwise_key_type and group_key_type
>> in order to silence the following checkpatch warning.
>>
>> CHECK: multiple assignments should be avoided.
>>
>> ---
>> Changes in v2:
>> - Removed two spaces in front of "=".
>>
>> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
>> ---
>> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
>> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
>> index 47f1adf30ab4..67c4793e0fc1 100644
>> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
>> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
>> @@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
>> mutex_unlock(&priv->wx_mutex);
>> if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
>> - ieee->pairwise_key_type = KEY_TYPE_NA;
>> + ieee->pairwise_key_type = KEY_TYPE_NA;
>> ieee->group_key_type = KEY_TYPE_NA;
>> rtl92e_cam_reset(dev);
>> memset(priv->rtllib->swcamtable, 0,
>
>
Hi Alien,
please make a v3 with correct subject.
Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks for your support.
Bye Philipp
next prev parent reply other threads:[~2024-08-26 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 21:46 [PATCH] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529 Alien Wesley
2024-08-25 22:43 ` Alien Wesley
2024-08-26 0:42 ` Philipp Hortmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-25 15:45 Alien Wesley
2024-08-25 17:35 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a289cd79-4d48-4ae7-b45d-8b8da756e373@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=alienwesley51@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox