* [PATCH] staging: wimax: i2400m: add space before open parenthesis
@ 2021-02-20 10:48 Rajesh Kumbhakar
2021-02-20 11:12 ` Greg KH
2021-02-20 13:46 ` [PATCH v2] " Rajesh Kumbhakar
0 siblings, 2 replies; 8+ messages in thread
From: Rajesh Kumbhakar @ 2021-02-20 10:48 UTC (permalink / raw)
To: gregkh, sfr; +Cc: devel, linux-kernel, Rajesh Kumbhakar
netdev.c
fixing style ERROR: space required before the open parenthesis '('
Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
---
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff *skb,
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
i2400m, skb, skb->len, cs);
- switch(cs) {
+ switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 10:48 [PATCH] staging: wimax: i2400m: add space before open parenthesis Rajesh Kumbhakar
@ 2021-02-20 11:12 ` Greg KH
2021-02-20 12:28 ` RajMAIN
2021-02-20 13:46 ` [PATCH v2] " Rajesh Kumbhakar
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-02-20 11:12 UTC (permalink / raw)
To: Rajesh Kumbhakar; +Cc: sfr, devel, linux-kernel
On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote:
> netdev.c
Why is this here?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 11:12 ` Greg KH
@ 2021-02-20 12:28 ` RajMAIN
2021-02-20 12:42 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: RajMAIN @ 2021-02-20 12:28 UTC (permalink / raw)
To: Greg KH; +Cc: sfr, devel, linux-kernel
On 20-02-2021 16:42, Greg KH wrote:
> On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote:
>> netdev.c
> Why is this here?
You mean that filename? I thought I should mention it. Should I remove
it and resubmit?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 12:28 ` RajMAIN
@ 2021-02-20 12:42 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-02-20 12:42 UTC (permalink / raw)
To: RajMAIN; +Cc: devel, sfr, linux-kernel
On Sat, Feb 20, 2021 at 05:58:35PM +0530, RajMAIN wrote:
>
> On 20-02-2021 16:42, Greg KH wrote:
> > On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote:
> > > netdev.c
> > Why is this here?
>
> You mean that filename? I thought I should mention it. Should I remove it
> and resubmit?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is needed in order
to properly describe the change.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 10:48 [PATCH] staging: wimax: i2400m: add space before open parenthesis Rajesh Kumbhakar
2021-02-20 11:12 ` Greg KH
@ 2021-02-20 13:46 ` Rajesh Kumbhakar
2021-02-21 13:06 ` Greg KH
2021-02-21 13:39 ` [PATCH v3] " Rajesh Kumbhakar
1 sibling, 2 replies; 8+ messages in thread
From: Rajesh Kumbhakar @ 2021-02-20 13:46 UTC (permalink / raw)
To: gregkh, sfr; +Cc: devel, linux-kernel, Rajesh Kumbhakar
netdev.c
fixing style ERROR: space required before the open parenthesis '('
Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
---
Changes in v2:
- Removed filename from commit message.
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff *skb,
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
i2400m, skb, skb->len, cs);
- switch(cs) {
+ switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 13:46 ` [PATCH v2] " Rajesh Kumbhakar
@ 2021-02-21 13:06 ` Greg KH
2021-02-21 13:23 ` Rajesh Kumbhakar
2021-02-21 13:39 ` [PATCH v3] " Rajesh Kumbhakar
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-02-21 13:06 UTC (permalink / raw)
To: Rajesh Kumbhakar; +Cc: sfr, devel, linux-kernel
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:
> netdev.c
>
> fixing style ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
> ---
> Changes in v2:
> - Removed filename from commit message.
filename is still in commit message :(
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis
2021-02-21 13:06 ` Greg KH
@ 2021-02-21 13:23 ` Rajesh Kumbhakar
0 siblings, 0 replies; 8+ messages in thread
From: Rajesh Kumbhakar @ 2021-02-21 13:23 UTC (permalink / raw)
To: Greg KH; +Cc: sfr, devel, linux-kernel
On 21-02-2021 18:36, Greg KH wrote:
> On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:
>> netdev.c
>>
>> fixing style ERROR: space required before the open parenthesis '('
>>
>> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
>> ---
>> Changes in v2:
>> - Removed filename from commit message.
> filename is still in commit message :(
aah, not again. please bare with me this last time, will surely never
repeat this.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] staging: wimax: i2400m: add space before open parenthesis
2021-02-20 13:46 ` [PATCH v2] " Rajesh Kumbhakar
2021-02-21 13:06 ` Greg KH
@ 2021-02-21 13:39 ` Rajesh Kumbhakar
1 sibling, 0 replies; 8+ messages in thread
From: Rajesh Kumbhakar @ 2021-02-21 13:39 UTC (permalink / raw)
To: gregkh, lee.jones, kuba, johannes, memxor, arnd
Cc: devel, linux-kernel, Rajesh Kumbhakar
fixing ERROR: space required before the open parenthesis '('
Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
---
Changes in v3:
- Fixed commit message (removed filename).
Changes in v2:
- Removed filename from commit message.
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff *skb,
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
i2400m, skb, skb->len, cs);
- switch(cs) {
+ switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-21 13:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-20 10:48 [PATCH] staging: wimax: i2400m: add space before open parenthesis Rajesh Kumbhakar
2021-02-20 11:12 ` Greg KH
2021-02-20 12:28 ` RajMAIN
2021-02-20 12:42 ` Greg KH
2021-02-20 13:46 ` [PATCH v2] " Rajesh Kumbhakar
2021-02-21 13:06 ` Greg KH
2021-02-21 13:23 ` Rajesh Kumbhakar
2021-02-21 13:39 ` [PATCH v3] " Rajesh Kumbhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox