From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE67E1FDE08; Thu, 6 Feb 2025 09:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738835450; cv=none; b=V2AmiO2h1yQ9/UfM0lo7+uJjr3SWSxhZiA4knc2yF4quTEccjydXw99ERl8qON6E6hqWkepxe3N5qAGuMieXknSGEntEM4CuDhT9ApEXWHbQ/0Cb364makuCXsPLp8db8XlIS0XZsRYkTWoj1PJ75JDsuy1EH8g7DVfRFbIb6Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738835450; c=relaxed/simple; bh=itpKQpCOiq01Bdaito4FooOWsxu62KH60EMfJ0aSCaw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Tbb/SbUcIzJnIoPXPVkt+BJCTY8yHfMFqfT4ihMcDVXBmCnysRV8s14Kj/p3SVJV0CmamipDGU3J93ro9VRuKXVgeHN+yAOyP+6zA9DnviaO6NlPimo8tZobi4DWrRnXs3/8FwijzpfbjOjcPNcIbSscdekOs0q17xaLjzjWmM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=X0UJRU2P; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="X0UJRU2P" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ziKVTMMA/mlYZVJuZda3dTpHoy6EjxMZx7k7VgkUGGc=; t=1738835448; x=1740045048; b=X0UJRU2P5ks7EWOL5sQBl5twzbihPL3A+F+Z1tA8cdHeTi7 lvvOmeFHVoUHEnCRSsAWYdOZ0tDtKd2KAueWWoUurWhdUOPUiuj7Og5pyaqKkvq7H+rpc4MubFWjD vfbtim9R2HVs9XJWJlDOHYO2MdpqKmldDwtO4cwBLoeypIBslHYQEy62zUuV8UJIFiADlDEZMV3pu FsG+eXm1rhHMH3BOf3H6+t8XHNd/8SxodeM9fY5k4Q01dB7BZIMhRyUooZ5kasOKxyOuCrecnfQLG UXnpNOSFF3oweMo0hIa+/gFI2YFv45mvXzEZrvci3ed3wKmZSXhhCUO/iW+ot8iQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tfyWr-00000004y1Y-1HxM; Thu, 06 Feb 2025 10:50:37 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] net, treewide: define and use MAC_ADDR_STR_LEN From: Johannes Berg To: Michal Swiatkowski , Uday Shankar Cc: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Simon Horman , Andrew Morton , Jonathan Corbet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-doc@vger.kernel.org Date: Thu, 06 Feb 2025 10:50:36 +0100 In-Reply-To: References: <20250205-netconsole-v3-0-132a31f17199@purestorage.com> <20250205-netconsole-v3-1-132a31f17199@purestorage.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2025-02-06 at 10:44 +0100, Michal Swiatkowski wrote: >=20 > > net/mac80211/debugfs_sta.c | 5 +++-- >=20 > What about ieee80211_sta_debugfs_add()? (net/mac80211/debugfs_sta.c) What about it? It's modified accordingly, just needs a bit more +/-1 now. For that: Acked-by: Johannes Berg Thanks for the rename, per the robot report that just came in it looks like that also saved you from some hassle in drivers that have their own MAC_ADDR_LEN for some reason :) johannes