From: Dave Hansen <dave.hansen@intel.com>
To: Thorsten Blum <thorsten.blum@linux.dev>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] x86/boot: validate earlyprintk= baud rate
Date: Wed, 13 May 2026 10:05:30 -0700 [thread overview]
Message-ID: <a2ab80f3-2887-499c-951b-1b587ea58b2b@intel.com> (raw)
In-Reply-To: <20260513164844.449910-4-thorsten.blum@linux.dev>
> Values greater than BASE_BAUD would produce divisor 0, and
> baud 1 would produce divisor BASE_BAUD, which exceeds 16 bits.
My inclination would be to leave this code as simple as possible. If
users screw up a baud rate, they'll get no output and have to go fix it.
Why does this need to be robust against bad user input?
prev parent reply other threads:[~2026-05-13 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:48 [PATCH RESEND 1/2] x86/boot: validate earlyprintk= baud rate Thorsten Blum
2026-05-13 16:48 ` [PATCH RESEND 2/2] x86/boot: use BASE_BAUD and DEFAULT_SERIAL_PORT Thorsten Blum
2026-05-13 17:05 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ab80f3-2887-499c-951b-1b587ea58b2b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox