From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>
Subject: Re: [PATCH 1/2] x86/tsc: Avoid a double call if TSC initializes earlier.
Date: Mon, 30 Jul 2018 17:53:44 +0800 [thread overview]
Message-ID: <a2d372a3-a7cc-34ae-679d-cf71d243ee04@cn.fujitsu.com> (raw)
In-Reply-To: <20180730093447.GF2494@hirez.programming.kicks-ass.net>
Hi Peter,
At 07/30/2018 05:34 PM, Peter Zijlstra wrote:
> On Mon, Jul 30, 2018 at 03:54:20PM +0800, Dou Liyang wrote:
>> static_branch_enable(&__use_tsc) may be called twice in common case, that
>> is redundant.
>
> It is also really not a problem...
>
Yes, right. Just avoid the second useless setting.
Thanks,
dou
>
>
next prev parent reply other threads:[~2018-07-30 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:54 [PATCH 0/2] Two cleanup patches Dou Liyang
2018-07-30 7:54 ` [PATCH 1/2] x86/tsc: Avoid a double call if TSC initializes earlier Dou Liyang
2018-07-30 9:34 ` Peter Zijlstra
2018-07-30 9:53 ` Dou Liyang [this message]
2018-07-30 14:09 ` Pavel Tatashin
2018-07-30 17:37 ` [tip:x86/timers] x86/tsc: Consolidate init code tip-bot for Dou Liyang
2018-07-30 7:54 ` [PATCH 2/2] x86/kvmclock: Mark kvm_get_preset_lpj() as __init Dou Liyang
2018-07-30 14:17 ` Pavel Tatashin
2018-07-30 17:38 ` [tip:x86/timers] " tip-bot for Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d372a3-a7cc-34ae-679d-cf71d243ee04@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox