The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Charlie Jenkins <thecharlesjenkins@gmail.com>,
	 Nam Cao <namcao@linutronix.de>
Cc: Xiaofeng Yuan <xiaofengmian@163.com>,
	Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] riscv: probes: simulate c.jal instruction
Date: Fri, 10 Jul 2026 12:39:52 -0600 (MDT)	[thread overview]
Message-ID: <a30fa1d8-ad41-7d69-abe5-b52baef30dbf@kernel.org> (raw)
In-Reply-To: <178358158037.977550.10342416507496007508.b4-review@b4>

Hi Nam, Charlie,

On Thu, 9 Jul 2026, Charlie Jenkins wrote:

> Reviewed-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
> Tested-by: Charlie Jenkins <thecharlesjenkins@gmail.com>

Thank you both for posting Reviewed-by:s and Tested-by:s for these 
patches.  One request: at the end of your Tested-by:s, it's very helpful 
for myself and others if we know what platform they were tested on, and 
whether the testing was simply boot testing, or whether the tests were 
direct functional tests of the code being patched.  So for example, 
something along the lines of the following would be really great:

Tested-by: J. Kernel Developer <email@address> # QEMU; kprobes

or 
 
Tested-by: J. Kernel Developer <email@address> # Litex VexRISCV; boot


Thanks again for reviewing and testing!

- Paul

  reply	other threads:[~2026-07-10 18:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  8:10 [PATCH v6 0/2] riscv: add c.jal instruction simulation for kprobes Xiaofeng Yuan
2026-07-01  8:10 ` [PATCH v6 1/2] riscv: probes: simulate c.jal instruction Xiaofeng Yuan
2026-07-02  9:49   ` Nam Cao
2026-07-09  7:19   ` Charlie Jenkins
2026-07-10 18:39     ` Paul Walmsley [this message]
2026-07-01  8:10 ` [PATCH v6 2/2] riscv: kprobes: add test case for c.jal instruction simulation Xiaofeng Yuan
2026-07-09  7:19   ` Charlie Jenkins
2026-07-10 18:35 ` [PATCH v6 0/2] riscv: add c.jal instruction simulation for kprobes Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30fa1d8-ad41-7d69-abe5-b52baef30dbf@kernel.org \
    --to=pjw@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=namcao@linutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=thecharlesjenkins@gmail.com \
    --cc=xiaofengmian@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox