From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752119AbdLBAC2 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Dec 2017 19:02:28 -0500
Received: from mga09.intel.com ([134.134.136.24]:29085 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751847AbdLBAC1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Dec 2017 19:02:27 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,347,1508828400"; 
   d="scan'208";a="1250908705"
Subject: Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops
 and IO transfer support
To: Vinod Koul <vinod.koul@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
        Takashi <tiwai@suse.de>, patches.audio@intel.com, alan@linux.intel.com,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, srinivas.kandagatla@linaro.org,
        plai@codeaurora.org, Sudheer Papothi <spapothi@codeaurora.org>
References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com>
 <1512122177-2889-13-git-send-email-vinod.koul@intel.com>
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <a3167578-df2b-e871-cd5e-94adcc549a4e@linux.intel.com>
Date: Fri, 1 Dec 2017 18:02:24 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1512122177-2889-13-git-send-email-vinod.koul@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>   struct sdw_cdns {
>   	struct device *dev;
>   	struct sdw_bus bus;
>   	unsigned int instance;
>   
> +	u32 response_buf[0x80];

last nit-pick: use a #define for the size.
Also are you sure about the value? I vaguely recall that the FIFO was 
32-deep, you are confusing bytes and words here?

> +	struct completion tx_complete;
> +	struct sdw_defer *defer;
> +
>   	void __iomem *registers;
>   
>   	bool link_up;
> +	unsigned int msg_count;
>   };
>