From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8070249EB for ; Wed, 15 Jul 2026 00:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074262; cv=none; b=i6zH1M0tY+UylPZR8h3o7NpkmcxyekaDEqcwoIdhwVZ8pjRoAusSf05CRyNDJm9RKCKgLdfcEaS0FVfPBfxDPaAIDuYMBM5cTfRHtdAEqnMG+UatrWkON9k7xRbByVEnj+0Rdlulbm1XeBWWlIdq7PIkQJAtAN2xRxCcsV0JF4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074262; c=relaxed/simple; bh=jyuIb9mUMhDLcJdZztNW/kggE4C4qT3I1JbKcllNvbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=af5oRmambTQX2uRFEEg/sljEN+d1fjtHFUSZCripTV95oIM4x4GUe/uuIe09f/ygYxlMSiB/Uzoj9arcdEd+lZqgkLPAxC2+kN7fR4oO2qpxZXwCTOak9zSXW/hYL/pRdyVcyHMXnx9OI4UcPNQhlNqqMVrxl2tnwzLjAdSAI5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FcX++nky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RHBVfvjV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FcX++nky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RHBVfvjV" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EIx2Ql1244355 for ; Wed, 15 Jul 2026 00:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=FcX++nky+6nttwcS 1fmRDRruTiF9tAVKFfDzbeFXAL6ULDCdWlA5wiKPP5AuweEW7F6qGxUPPzHZINbl YDpUR64KjcCPF+tPkj4hM+vYKWvIo+miKIKTWkFwV5B2i1W0+sd552SchGt4nH+C bWZJRym20fmj1y/h9HVagYJ9Bg9pVx132noahPceJ/m7UvJLVExO8vDwNyMzugR1 qtfCjOGkX69er+84c5t3xebI4urvLrE83/lI0aCJpZZuu8XgkOHvI8joammuOmZR bs0oDoayBBdFMwZTwiSNISeh8/BtLCFabEgHw74Wvj7AXayv3DBO6IEU3FXzNeUm wgxkrA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdmkk2kd8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 00:11:00 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ccb6f6a3f4so24072355ad.1 for ; Tue, 14 Jul 2026 17:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784074259; x=1784679059; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=RHBVfvjVObL+oKPfxPhy5rIgsC1I6Sp12vIi4/cqRWiH7V7J2qfN4StyAT7/k6nAAx 0Zy9sEFtlr+BD7iVmo9s1fxo3yCp93vq7E13w9DJ5Mo80Xluf85KCD3Cyh1KsWhqOl5c R/0bdJQDOKeDLpqTmWwSEWfe0UiIdArluzk90JyUTTL4c3OvLnG6puk1lFGdBoeQE7et UpPw6eSGdR+OB+gm1m0oviBpI2G7Nik3yjOIyeftm4udo6EqJc/79g0pl1f7/i8mjg9K Re7K2Wh1wo/xVAtuEp7nwS4i/jZeQJ33ZcFBnAKsrXuBBAruvKnm6thiD1rbPxdgcUFE 9zbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784074259; x=1784679059; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=hq0NkxhSLHIloDLeT1Ni72gJ5CSi7fsJy/tI/lRvux3AhJcENV/evHRieXGLJ8iN5c jxrCLQG/4vrlHYT9nrmimu4+Zge0Sphl/tT9vSZrS6iM5IR58ZoQRDJWQGZQFt4Kv5l0 +of6T2+4Mi5E3zcQwwScoMDdFZtzSYL+/kyPE+8lce/bUQylZXoddAkgOKjPBxh2xPS/ ss34QYEWMgNj55+jC0gHoHlb3nT265nqcJtNH2wkrJ9nNY3T1lyXuyPurl+nrrmNAYjx jTWQ7x9vDfRR879mdPcH1XD4Cybg/HpubRlCwWDFQnxgkd6U+MnEYSxi7yFhM5ZH3512 7xeQ== X-Forwarded-Encrypted: i=1; AHgh+Rq79BMXaj2nJC/C+WLRA8/cPifxfRR7CTThYhxhMuETCJu7SlmnNzyK37bIVIDyqXFiNiKWTMycmNVD5R4=@vger.kernel.org X-Gm-Message-State: AOJu0YzHfcKFIBNd8tOgKJxfSoYiJuH6vKa8CmXJmWNgiKbB+/+xXl0M EWqGRVDtTIqFnsx4oul8p8J3ip4viBbOpJINH385tvxAlpdksX7uJrN4U3bmBpeWzlHdijK9tz7 ldwTQU9HSxQBDR3xJxhTo3Mx3IXl+xOWLdBsKDx3RIWq8LIWetYrDit9E21IDLgfqweU= X-Gm-Gg: AfdE7cmFyx+uLxHw36I7mUBIvLSSOeYvya3R+9iQ7EMeSLQuYJxfSU3lhRG+lxSitAZ sUzsoq1UhYKJzFPAi8HnwqCd8lJdU6xLcmV1CUYsvTWm+mTAj+BHVpp4pDFoHGpqBDO2u8scu92 jlLK0zpey2nJ4B0rnT2SFZ91TeF4zeq79FUdYBFzly4bnie7a2bbuCXfCYUdOtk7NYKUegsmp9q PZhCuhPT5lEi4tTX4s7RKCdVn3XoOmU5usS6i14Om+9FlVoWiOO5M/4QbF6MKDLfdgYs6Jod08S 19FZWCOHphIj5ZpWeywT5Y14HfudeGpHJVsHAlDKPRw5MmbGuznoXbr6ZYCAayLwVBrJ/z0yhCA Pzg8puzfLUf+X2wsfam35CklPCKAymVC+ESQfnIq4 X-Received: by 2002:a17:903:2406:b0:2c7:c385:c5a7 with SMTP id d9443c01a7336-2ce8297869amr179293275ad.26.1784074259340; Tue, 14 Jul 2026 17:10:59 -0700 (PDT) X-Received: by 2002:a17:903:2406:b0:2c7:c385:c5a7 with SMTP id d9443c01a7336-2ce8297869amr179293065ad.26.1784074258759; Tue, 14 Jul 2026 17:10:58 -0700 (PDT) Received: from [10.239.133.197] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d59e40sm124537915ad.75.2026.07.14.17.10.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 17:10:58 -0700 (PDT) Message-ID: Date: Wed, 15 Jul 2026 08:10:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cpufreq: spear: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate() To: Dan Carpenter , Deepak Sikri Cc: "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: HlNnGdvwA15ASigWQ3iuVgctz2F1-apP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDI0OSBTYWx0ZWRfX5kx1EWHurKa/ 4JIcx5Cak86R+QsJspVy7S9NrceQl7cBF2S3UtzMuFGpS79fZHvf8SL5ZD7/M8tAxTXQb/x6lcp W40k0O+XLY7XjB+D9O0eW/VUvs++mSuh/ToTSaDOedPEJyNi4r8EekUYazkZOsGWhcTPow9dHiF yPgEXLJyoFOea17qJitYoOZIgHMKH/0GJKYh4v01Cy4/OS4FbcEIY2YYoWtoHfAYDSkNiMeNKc6 27ij3JSIQ6nP3bOl3PJPfR49YvLK7laJPpf6wUuUbde8ewKOEGpibHhB5tQTMARUHT432kkmSxk RMJqO/qOzITAwv/46+hKtP8gGZLmxh9Cv4GFEfKYNl6lmfz8lf5QVyfiICIzlCNyhBkuRZ7Nk+u xcO8M/d06kA5/SNTYMbvBIApWH1ikxMPXd6nfZzIRF74oZfWmGZoTmrDKeyEvFxWfhcS4Kb3L/T tJscnW3ruMly4p8q5jQ== X-Authority-Analysis: v=2.4 cv=NszhtcdJ c=1 sm=1 tr=0 ts=6a56d014 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=N0crexS4lfU0QNQj-gkA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: HlNnGdvwA15ASigWQ3iuVgctz2F1-apP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDI0OSBTYWx0ZWRfXzgs/KqXdvjYl gpbj/4OeFVB+P3vzaPx9UPqegaszqzebmSIZ/bOrF4P68iIsG6f3HdUCvvPunB5sndHXYBN7BCF 6i3MCSAqOtaxJWO1HC3zPjUk91n94Gs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_05,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140249 On 7/14/2026 11:46 PM, Dan Carpenter wrote: > The clk_get_parent() function doesn't return error pointers, it returns > NULL on error. Update the error checking to match. > > Fixes: 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver") > Signed-off-by: Dan Carpenter > --- > v2: fix subsystem prefix in subject Reviewed-by: Zhongqiu Han > > drivers/cpufreq/spear-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 81a0780b2ebf..ffe5eda82f0b 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -79,9 +79,9 @@ static int spear1340_set_cpu_rate(struct clk *sys_pclk, unsigned long newfreq) > int ret = 0; > > sys_clk = clk_get_parent(spear_cpufreq.clk); > - if (IS_ERR(sys_clk)) { > + if (!sys_clk) { > pr_err("failed to get cpu's parent (sys) clock\n"); > - return PTR_ERR(sys_clk); > + return -EINVAL; > } > > /* Set the rate of the source clock before changing the parent */ -- Thx and BRs, Zhongqiu Han