From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com,
Valentin.Schneider@arm.com,
Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Matteo Carlini <Matteo.Carlini@arm.com>
Subject: Re: [PATCH ARM64]: Introduce CONFIG_MAXSMP to allow up to 512 cpus
Date: Mon, 27 Nov 2023 11:58:22 -0800 (PST) [thread overview]
Message-ID: <a32a30d9-f352-cecd-c6f9-16b25963fac1@linux.com> (raw)
In-Reply-To: <ZV-o9ORrq7OKWOry@arm.com>
On Thu, 23 Nov 2023, Catalin Marinas wrote:
>> +config NR_CPUS_RANGE_BEGIN
>> + int
>> + default NR_CPUS_RANGE_END if MAXSMP
>> + default 1 if !SMP
>> + default 2
>
> We don't support !SMP on arm64.
Ok we can drop that.
>> + This is purely to save memory: each supported CPU adds about 8KB
>> + to the kernel image.
>
> Is this all needed just to select CPUMASK_OFFSTACK if larger NR_CPUS?
> Would something like this do:
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7b071a00425d..697d5700bad1 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -119,6 +119,7 @@ config ARM64
> select CLONE_BACKWARDS
> select COMMON_CLK
> select CPU_PM if (SUSPEND || CPU_IDLE)
> + select CPUMASK_OFFSTACK if NR_CPUS > 512
> select CRC32
> select DCACHE_WORD_ACCESS
> select DYNAMIC_FTRACE if FUNCTION_TRACER
>
> togehther with a larger NR_CPUS in defconfig?
Well that is certainly better because it does not introduce an additional
kernel config option.
next prev parent reply other threads:[~2023-11-27 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 1:04 [PATCH ARM64]: Introduce CONFIG_MAXSMP to allow up to 512 cpus Christoph Lameter (Ampere)
2023-11-23 19:33 ` Catalin Marinas
2023-11-27 19:58 ` Christoph Lameter (Ampere) [this message]
2023-11-28 6:40 ` Anshuman Khandual
2023-11-28 18:02 ` Christoph Lameter (Ampere)
2023-12-04 18:49 ` [PATCH] ARM64: Dynamicaly allocate cpumasks and increase supported CPUs to 512 (was: CONFIG_MAXSMP to allow up to 512 cpus) Christoph Lameter (Ampere)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a32a30d9-f352-cecd-c6f9-16b25963fac1@linux.com \
--to=cl@linux.com \
--cc=Anshuman.Khandual@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Matteo.Carlini@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dave.kleikamp@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vanshikonda@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox