From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B90245010 for ; Tue, 15 Jul 2025 15:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752593230; cv=none; b=laqlxSPM5NMznpFG3FwaIiUWRwIfc1PjPeMFp4D2Fl7VJF4CJgDpDFRqfIxOXtWOhzoX83rMOredP3nPFr7Km67dAIlkMn3dTxuAmwfCvlXXPeQUhet6r2Jhqs2TUsZYImJIeacNgVpA1nSYAw57/dRJKC7EPO0SPMb7oTrUcDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752593230; c=relaxed/simple; bh=AjA8lwVX2aCPhNAKXH4DmME3PdKKjhtmhXiSvdXvquE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sGYzhmZMrBruCiCxntHryv3Z3nz2GRL0IKRRMSJ+tSuKur3NECds42VZrMrmB85uOPUHWiWdBJebgh3T9fbB4t8RHt8OxMrmwfjsChtG6B+p/JdCY127SNZ2qsDE53nnzuLJ49lnBG3XghK5sFxqD/feM1YbRKdVUZKLIBpRwLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lr0e4ZA+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lr0e4ZA+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752593228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4xLowFzrxXoeSPcmnmzzy3XsWlNaO4fQFtqJRByiUOs=; b=Lr0e4ZA+K3/H9J8rE/1WjMCHwIQtBSefPlSReDlEOnT+O1jcVnpn9wgrHNEvSwQ0VJiiBF qOr302UUMHhqMLxrwOV3MBAKJquYTwdUQx2A0t/5P4EHUMy+HuwtBvytCDyxd6FuVaK91J /cy/jOW1GYaPO5Adq7LwXx5VgsGb6AQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-R0-0FBh5PnugcGXdVjkCJQ-1; Tue, 15 Jul 2025 11:27:06 -0400 X-MC-Unique: R0-0FBh5PnugcGXdVjkCJQ-1 X-Mimecast-MFC-AGG-ID: R0-0FBh5PnugcGXdVjkCJQ_1752593226 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4fabcafecso2755351f8f.0 for ; Tue, 15 Jul 2025 08:27:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752593225; x=1753198025; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4xLowFzrxXoeSPcmnmzzy3XsWlNaO4fQFtqJRByiUOs=; b=J1f/YM8ReQfgqOqQG5qfT+vqiZ/r+HVlNipF/y6vYVYaRbJltODG+CxAuRrvVCinY6 aN8QBRnmSAaWoEjYuDdRs7z+4gdH7hhR+Wu+F+giqxa2ae8oprVlLscsy/EEIK5bXU+Z lH2Z6HuvLtcS+C9Ngn86A7vCtcfU6aAfu6bydmnVZTrZoVUqHa7Yk3CURRGEKSrJJ4N+ JWfkEe/h+wwnyOmCvn8McOWyLurwd4DA9E01l3ZW82wAJ4do7EaZhlKUn4TuUDrli7OS U8twVbeFF9QQRE+DMBxW7mesIz2aIT3OmNHguNg/ajdTB0hor7CnfWj3K8H78BSCz75/ 0B3A== X-Forwarded-Encrypted: i=1; AJvYcCUR4ONFZ3j+8SpiFF+FVvuIeFRmsI6A4kigFFBC+HOzw/flINaX1Ir7kOoDVM6m4eufzVRil7yz3nOuIvo=@vger.kernel.org X-Gm-Message-State: AOJu0YwYt0Wmbzy0WsCJ8DR/Qv9ONfkQxsdL8vta6tbu2v5taueT1iwl DJ1kVlCADdQAKTt9KRkOul9TJoXcL5GnRHBlgR/nWEVyBtSKCz/Rp3vebsK51PT372Zt/Fh0xwZ or93je7PkMH18+M0oIsDH/XnVH7NiYWGbxA7fLO01VyiWfZOo3/reK0wXe92LTYfplw== X-Gm-Gg: ASbGnculNypbJo1wqxNJa5FLQoxDHaPn6KHH2KIicIFVNKEPAXVnfKUnU30yEqcFWYu NEsnaO7/xX3rV4nmkLVbnvLLYr3J88EXV2mXOiYZwtQXbsR4nWhVgkGNyiePwIK5o/XZt1gWQag FdSlgXESec1Go5eSqj3gTMObLnOPYfKRcucdw6RqwHFdBSXDPQE4ycKIxkkQvAO3fj1fySZzT9E V7wMNBRb3QvCj45O5ndqIkyN7Ik8tvfY1dMUnU6DenYkXLucnvUsF3nqvC7MJXBXMSH69PfnfU+ uhIIPH831A/N/jxoUvfpYmO5se+4DKij55z1dCV3/7RZ+y5sB8QKkQhlv9iZaYn6S7cyfAGLE1L fL0J/ZefSdDUknXEl2vUG7xr3Wm3VDSXzdEfXRzVqWXkQ88yw8kYVyNrU7UJJCYYUaps= X-Received: by 2002:a05:6000:2dc9:b0:3b5:e6bf:5e0c with SMTP id ffacd0b85a97d-3b5f35783b6mr13134600f8f.31.1752593225345; Tue, 15 Jul 2025 08:27:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExi1j3X34LWijmZqGxFKMW/7Ro9qGKbZaBrDfu2Bv2+AMOygCRmfqoHXyTXT3YBDGfY/fQZg== X-Received: by 2002:a05:6000:2dc9:b0:3b5:e6bf:5e0c with SMTP id ffacd0b85a97d-3b5f35783b6mr13134570f8f.31.1752593224856; Tue, 15 Jul 2025 08:27:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4900:2c24:4e20:1f21:9fbd? (p200300d82f2849002c244e201f219fbd.dip0.t-ipconnect.de. [2003:d8:2f28:4900:2c24:4e20:1f21:9fbd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc91e3sm15253625f8f.43.2025.07.15.08.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 08:27:04 -0700 (PDT) Message-ID: Date: Tue, 15 Jul 2025 17:27:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] add static PMD zero page support To: "Pankaj Raghav (Samsung)" Cc: Lorenzo Stoakes , Zi Yan , Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Mike Rapoport , Dave Hansen , Michal Hocko , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250707142319.319642-1-kernel@pankajraghav.com> From: David Hildenbrand Content-Language: en-US Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.07.25 17:25, Pankaj Raghav (Samsung) wrote: > On Tue, Jul 15, 2025 at 04:16:44PM +0200, David Hildenbrand wrote: >> On 15.07.25 16:12, Lorenzo Stoakes wrote: >>> On Tue, Jul 15, 2025 at 04:06:29PM +0200, David Hildenbrand wrote: >>>> I think at some point we discussed "when does the PMD-sized zeropage make >>>> *any* sense on these weird arch configs" (512MiB on arm64 64bit) >>>> >>>> No idea who wants to waste half a gig on that at runtime either. >>> >>> Yeah this is a problem we _really_ need to solve. But obviously somewhat out of >>> scope here. >>> >>>> >>>> But yeah, we should let the arch code opt in whether it wants it or not (in >>>> particular, maybe only on arm64 with CONFIG_PAGE_SIZE_4K) >>> >>> I don't think this should be an ARCH_HAS_xxx. >>> >>> Because that's saying 'this architecture has X', this isn't architecture >>> scope. >>> >>> I suppose PMDs may vary in terms of how huge they are regardless of page >>> table size actually. >>> >>> So maybe the best solution is a semantic one - just rename this to >>> ARCH_WANT_STATIC_PMD_ZERO_PAGE >>> >>> And then put the page size selector in the arch code. >>> >>> For example in arm64 we have: >>> >>> select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >>> >>> So doing something similar here like: >>> >>> select ARCH_WANT_STATIC_PMD_ZERO_PAGE if ARM64_4K_PAGES >>> >>> Would do thie job and sort everything out. >> >> Yes. > > Actually I had something similar in one of my earlier versions[1] where we > can opt in from arch specific Kconfig with *WANT* instead *HAS*. > > For starters, I will enable this only from x86. We can probably extend > this once we get the base patches up. Makes sense. -- Cheers, David / dhildenb