From: Ulrich Drepper <drepper@gmail.com>
To: "Gaston, Jason D" <jason.d.gaston@intel.com>
Cc: Jeff Garzik <jgarzik@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SATA support for Intel ICH7 - 2.6.10
Date: Wed, 29 Dec 2004 17:19:16 -0800 [thread overview]
Message-ID: <a36005b50412291719257882b6@mail.gmail.com> (raw)
In-Reply-To: <26CEE2C804D7BE47BC4686CDE863D0F502AE9F2B@orsmsx410>
On Wed, 29 Dec 2004 16:13:41 -0800, Gaston, Jason D
<jason.d.gaston@intel.com> wrote:
> } else {
> - WARN_ON(ich != 6);
> + WARN_ON((ich != 6) || (ich != 7));
This cannot be right. Every number is either != 6 or != 7. You want &&.
next prev parent reply other threads:[~2004-12-30 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 0:13 [PATCH] SATA support for Intel ICH7 - 2.6.10 Gaston, Jason D
2004-12-30 1:19 ` Ulrich Drepper [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-30 2:11 Gaston, Jason D
2004-12-30 4:57 ` Sami Farin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36005b50412291719257882b6@mail.gmail.com \
--to=drepper@gmail.com \
--cc=jason.d.gaston@intel.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox