From: "Ulrich Drepper" <drepper@gmail.com>
To: "Christoph Hellwig" <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uselib: add missing MNT_NOEXEC check
Date: Thu, 17 May 2007 09:14:06 -0700 [thread overview]
Message-ID: <a36005b50705170914i17bd853bj638f5098c4e7d788@mail.gmail.com> (raw)
In-Reply-To: <20070517135526.GA28213@lst.de>
On 5/17/07, Christoph Hellwig <hch@lst.de> wrote:
> We don't allow loading ELF shared library from noexec points so the
> same should apply to sys_uselib aswell.
Correct. But...
> error = -EINVAL;
> + if (nd.mnt->mnt_flags & MNT_NOEXEC)
> + goto exit;
... the error here should be EACCES. Aside from that you get an ACK from me.
next prev parent reply other threads:[~2007-05-17 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 13:55 [PATCH] uselib: add missing MNT_NOEXEC check Christoph Hellwig
2007-05-17 16:14 ` Ulrich Drepper [this message]
2007-05-17 18:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36005b50705170914i17bd853bj638f5098c4e7d788@mail.gmail.com \
--to=drepper@gmail.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox