From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752534AbcJCNjk (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 09:39:40 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:49364 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751465AbcJCNj3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 09:39:29 -0400
DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org CD5B761787
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org
Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for
 OF
To: Vinod Koul <vinod.koul@intel.com>
References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org>
 <1475115167-5898-5-git-send-email-okaya@codeaurora.org>
 <20161001061710.GF2467@localhost>
 <da6536a3-353e-1364-7074-9d3dcbcc4171@codeaurora.org>
 <20161003033851.GP2467@localhost>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
        devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com,
        agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Dan Williams <dan.j.williams@intel.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-kernel@vger.kernel.org
From: Sinan Kaya <okaya@codeaurora.org>
Message-ID: <a36242e2-99a4-b519-094e-b6d2bcdd27da@codeaurora.org>
Date: Mon, 3 Oct 2016 09:39:25 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20161003033851.GP2467@localhost>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/2/2016 11:38 PM, Vinod Koul wrote:
>> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
>> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
>> > side effects on my testing either.
> yeah later on I did look up the of_msi_configure() and I suspected this. I
> think it would be worthwhile to document this assumption here.

Sure, let me do that.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.