From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAED1C5519F for ; Wed, 25 Nov 2020 13:33:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8337C206F9 for ; Wed, 25 Nov 2020 13:33:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QT9LtFym" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729104AbgKYNdZ (ORCPT ); Wed, 25 Nov 2020 08:33:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:55878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgKYNdZ (ORCPT ); Wed, 25 Nov 2020 08:33:25 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5497C206E5; Wed, 25 Nov 2020 13:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606311204; bh=qMR4WaI/ekNVGzswOam38uhrE/iZ8ZA6U592n3HBsvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QT9LtFymLx8QxE54gU6H9wvWBf3Zmp2NL62G/yRo5IKH1uA1RS5ZMlF9xlm4NUh8n KKoc2BajuiVZdWaWJgwSsSGyR3SvLPOooBFuUMJFByB62z3+8WM4xF2p2zkARFkQnT DALFOGDQb1xluXHCpLujP+PjetHuUrGfCRAtlt2g= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khuvC-00DXJl-9S; Wed, 25 Nov 2020 13:33:22 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 25 Nov 2020 13:33:22 +0000 From: Marc Zyngier To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Morse , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , Dennis Zhou , Tejun Heo , Christoph Lameter , Mark Rutland , Lorenzo Pieralisi , Quentin Perret , Andrew Scull , Andrew Walbran , kernel-team@android.com Subject: Re: [PATCH v2 04/24] arm64: Move MAIR_EL1_SET to asm/memory.h In-Reply-To: <20201125132617.qf6vd752dtfasyi7@google.com> References: <20201116204318.63987-1-dbrazdil@google.com> <20201116204318.63987-5-dbrazdil@google.com> <87mtz85geh.wl-maz@kernel.org> <20201125103137.iml7mqpzhylldvqy@google.com> <20201125132617.qf6vd752dtfasyi7@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, qperret@google.com, ascull@google.com, qwandor@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-25 13:26, David Brazdil wrote: >> I came up with the following patch on top of this series that seems to >> compile without issue. > > That seems to have an implicit dependency of sysreg.h on memory.h, > doesn't it? > I had it the other way round initially. I also tried including memory.h > in > sysreg.h. That creates a circular dependency mmdebug.h -> bug.h -> ... > -> > sysreg.h -> memory.h -> mmdebug.h. Pretty annoying. I could try to fix > that, > or create a new header file... :( I don't think we need this. Any low-level source using MAIR_ELx_SET is bound to require memory.h as well, one way or another. As this is all #defines, it won't break anything unless actively used. And given that this is used in exactly *two* places, I don't believe there is a need for over-engineering this. Thanks, M. -- Jazz is not dead. It just smells funny...