public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: Configure.help in 2.5.3-pre6
Date: Wed, 30 Jan 2002 06:35:43 +0000 (UTC)	[thread overview]
Message-ID: <a3847v$17m$1@penguin.transmeta.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0201292147530.22800-100000@barbarella.hawaga.org.uk> <1012370595.3392.21.camel@phantasy>

In article <1012370595.3392.21.camel@phantasy>,
Robert Love  <rml@tech9.net> wrote:
>
>The intention is to fix [menu|x]config.  I believe plain 'ol `make
>config' works.  The new per-config.in config.help is here to stay.

Yes. On the other hand, if there are real problems with converting
menu/x config to multiple help-files, a short-term answer might indeed
be just the silly "concatenate everything into the same file".

I'd much _prefer_ to have somebody who knows menuconfug/xconfig (or just
wants to learn).  I have a totally untested patch for menuconfig, that
probably just works (like the regular config thing it doesn't actualy
take _advantage_ of pairing the Config.help files up with the questions,
but at least it should give you the help texts like it used to). 

I don't know tcl/tk _at_all_, so I haven't even looked at what the
required syntax is for header.tk to use the same kind of "find .  -name
Config.help" thing. 

		Linus

----- UNTESTED patch, use at your own risk -----
diff -u --recursive pre6/linux/scripts/Menuconfig linux/scripts/Menuconfig
--- pre6/linux/scripts/Menuconfig	Sun Aug  5 13:12:41 2001
+++ linux/scripts/Menuconfig	Tue Jan 29 22:31:46 2002
@@ -357,19 +357,18 @@
 
 
 #
-# Extract available help for an option from Configure.help
+# Extract available help for an option from Config.help
 # and send it to standard output.
 #
 # Most of this function was borrowed from the original kernel
 # Configure script.
 #
 function extract_help () {
-  if [ -f Documentation/Configure.help ]
-  then
-     #first escape regexp special characters in the argument:
-     var=$(echo "$1"|sed 's/[][\/.^$*]/\\&/g')
-     #now pick out the right help text:
-     text=$(sed -n "/^$var[ 	]*\$/,\${
+   #first escape regexp special characters in the argument:
+   var=$(echo "$1"|sed 's/[][\/.^$*]/\\&/g')
+   #now pick out the right help text:
+   text=$(cat /dev/null $(find . -name Config.help) |
+          sed -n "/^$var[ 	]*\$/,\${
                         /^$var[ 	]*\$/c\\
 ${var}:\\
 
@@ -378,19 +377,15 @@
                         s/^  //
 			/<file:\\([^>]*\\)>/s//\\1/g
                         p
-                    }" Documentation/Configure.help)
+                    }")
 
-     if [ -z "$text" ]
-     then
-          echo "There is no help available for this kernel option."
-	  return 1
-     else
-	  echo "$text"
-     fi
-  else
-	 echo "There is no help available for this kernel option."
-         return 1
-  fi
+   if [ -z "$text" ]
+   then
+        echo "There is no help available for this kernel option."
+        return 1
+   else
+	echo "$text"
+   fi
 }
 
 #


  reply	other threads:[~2002-01-30  6:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-30  5:51 Configure.help in 2.5.3-pre6 Ben Clifford
2002-01-30  6:03 ` Robert Love
2002-01-30  6:35   ` Linus Torvalds [this message]
2002-01-30  7:11     ` Robert Love
2002-01-30  8:20       ` David Lang
2002-02-07  9:24         ` Thomas Capricelli
2002-01-30  7:54     ` Patrick Mauritz
2002-01-30  8:22       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='a3847v$17m$1@penguin.transmeta.com' \
    --to=torvalds@transmeta.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox