linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: "Reshetova, Elena" <elena.reshetova@intel.com>,
	"Huang, Kai" <kai.huang@intel.com>
Cc: "seanjc@google.com" <seanjc@google.com>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"Scarlata, Vincent R" <vincent.r.scarlata@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"jarkko@kernel.org" <jarkko@kernel.org>,
	"Annapurve, Vishal" <vannapurve@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"Cai, Chong" <chongc@google.com>,
	"Bondarevska, Nataliia" <bondarn@google.com>,
	"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
	"Raynor, Scott" <scott.raynor@intel.com>
Subject: Re: [PATCH v11 4/5] x86/sgx: Implement ENCLS[EUPDATESVN]
Date: Fri, 8 Aug 2025 09:44:42 -0700	[thread overview]
Message-ID: <a3a3a0dd-e7b5-4827-9c8e-57485949fb13@intel.com> (raw)
In-Reply-To: <DM8PR11MB57503CDDEA0D6BB5913E9CC1E72FA@DM8PR11MB5750.namprd11.prod.outlook.com>

On 8/8/25 03:59, Reshetova, Elena wrote:
>> I am not sure whether this is needed.  Wouldn't the ENCLS_WARN() at the
>> end catch this case and the user is able to figure out what went wrong
>> from the error code?
> Dave has made a suggestion to include this check, so I have added it. 

If it's important enough to write a comment for it, it's important
enough to write a line of code for it.


  reply	other threads:[~2025-08-08 16:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  8:11 [PATCH v11 0/5] Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-08-06  8:11 ` [PATCH v11 1/5] x86/sgx: Introduce functions to count the sgx_(vepc_)open() Elena Reshetova
2025-08-06 23:38   ` Huang, Kai
2025-08-08 10:47     ` Reshetova, Elena
2025-08-10 23:29       ` Huang, Kai
2025-08-06  8:11 ` [PATCH v11 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag Elena Reshetova
2025-08-06 23:39   ` Huang, Kai
2025-08-08 10:48     ` Reshetova, Elena
2025-08-06  8:11 ` [PATCH v11 3/5] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN] Elena Reshetova
2025-08-06 23:41   ` Huang, Kai
2025-08-08 10:50     ` Reshetova, Elena
2025-08-06 23:49   ` Huang, Kai
2025-08-08 10:49     ` Reshetova, Elena
2025-08-06  8:11 ` [PATCH v11 4/5] x86/sgx: Implement ENCLS[EUPDATESVN] Elena Reshetova
2025-08-07  0:14   ` Huang, Kai
2025-08-08 10:59     ` Reshetova, Elena
2025-08-08 16:44       ` Dave Hansen [this message]
2025-08-10 23:28       ` Huang, Kai
2025-08-06  8:11 ` [PATCH v11 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-08-07  0:24   ` Huang, Kai
2025-08-08 11:06     ` Reshetova, Elena
2025-08-09 10:29 ` [PATCH v11 0/5] " Jarkko Sakkinen
2025-08-11  7:21   ` Reshetova, Elena
2025-08-12 16:18     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3a3a0dd-e7b5-4827-9c8e-57485949fb13@intel.com \
    --to=dave.hansen@intel.com \
    --cc=asit.k.mallick@intel.com \
    --cc=bondarn@google.com \
    --cc=chongc@google.com \
    --cc=elena.reshetova@intel.com \
    --cc=erdemaktas@google.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=scott.raynor@intel.com \
    --cc=seanjc@google.com \
    --cc=vannapurve@google.com \
    --cc=vincent.r.scarlata@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).