Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

Souptick Joarder
2020-09-06T02:18:21Z

On Sat, Sep 5, 2020 at 6:51 AM John Hubbard <jhubbard@nvidia.com> wrote:
>
> On 9/4/20 6:16 PM, Souptick Joarder wrote:
> > Hi Andrew,
> >
> > On Wed, Sep 2, 2020 at 3:00 AM John Hubbard <jhubbard@nvidia.com> wrote:
> >>
> >> On 9/1/20 2:21 PM, Souptick Joarder wrote:
> >>> First, when memory allocation for sg_list_unaligned failed, there
> >>> is a bug of calling put_pages() as we haven't pinned any pages.
> >>>
> >>> Second, if get_user_pages_fast() failed we should unpin num_pinned
> >>> pages.
> >>>
> >>> This will address both.
> >>>
> >>> As part of these changes, minor update in documentation.
> >>>
> >>> Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor
> >>> management driver")
> >>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >>> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> >>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> >>> ---
> >>
> >> This looks good to me.
> >
> > Can you please take this patch through the mm tree ?
> >
>
> Is there a problem with sending it through it's normal tree? It would probably
> get better testing coverage there.

scripts/get_maintainer.pl is showing only general lkml list and few
commit signer.
I didn't receive any feedback from anyone except you & Dan in more
than 12+ weeks
and mail bounced back from actual author Timur Tabi.

As it is more than 12 weeks, I requested Andrew to take it through mm tree.

Note -

While running ./scripts/get_maintainer.pl, I observed one issue. Everytime I run
the script, list is getting changed. Is it an expected behaviour ?

Below is the details ->

jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$
./scripts/get_maintainer.pl
0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch
Bjorn Andersson <bjorn.andersson@linaro.org> (commit_signer:1/1=100%)
Daniel Vetter <daniel.vetter@ffwll.ch> (commit_signer:1/1=100%)
Dan Williams <dan.j.williams@intel.com> (commit_signer:1/1=100%)
"Darren Hart (VMware)" <dvhart@infradead.org> (commit_signer:1/1=100%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
Arnd Bergmann <arnd@arndb.de>
(authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%)
Timur Tabi <timur@freescale.com> (blamed_fixes:1/1=100%)
Kumar Gala <galak@kernel.crashing.org> (blamed_fixes:1/1=100%)
linux-kernel@vger.kernel.org (open list)

jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$
./scripts/get_maintainer.pl
0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch
Bjorn Andersson <bjorn.andersson@linaro.org> (commit_signer:1/1=100%)
Daniel Vetter <daniel.vetter@ffwll.ch> (commit_signer:1/1=100%)
Dan Williams <dan.j.williams@intel.com> (commit_signer:1/1=100%)
"Darren Hart (VMware)" <dvhart@infradead.org> (commit_signer:1/1=100%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
Arnd Bergmann <arnd@arndb.de>
(authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%)
Timur Tabi <timur@freescale.com> (blamed_fixes:1/1=100%)
Kumar Gala <galak@kernel.crashing.org> (blamed_fixes:1/1=100%)
linux-kernel@vger.kernel.org (open list)

jordon@jordon-HP-15-Notebook-PC:~/Documents/virt/linux-next$
./scripts/get_maintainer.pl
0001-drivers-virt-fsl_hypervisor-Fix-error-handling-path.patch
Bjorn Andersson <bjorn.andersson@linaro.org> (commit_signer:1/1=100%)
Daniel Vetter <daniel.vetter@ffwll.ch> (commit_signer:1/1=100%)
Dan Williams <dan.j.williams@intel.com> (commit_signer:1/1=100%)
"Darren Hart (VMware)" <dvhart@infradead.org> (commit_signer:1/1=100%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
Arnd Bergmann <arnd@arndb.de>
(authored:1/1=100%,added_lines:1/1=100%,removed_lines:1/1=100%,blamed_fixes:1/1=100%)
Timur Tabi <timur@freescale.com> (blamed_fixes:1/1=100%)
Kumar Gala <galak@kernel.crashing.org> (blamed_fixes:1/1=100%)
linux-kernel@vger.kernel.org (open list)

>
>
> thanks,
> --
> John Hubbard
> NVIDIA