From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D111CEAA3 for ; Fri, 28 Nov 2025 08:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317419; cv=none; b=FafgIGb4Sa/XF4nF1SQTldUEI/ggcnKH/ChL0OvvkhxYkvWR3CkYoXHk/Nc/NwCkyBxKvnRG4KYOYMznt9vIX1t0OmkpKEQRFIZgd4C5cB5Zfr/F4UVaVsINYMOX9zGmHuThqEJLVIWfh2hZm+x2j5Zzle062cgLh1T/g72bcXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317419; c=relaxed/simple; bh=sEqqBSoUyz9ZEJQFOk2T8A74KM+YnuZfci4BtVr6KfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3FQO0wx0LuVNbNN8ZXAFBDIWWh73l/EuO+nrwWPxHWdJRr3tJ+nh1XKOayNm6sOr3gxhXPSsx3jEVL+/jTJJyf0ytZqbAH0Mk2IzA1rATlsQt1cEA36m4Yq28ETuUrdkfF8i3h2nlRV48ZIYfOom49zWi30wk2aYj7ozvAI4Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Acs3hkuX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Acs3hkuX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B1CAC4CEF1; Fri, 28 Nov 2025 08:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764317419; bh=sEqqBSoUyz9ZEJQFOk2T8A74KM+YnuZfci4BtVr6KfY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Acs3hkuXdCqFgVhHJMvRY+qHQTFITwID5SUPmsy2EZPng4pGzKN/RwGoIPtq7Csog kRMk5eLXzUeLRhKYT+C4IsU0trN+bSCIIXbnTHiZm5rgn77yqc3emDcfe0xs4P0sM0 NRwoQGKd7UO+1vVJAdpgcZZBhs5k4l5ItS3YbnXnLXYIMNgWiz0WFrEF53iHMlcb3q NBIdVzsNN1V3EMIvvdT8avUxZSof98aMgjmyjPs93ZHib70dexoa08ZdDeQ/7KRwFO y4NYyBJogBtdlCfkZ7L8Klm0JcS0X0HrujvwgRYiMD9UjlZlPz/DNSETrxAdNPXvqn eDW80vtgeIWqA== Message-ID: Date: Fri, 28 Nov 2025 09:10:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] powerpc/pseries/cmm: two smaller fixes To: "Ritesh Harjani (IBM)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy References: <20251021100606.148294-1-david@redhat.com> <557b5500-412a-4d26-8c4b-147c9a00d5fd@kernel.org> <87zf86n3vq.ritesh.list@gmail.com> <3cc7d401-c77c-4ac8-abb8-c264fbd9aaf0@kernel.org> <87y0nqmwaz.ritesh.list@gmail.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <87y0nqmwaz.ritesh.list@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/28/25 08:49, Ritesh Harjani (IBM) wrote: > "David Hildenbrand (Red Hat)" writes: > >> On 11/28/25 06:05, Ritesh Harjani (IBM) wrote: >>> "David Hildenbrand (Red Hat)" writes: >>> >>>> On 10/21/25 12:06, David Hildenbrand wrote: >>>>> Two smaller fixes identified while doing a bigger rework. >>>>> >>>>> Compile-tested only as I don't have an easy way to test right now. >>>>> >>>>> I would prefer for these patches to go through the MM tree as I will >>>>> be sending out a bigger version soon that is based on this series -- >>>>> I split of the fixes from the other stuff. >>>>> >>>> >>>> Ping, >>>> >>>> I tried to get CMM running again (using the simulation mode I introduced >>>> a while back), but so far my attempts to get a reasonable powernv VM >>>> booted in QEMU failed :( >>>> >>>> (e.g., Fedora qcow2 images use xfs, but the open powernv loader is based >>>> on a 5.10 kernel without some mystical XFS feature ...) >>>> >>> >> >> Hi Ritesh, >> >>> Sorry, I missed seeing this earlier. >>> >>> Do you have the link to simulation mode which you are referring above >>> please? So far I didn't find the support of this beyond Linux LPAR >>> (pseries), but maybe I missed it. >> >> When I did a rework of the CMM balloon in 2019, I needed a way to test >> it. So I added >> >> commit b1713975c31ae20ecc40fd00191ee3fa51445d4a >> Author: David Hildenbrand >> Date: Thu Oct 31 15:29:31 2019 +0100 >> >> powerpc/pseries/cmm: Simulation mode > > aah right. I should have looked closely. I was thinking you meant > somewhere in Qemu, so I was only looking there. > >> >> Let's allow to test the implementation without needing HW support. >> When "simulate=1" is specified when loading the module, we bypass all >> HW checks and HW calls. The sysfs file "simulate_loan_target_kb" can >> be used to simulate HW requests. >> >> The simualtion mode can be activated using: >> modprobe cmm debug=1 simulate=1 >> >> And the requested loan target can be changed using: >> echo X > /sys/devices/system/cmm/cmm0/simulate_loan_target_kb >> >> >> I allows for bypassing the absence of FW_FEATURE_CMO. >> > > Right. Let me give it a try first with pseries Qemu. Otherwise I have an > access to pseries LPAR too. I can verify it there. Ah, now I realize my problem: I tried with Fedora 43 in a powerpc VM but the modprobe didn't do anything. Looking again: # grep CONFIG_CMM /boot/config-6.17.1-300.fc43.ppc64le CONFIG_CMM=y So modprob'ing won't do as the module is built in. Anyhow, compiling a kernel inside a QEMU VM might take a while, so if you can beat me to it I wouldn't be mad :) Re powernv vs. powerpc: yeah, it's confusing. For some reason I thought I tested it in the days on powernv. Maybe that's simply because I was only able to get my hands on such a machine. Looking again, it should indeed be able to be simulated on a simple powerpc VM. -- Cheers David