From: Paolo Bonzini <pbonzini@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, frankja@linux.vnet.ibm.com
Subject: Re: [PATCH v1 1/1] KVM: add missing kvm_put_kvm in case of failure
Date: Tue, 27 Jun 2017 15:57:23 +0200 [thread overview]
Message-ID: <a3c75dcd-f31d-e8cc-3402-e43dbefe382d@redhat.com> (raw)
In-Reply-To: <20170627135007.GG10672@ZenIV.linux.org.uk>
On 27/06/2017 15:50, Al Viro wrote:
>> Queued, thanks.
> It's broken. Look: once we are past the anon_inode_getfile(), the
> reference we held on kvm is transferred into new struct file. After
> that point we don't drop kvm - we drop file. And as long as that
> file is held, it will keep holding what used to be our reference to
> kvm. Once all references to file are gone, its ->release() will be
> called and that's where kvm reference in it will be dropped.
>
> IOW, this patch introduces a double-put.
Yup, I've noticed your other reply (hopefully would have noticed during
regression testing). Thanks Al.
Paolo
next prev parent reply other threads:[~2017-06-27 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 11:57 [PATCH v1 1/1] KVM: add missing kvm_put_kvm in case of failure Claudio Imbrenda
2017-06-27 13:08 ` Paolo Bonzini
2017-06-27 13:50 ` Al Viro
2017-06-27 13:57 ` Paolo Bonzini [this message]
2017-06-27 13:34 ` Al Viro
2017-06-27 13:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c75dcd-f31d-e8cc-3402-e43dbefe382d@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox