From: Srinivas Kandagatla <srini.kernel@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Support Opensource <support.opensource@diasemi.com>,
Oder Chiou <oder_chiou@realtek.com>,
Srinivas Kandagatla <srini@kernel.org>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>
Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields
Date: Thu, 29 May 2025 10:29:29 +0100 [thread overview]
Message-ID: <a3ea3e51-2bd1-4155-906e-a39b35ec693b@gmail.com> (raw)
In-Reply-To: <20250528-asoc-const-unused-v1-4-19a5d07b9d5c@linaro.org>
On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote:
> Members wcd934x_codec.num_rx_port and num_tx_port are not read anywhere
> after assignment, so they can be safely dropped.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
--srini
> sound/soc/codecs/wcd934x.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
> index fa69817c97eaf1bf226b140f3a89095a50a128b2..1bb7e1dc7e6b0a5528cbdb7ada943a7d417fb684 100644
> --- a/sound/soc/codecs/wcd934x.c
> +++ b/sound/soc/codecs/wcd934x.c
> @@ -537,8 +537,6 @@ struct wcd934x_codec {
> int rate;
> u32 version;
> u32 hph_mode;
> - int num_rx_port;
> - int num_tx_port;
> u32 tx_port_value[WCD934X_TX_MAX];
> u32 rx_port_value[WCD934X_RX_MAX];
> int sido_input_src;
> @@ -1928,13 +1926,11 @@ static int wcd934x_set_channel_map(struct snd_soc_dai *dai,
> return -EINVAL;
> }
>
> - wcd->num_rx_port = rx_num;
> for (i = 0; i < rx_num; i++) {
> wcd->rx_chs[i].ch_num = rx_slot[i];
> INIT_LIST_HEAD(&wcd->rx_chs[i].list);
> }
>
> - wcd->num_tx_port = tx_num;
> for (i = 0; i < tx_num; i++) {
> wcd->tx_chs[i].ch_num = tx_slot[i];
> INIT_LIST_HEAD(&wcd->tx_chs[i].list);
>
next prev parent reply other threads:[~2025-05-29 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 19:59 [PATCH 0/8] ASoC: codecs: More const and unused member cleanups Krzysztof Kozlowski
2025-05-28 19:59 ` [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables Krzysztof Kozlowski
2025-05-29 9:28 ` Srinivas Kandagatla
2025-05-29 10:09 ` Charles Keepax
2025-05-28 19:59 ` [PATCH 2/8] ASoC: fsl: Constify reg_default array Krzysztof Kozlowski
2025-05-28 19:59 ` [PATCH 3/8] ASoC: codecs: wcd9335: Drop unused sido_input_src field Krzysztof Kozlowski
2025-05-29 9:27 ` Srinivas Kandagatla
2025-05-28 19:59 ` [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields Krzysztof Kozlowski
2025-05-29 9:29 ` Srinivas Kandagatla [this message]
2025-05-28 19:59 ` [PATCH 5/8] ASoC: codecs: wcd937x: Drop unused 'struct wcd937x_priv' fields Krzysztof Kozlowski
2025-05-29 9:30 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 6/8] ASoC: codecs: wcd938x: Drop unused 'struct wcd938x_priv' fields Krzysztof Kozlowski
2025-05-29 9:30 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 7/8] ASoC: codecs: wcd938x: Drop unused variant field Krzysztof Kozlowski
2025-05-29 9:31 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 8/8] ASoC: codecs: wcd939x: Drop unused 'struct wcd939x_priv' fields Krzysztof Kozlowski
2025-05-29 9:31 ` Srinivas Kandagatla
2025-05-29 9:33 ` [PATCH 0/8] ASoC: codecs: More const and unused member cleanups Srinivas Kandagatla
2025-05-29 9:38 ` Krzysztof Kozlowski
2025-06-09 21:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ea3e51-2bd1-4155-906e-a39b35ec693b@gmail.com \
--to=srini.kernel@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=shengjiu.wang@gmail.com \
--cc=srini@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).