From: Paul Walmsley <pjw@kernel.org>
To: Zong Li <zong.li@sifive.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, shuah@kernel.org,
linux-kselftest@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/riscv: fix compiler output flag spacing in all Makefiles
Date: Wed, 13 May 2026 17:01:24 -0600 (MDT) [thread overview]
Message-ID: <a407bc11-efcc-2254-01ca-607c3c62feed@kernel.org> (raw)
In-Reply-To: <20260511032917.3542802-1-zong.li@sifive.com>
On Sun, 10 May 2026, Zong Li wrote:
> Standardize the compiler output flag format across all RISC-V
> selftests by adding a space between '-o' and '$@'.
>
> Although '-o$@' is perfectly valid for GCC/Clang to parse, But
> changing it to '-o $@' with a space could align with the GNU
> official documentation conventions, improves readability by
> visually separating the flag from the target variable, and
> ensures consistency with other architectures
>
> Currently, RISC-V selftests use '-o$@' (without space) in 13
> instances across 6 Makefiles, while all other architectures
> consistently use '-o $@' (with space). This inconsistency makes
> RISC-V an outlier in the kernel's selftest infrastructure.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
Thanks, queued for v7.2.
- Paul
prev parent reply other threads:[~2026-05-13 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 3:29 [PATCH] selftests/riscv: fix compiler output flag spacing in all Makefiles Zong Li
2026-05-13 23:01 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a407bc11-efcc-2254-01ca-607c3c62feed@kernel.org \
--to=pjw@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=shuah@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox