From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D0A376481 for ; Thu, 7 May 2026 08:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778142838; cv=none; b=lFSgL3ieB/qZjeXaWN63pnEr//+TjKF35oQybuRmAj2MBeHHNWYb0lGOtOa3k6+ugp8P+Sz7dj6kZi6udtz0HBAicCQPZwJE4tjhlBZ1T+uhcmY7SeJq81xNnChwJY+Q15Dw5M65GWlPo/CtfwTAhv2F3ARd426dRzH9tA8eHlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778142838; c=relaxed/simple; bh=pvb1MHQLF11MJXf8+zcWPixcW83m0j26gAXbrydYl7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XtWnEhel1jQ24zW1WwvqWHeNcV0TgGgUJQP7AL/9R+1zCfpC+rHq7cKsj9E1+2ru0zG/oWf0ym4WWi4YRZFfx5u27ubzFLJcfAYZWd8IXGAtKHyaLy6aqxqybKZt43xijA1EfwKkx24rnsKOsGccTn/2x5QM3wDUYwZ3DFIA+bo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FPzeOtX/; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FPzeOtX/" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778142832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pvb1MHQLF11MJXf8+zcWPixcW83m0j26gAXbrydYl7U=; b=FPzeOtX/dwacWuJxi1CtVFm+UdCNOBga4/j0JsjDwEFJLiZquZCWytLqY8xJ+E+HaMmBwU oYAmTGtoLVwa3OhJBWMVG/ljX9nWUxNkAF8b+6E6Ql41kgGBQxqyaPS5BuyA8zlqjMtD45 yT+ZJ9owbVJ8zwyG33jWdqt1Yw/nNMo= Date: Thu, 7 May 2026 16:33:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 2/3] ppp: unify two channel structs To: Sebastian Andrzej Siewior Cc: Paolo Abeni , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jiri Kosina , David Sterba , Greg Kroah-Hartman , Jiri Slaby , Chas Williams <3chas3@gmail.com>, Simon Horman , James Chapman , Kees Cook , Taegu Ha , Guillaume Nault , Eric Woudstra , Arnd Bergmann , Dawid Osuchowski , Breno Leitao , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net References: <20260430090532.244758-1-qingfang.deng@linux.dev> <20260430090532.244758-2-qingfang.deng@linux.dev> <590d7931-02b0-45d6-8f43-ef909c9bde89@redhat.com> <20260507074051.mqO5DaWL@linutronix.de> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qingfang Deng In-Reply-To: <20260507074051.mqO5DaWL@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/5/7 15:40, Sebastian Andrzej Siewior wrote: > On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote: >>> This patch is IMHO a bit too big and should be split. Also this kind of >>> refactor looks very invasive and potentially regression prone. I think >>> it should include a signficant self-test coverage increase. >> This is indeed too big. But how do I split it without breaking the build? > The current ppp tests would yell if you accidentally broke something? By "breaking the build" I meant compile-time errors (due to API changes).