From: Jeff Layton <jlayton@kernel.org>
To: "Dmitry V. Levin" <ldv@strace.io>,
Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] statmount: update STATMOUNT_SUPPORTED macro
Date: Tue, 13 May 2025 15:08:37 -0400 [thread overview]
Message-ID: <a42a57a341ce02c9d2a52ab9f709ce45e19f7bb4.camel@kernel.org> (raw)
In-Reply-To: <20250511224953.GA17849@strace.io>
On Mon, 2025-05-12 at 01:49 +0300, Dmitry V. Levin wrote:
> According to commit 8f6116b5b77b ("statmount: add a new supported_mask
> field"), STATMOUNT_SUPPORTED macro shall be updated whenever a new flag
> is added.
>
> Fixes: 7a54947e727b ("Merge patch series "fs: allow changing idmappings"")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
> ---
> fs/namespace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 1b466c54a357..e321f8bae914 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -5804,7 +5804,9 @@ static int grab_requested_root(struct mnt_namespace *ns, struct path *root)
> STATMOUNT_SB_SOURCE | \
> STATMOUNT_OPT_ARRAY | \
> STATMOUNT_OPT_SEC_ARRAY | \
> - STATMOUNT_SUPPORTED_MASK)
> + STATMOUNT_SUPPORTED_MASK | \
> + STATMOUNT_MNT_UIDMAP | \
> + STATMOUNT_MNT_GIDMAP)
>
> static int do_statmount(struct kstatmount *s, u64 mnt_id, u64 mnt_ns_id,
> struct mnt_namespace *ns)
I guess this patch and the MNT_UID/GIDMAP patches went in around the
same time, and I missed adding them to the mask since I didn't have
that patch in the tree I was working against at the time.
This is probably better for the fixes tag though:
8f6116b5b77b statmount: add a new supported_mask field
...given that this patch went in just before it.
37c4a9590e1e statmount: allow to retrieve idmappings
Either way:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2025-05-13 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 22:49 [PATCH] statmount: update STATMOUNT_SUPPORTED macro Dmitry V. Levin
2025-05-12 9:20 ` Christian Brauner
2025-05-13 19:08 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42a57a341ce02c9d2a52ab9f709ce45e19f7bb4.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=ldv@strace.io \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox