* [PATCH] f2fs: remove unnecessary tracepoint enabled check
@ 2025-07-23 14:24 Sheng Yong
2025-07-24 2:46 ` Chao Yu
2025-07-24 20:30 ` [f2fs-dev] " patchwork-bot+f2fs
0 siblings, 2 replies; 3+ messages in thread
From: Sheng Yong @ 2025-07-23 14:24 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-f2fs-devel, linux-kernel, shengyong2021, Sheng Yong
From: Sheng Yong <shengyong1@xiaomi.com>
There is no extra work before trace_f2fs_[dataread|datawrite]_end(),
so there is no need to check trace_<tracepoint>_enabled().
Signed-off-by: Sheng Yong <shengyong1@xiaomi.com>
---
fs/f2fs/file.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index bd835c4f874a..a96115584203 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4855,8 +4855,7 @@ static ssize_t f2fs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
f2fs_update_iostat(F2FS_I_SB(inode), inode,
APP_BUFFERED_READ_IO, ret);
}
- if (trace_f2fs_dataread_end_enabled())
- trace_f2fs_dataread_end(inode, pos, ret);
+ trace_f2fs_dataread_end(inode, pos, ret);
return ret;
}
@@ -4879,8 +4878,7 @@ static ssize_t f2fs_file_splice_read(struct file *in, loff_t *ppos,
f2fs_update_iostat(F2FS_I_SB(inode), inode,
APP_BUFFERED_READ_IO, ret);
- if (trace_f2fs_dataread_end_enabled())
- trace_f2fs_dataread_end(inode, pos, ret);
+ trace_f2fs_dataread_end(inode, pos, ret);
return ret;
}
@@ -5225,8 +5223,7 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
f2fs_dio_write_iter(iocb, from, &may_need_sync) :
f2fs_buffered_write_iter(iocb, from);
- if (trace_f2fs_datawrite_end_enabled())
- trace_f2fs_datawrite_end(inode, orig_pos, ret);
+ trace_f2fs_datawrite_end(inode, orig_pos, ret);
}
/* Don't leave any preallocated blocks around past i_size. */
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: remove unnecessary tracepoint enabled check
2025-07-23 14:24 [PATCH] f2fs: remove unnecessary tracepoint enabled check Sheng Yong
@ 2025-07-24 2:46 ` Chao Yu
2025-07-24 20:30 ` [f2fs-dev] " patchwork-bot+f2fs
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2025-07-24 2:46 UTC (permalink / raw)
To: Sheng Yong, jaegeuk; +Cc: chao, linux-f2fs-devel, linux-kernel, Sheng Yong
On 7/23/25 22:24, Sheng Yong wrote:
> From: Sheng Yong <shengyong1@xiaomi.com>
>
> There is no extra work before trace_f2fs_[dataread|datawrite]_end(),
> so there is no need to check trace_<tracepoint>_enabled().
>
> Signed-off-by: Sheng Yong <shengyong1@xiaomi.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary tracepoint enabled check
2025-07-23 14:24 [PATCH] f2fs: remove unnecessary tracepoint enabled check Sheng Yong
2025-07-24 2:46 ` Chao Yu
@ 2025-07-24 20:30 ` patchwork-bot+f2fs
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+f2fs @ 2025-07-24 20:30 UTC (permalink / raw)
To: Sheng Yong; +Cc: jaegeuk, chao, shengyong1, linux-kernel, linux-f2fs-devel
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Wed, 23 Jul 2025 22:24:56 +0800 you wrote:
> From: Sheng Yong <shengyong1@xiaomi.com>
>
> There is no extra work before trace_f2fs_[dataread|datawrite]_end(),
> so there is no need to check trace_<tracepoint>_enabled().
>
> Signed-off-by: Sheng Yong <shengyong1@xiaomi.com>
>
> [...]
Here is the summary with links:
- [f2fs-dev] f2fs: remove unnecessary tracepoint enabled check
https://git.kernel.org/jaegeuk/f2fs/c/95d7c508b212
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-24 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 14:24 [PATCH] f2fs: remove unnecessary tracepoint enabled check Sheng Yong
2025-07-24 2:46 ` Chao Yu
2025-07-24 20:30 ` [f2fs-dev] " patchwork-bot+f2fs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).