From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5421914B940 for ; Tue, 7 May 2024 20:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715112447; cv=none; b=FLuB6myOQ+h+rnOasWoBWevpK1whougDI1Ff5GEfhf8F2wfCI2KdtC+i3YFZXS8FmKkCcVSpp1gCsA0XQ0eDJO2oOo3gTgV3UwPDKVt/JObayYy2mn/JHPOxKgEGqsrq1BXAa8TlXbX5fmy8tsUp6tGYnLH8i8RQccuMRAT5RhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715112447; c=relaxed/simple; bh=Mc50FQ9sa791H2dMnsRK0GR1vGBbxHb1li3CAQ2ZdSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e7U+SZhP88VGJzDl7kKRWwDPUCcY7mwqP3039H2xjttP6LYf4QS5ioaeLs5YkiKEotp551Xc107WFsEEil2rMBu5cT2X4/4B2j6ZRaocdgZBkhl/LZA22F7E5P4sJN4wJPsIT3x/MyVfnEbtgYUYg80l34nqoP4uNursTKcH3aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UtGykWW+; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UtGykWW+" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715112443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nt2uO6TpJx24xGPFvSzYImK2G9i5k2qnHj1h7z6S7Lg=; b=UtGykWW+noX7yFU08r1avJm7A81zlM2rR29tIloa0n2uR86TOf+TRIjG4Bp23h5dAh6GpO XZcLGHJc+2ahGxUgVCJJB+n+S0FA1+fHztZ8J5241liHKgdMkb3sy6vx5zUrLFcN7ba34M jVLuK0BJ7p2aluYRpfDvBx8wxZAG0kE= Date: Tue, 7 May 2024 16:07:18 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 1/7] dt-bindings: pci: xilinx-nwl: Add phys To: Rob Herring Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, Michal Simek , Bjorn Helgaas , Thippeswamy Havalige , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20240506161510.2841755-1-sean.anderson@linux.dev> <20240506161510.2841755-2-sean.anderson@linux.dev> <20240507200640.GA955773-robh@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240507200640.GA955773-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/7/24 16:06, Rob Herring wrote: > On Mon, May 06, 2024 at 12:15:04PM -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - Remove phy-names >> - Add an example >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> index 426f90a47f35..693b29039a9b 100644 >> --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> @@ -61,6 +61,10 @@ properties: >> interrupt-map: >> maxItems: 4 >> >> + phys: >> + minItems: 1 >> + maxItems: 4 > > I assume this is 1 phy per lane, but don't make me assume and define it. > > Rob It's one per lane. I'll add that to the description. --Sean