Re: [PATCH v2 05/12] cachefiles: add output string to cachefiles_obj_[get|put]_ondemand_fd

Jingbo Xu
2024-05-20T07:40:53Z

On 5/15/24 4:45 PM, libaokun@huaweicloud.com wrote:
> From: Baokun Li <libaokun1@huawei.com>
>
> This lets us see the correct trace output.
>
> Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Could we move this simple fix to the beginning of the patch set?

Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>

> ---
> include/trace/events/cachefiles.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/trace/events/cachefiles.h b/include/trace/events/cachefiles.h
> index 119a823fb5a0..bb56e3104b12 100644
> --- a/include/trace/events/cachefiles.h
> +++ b/include/trace/events/cachefiles.h
> @@ -130,6 +130,8 @@ enum cachefiles_error_trace {
> EM(cachefiles_obj_see_lookup_failed, "SEE lookup_failed") \
> EM(cachefiles_obj_see_withdraw_cookie, "SEE withdraw_cookie") \
> EM(cachefiles_obj_see_withdrawal, "SEE withdrawal") \
> + EM(cachefiles_obj_get_ondemand_fd, "GET ondemand_fd") \
> + EM(cachefiles_obj_put_ondemand_fd, "PUT ondemand_fd") \
> EM(cachefiles_obj_get_read_req, "GET read_req") \
> E_(cachefiles_obj_put_read_req, "PUT read_req")
>

--
Thanks,
Jingbo