Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

Akhil P Oommen
2024-06-26T21:00:40Z

On Mon, Jun 24, 2024 at 12:23:42AM +0300, Dmitry Baryshkov wrote:
> On Sun, Jun 23, 2024 at 04:36:30PM GMT, Akhil P Oommen wrote:
> > Add the necessary dt nodes for gpu support in X1E80100.
> >
> > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> > ---
> >
> > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 +++++++++++++++++++++++++
> > 1 file changed, 195 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index 5f90a0b3c016..3e887286bab4 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -6,6 +6,7 @@
> > #include <dt-bindings/clock/qcom,rpmh.h>
> > #include <dt-bindings/clock/qcom,x1e80100-dispcc.h>
> > #include <dt-bindings/clock/qcom,x1e80100-gcc.h>
> > +#include <dt-bindings/clock/qcom,x1e80100-gpucc.h>
> > #include <dt-bindings/clock/qcom,x1e80100-tcsr.h>
> > #include <dt-bindings/dma/qcom-gpi.h>
> > #include <dt-bindings/interconnect/qcom,icc.h>
>
>
> > + gmu: gmu@3d6a000 {
> > + compatible = "qcom,adreno-gmu-x185.1", "qcom,adreno-gmu";
> > + reg = <0x0 0x03d50000 0x0 0x10000>,
> > + <0x0 0x03d6a000 0x0 0x35000>,
> > + <0x0 0x0b280000 0x0 0x10000>;
> > + reg-names = "rscc", "gmu", "gmu_pdc";
>
> Ther @address should match the first resource defined for a device.

I will reorder this and move gmu to first.

-Akhil.

>
> > +
> --
> With best wishes
> Dmitry