Re: [alsa-devel] [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE

Pierre-Louis Bossart
2019-07-26T13:33:10Z

>> @@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns
>> *cdns)
>>    */
>>   int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns)
>>   {
>> -    int ret;
>> -
>>       _cdns_enable_interrupt(cdns);
>> -    ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE,
>> -                 CDNS_MCP_CONFIG_UPDATE_BIT);
>> -    if (ret < 0)
>> -        dev_err(cdns->dev, "Config update timedout\n");
>> -    return ret;
> Should we add cdns_update_config() here?

indeed, this would be a good improvement. The code works because we
added the exit_reset() sequence which does call cdns_update_config(),
but better make this function self-contained. When we enable the
clock-stop mode we will not do this reset sequence.