Re: [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE

Pierre-Louis Bossart
2019-08-02T15:18:56Z

On 8/2/19 7:03 AM, Vinod Koul wrote:
> On 25-07-19, 18:40, Pierre-Louis Bossart wrote:
>
>> int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns)
>> {
>> - int ret;
>> -
>> _cdns_enable_interrupt(cdns);
>> - ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE,
>> - CDNS_MCP_CONFIG_UPDATE_BIT);
>> - if (ret < 0)
>> - dev_err(cdns->dev, "Config update timedout\n");
>
> I was expecting cdns_update_config() to be invoked here??
>
>>
>> - return ret;
>> + return 0;
>
> It would be better if we return a value here a not success always
>
>> @@ -943,7 +953,10 @@ int sdw_cdns_init(struct sdw_cdns *cdns)
>>
>> cdns_writel(cdns, CDNS_MCP_CONFIG, val);
>>
>> - return 0;
>> + /* commit changes */
>> + ret = cdns_update_config(cdns);
>> +
>> + return ret;
>
> return cdns_update_config()

yes, all of this is fixed already.