Re: [RFC PATCH 31/40] soundwire: intel: move shutdown() callback and don't export symbol

Cezary Rojewski
2019-07-26T10:38:19Z

On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
> +void intel_shutdown(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct sdw_cdns_dma_data *dma;
> +
> + dma = snd_soc_dai_get_dma_data(dai, substream);
> + if (!dma)
> + return;
> +
> + snd_soc_dai_set_dma_data(dai, substream, NULL);
> + kfree(dma);
> +}

Correct me if I'm wrong, but do we really need to _get_dma_ here?
_set_dma_ seems bulletproof, same for kfree.