From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F19C4332F for ; Sat, 19 Nov 2022 05:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbiKSFrj (ORCPT ); Sat, 19 Nov 2022 00:47:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbiKSFrb (ORCPT ); Sat, 19 Nov 2022 00:47:31 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0CD186FFC; Fri, 18 Nov 2022 21:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668836849; x=1700372849; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kUZ4ZpWSa5gxjteKneIYtC+SJvGoLa4/s6wBAZos9mU=; b=SgxJMs7ns5woJ3u/Vt0n7usU2Eo6I3DEARimSB4uN/h0wlnpf832dI/3 uku+0/nDhsLO6lhO8K3saoztihnxckN6NHpzznnvI7bN3J4RVUq0tA3h9 1vx5UldBSrELETa8UAvxP2dYrwN79mSX1WEYk0YhsCfm7DxNdpunrMMsv cnhuQeIQbsIafgDRmgctyHyn6QhqJYOuyUtSoeCgG3duk9XEbteloir0v jNkPePRBg+b8Rl9RV1Lb8njGk64uMT7h7RGcAArcgvbKIJ6qLtmMVz0cU L6WeROBsXgheVe87hC3VR1hAQz2r25Pcru6Ks9TsH/iwSPVawu+tUajA9 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="375440251" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="375440251" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 21:47:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="673439851" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="673439851" Received: from alsoller-mobl1.amr.corp.intel.com (HELO [10.212.166.83]) ([10.212.166.83]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 21:47:29 -0800 Message-ID: Date: Fri, 18 Nov 2022 21:47:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.2 Subject: Re: [PATCH V8 RESEND 3/4] PCI: vmd: Create feature grouping for client products Content-Language: en-US To: "David E. Box" , nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev, lorenzo.pieralisi@arm.com, hch@infradead.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, michael.a.bottini@intel.com, rafael@kernel.org, me@adhityamohan.in Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221119021411.1383248-1-david.e.box@linux.intel.com> <20221119021411.1383248-4-david.e.box@linux.intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: <20221119021411.1383248-4-david.e.box@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/22 6:14 PM, David E. Box wrote: > Simplify the device ID list by creating a grouping of features shared by > client products. > > Suggested-by: Jon Derrick > Signed-off-by: David E. Box > --- > Looks good to me. Reviewed-by: Kuppuswamy Sathyanarayanan > V8 - New patch. > > drivers/pci/controller/vmd.c | 28 ++++++++++------------------ > 1 file changed, 10 insertions(+), 18 deletions(-) > > diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c > index 9dedca714c18..86f3085db014 100644 > --- a/drivers/pci/controller/vmd.c > +++ b/drivers/pci/controller/vmd.c > @@ -68,6 +68,10 @@ enum vmd_features { > VMD_FEAT_CAN_BYPASS_MSI_REMAP = (1 << 4), > }; > > +#define VMD_FEATS_CLIENT (VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | \ > + VMD_FEAT_HAS_BUS_RESTRICTIONS | \ > + VMD_FEAT_OFFSET_FIRST_VECTOR) > + > static DEFINE_IDA(vmd_instance_ida); > > /* > @@ -1001,29 +1005,17 @@ static const struct pci_device_id vmd_ids[] = { > VMD_FEAT_HAS_BUS_RESTRICTIONS | > VMD_FEAT_CAN_BYPASS_MSI_REMAP,}, > {PCI_VDEVICE(INTEL, 0x467f), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {PCI_VDEVICE(INTEL, 0x4c3d), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {PCI_VDEVICE(INTEL, 0xa77f), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {PCI_VDEVICE(INTEL, 0x7d0b), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {PCI_VDEVICE(INTEL, 0xad0b), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B), > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | > - VMD_FEAT_HAS_BUS_RESTRICTIONS | > - VMD_FEAT_OFFSET_FIRST_VECTOR,}, > + .driver_data = VMD_FEATS_CLIENT,}, > {0,} > }; > MODULE_DEVICE_TABLE(pci, vmd_ids); -- Sathyanarayanan Kuppuswamy Linux Kernel Developer