From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org, Jessica Yu <jeyu@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel/module: Delete an error message for a failed memory allocation in add_module_usage()
Date: Fri, 6 Oct 2017 17:12:10 +0200 [thread overview]
Message-ID: <a47bc166-7592-2ff8-9b94-4d45e18b6004@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 6 Oct 2017 16:27:26 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
kernel/module.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index de66ec825992..07ef44767245 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -837,10 +837,8 @@ static int add_module_usage(struct module *a, struct module *b)
pr_debug("Allocating new usage for %s.\n", a->name);
use = kmalloc(sizeof(*use), GFP_ATOMIC);
- if (!use) {
- pr_warn("%s: out of memory loading\n", a->name);
+ if (!use)
return -ENOMEM;
- }
use->source = a;
use->target = b;
--
2.14.2
next reply other threads:[~2017-10-06 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 15:12 SF Markus Elfring [this message]
2017-10-19 9:29 ` kernel/module: Delete an error message for a failed memory allocation in add_module_usage() Jessica Yu
2017-10-19 10:30 ` Dan Carpenter
2017-10-19 11:02 ` Jessica Yu
2017-10-19 11:12 ` SF Markus Elfring
2017-10-19 10:42 ` SF Markus Elfring
2017-10-19 11:08 ` Jessica Yu
2017-10-19 11:18 ` SF Markus Elfring
2017-10-19 11:29 ` Joe Perches
2017-10-19 11:35 ` SF Markus Elfring
2017-10-19 11:45 ` Joe Perches
2017-10-19 18:56 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a47bc166-7592-2ff8-9b94-4d45e18b6004@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jeyu@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox