From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdJFPMc (ORCPT ); Fri, 6 Oct 2017 11:12:32 -0400 Received: from mout.web.de ([212.227.17.12]:49820 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbdJFPMb (ORCPT ); Fri, 6 Oct 2017 11:12:31 -0400 To: kernel-janitors@vger.kernel.org, Jessica Yu , Rusty Russell Cc: LKML From: SF Markus Elfring Subject: [PATCH] kernel/module: Delete an error message for a failed memory allocation in add_module_usage() Message-ID: Date: Fri, 6 Oct 2017 17:12:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:porJn8UcFLYQciHmmfgbIaOFa7+dayegyoZswgdV9mgEtUZCe0I ctOOiLEToUK6ZizMelhZlpyS1wk4DyxHnEWljIpJUSbg6RXLuW57Bs/pYM9S381w/vfh+n1 HgV9IdjO2bx9HKsWyMXgemDUr195Bl5Q9GKKvdeHS4FITjYRy0LYbiDmtwM3RW+vKrRHrzt luuRh1BHgKnkP3QOBtuRA== X-UI-Out-Filterresults: notjunk:1;V01:K0:8ShZvn0mgo4=:J6x1F1VHcPFpSFm6ltrCLN k22iqX6CzVUCLEYZiy21+K8u0eefbHQyvBMELAOv3bF8dMy414lI+juGX90hm4CgdPEq0I12d R6DdO4Ns0ua4L+R/KJ2LnY5l//vUNTrfqNwCk+j+Bm1NWq08lNCiMYx2T6YUwwIPufGeXUq7M sK+xEPqYz0x5V72x/AdDjBmUzO0rr3+J+rJGlLa94xoiGxOkZ/zvv4IyGvUwZAjadrYZBGtse +m9sRlIiEl9gc8gRnMSbFvmnyUnQREVrMEykMbluSo9QSzIqQGT1/z4UlF8hN3sMBCIAblDUq 5dn/aCXHUc3q1Na6lhu/7mOQ1S8KrZ7RxbNAMaFZjt5vtqae9vLK53FBUW/oeDaK90bnRPqhp 6eCVMoivrvxMpWj5vgcKcerBOc1r0xbN0u7WeBUj9/yMEffkJXCl+/DSn9mRRrbCOhx+A15P2 1naFHC6a9lTq33VYGhJD4cSPv2k9j10LIWZKgQS0ELAZBmfRRzLR+K8xhemyikK420+wQK42o ut5BsBKCigAXFzLlbDElAaTpyW/EbIxVIReNZ8YrogKBKDZeE61auvtl209e1xW685BHE53/K NiS0sQW+gJWli2rvyFxK4Mbp26G0cGRVaxFwNvVCr+Wf6azct224vpq+xbKYTQzt1TsprqzaX A6ncCylWEqFQVPNFshQ/D8XpGdqprYFds4E3eHpKVvPSPp0Acc+AwfXKKXMiGzmpmQKkLAudJ LKZ9vVmUusIQB6QXixw7m8xsCVzKUprtaKsfnPGlR+jmH8hejDKvzU8D/t05YqX9heLN3ocWj gi5mi85DO8A+ZeEUuWEDBEnxt+jf+9De8o4RwlUp/dwk7nQTvE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Oct 2017 16:27:26 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/module.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index de66ec825992..07ef44767245 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -837,10 +837,8 @@ static int add_module_usage(struct module *a, struct module *b) pr_debug("Allocating new usage for %s.\n", a->name); use = kmalloc(sizeof(*use), GFP_ATOMIC); - if (!use) { - pr_warn("%s: out of memory loading\n", a->name); + if (!use) return -ENOMEM; - } use->source = a; use->target = b; -- 2.14.2