From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6156936BCDD for ; Thu, 30 Apr 2026 05:51:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777528306; cv=none; b=IKz+Nd3rNY+YfDubSZ1UrSJ6ThNCIoTA30UZoGoli1GStzdgqHVAvwIeDaftwdtNmmiAxUPatHjwFPsCO7HkmvhAU2ho/Sefuhf5Oi5vR3mLOWeUc/0FD1wY4ZzkDfByijzqF93xWJlUyWgRvHuWo+U3k+fkCQrad7wqdY/SepY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777528306; c=relaxed/simple; bh=CgsL9lPVU9qlSBepqHiQxE4D3Owbkt5paVOqB8gMMOI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qVvXpgWCFGiBOwE4pc9nNpQJ+NKw2Qi28FAZf51cKTRpnrGqHirAQkEC0OREzIrE45jz0SaX2I9RhXPsWz9QBn3aQ9Idxv9ZQo/YxUp6OuOksuSz2sPzmm57OuRQoLrI/Kz52r1LKV+b77NkBd59fq7VoO0W/g99c0YUWMAXqrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SIoFDF00; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=STjD+HeI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SIoFDF00"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="STjD+HeI" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63TKbH58255358 for ; Thu, 30 Apr 2026 05:51:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GBo8ysA1qyB2SNrMg3M4cw+4GiEHzW7353RLYSNaXxk=; b=SIoFDF00jacDCQNv i3fu10f9ds0/OtMoHPEFVd/6Qx39sk0UphPrlu07uST1WAn7xgnhza6bHQIxF8wA Okq2HyKddErlj0Xj/6dcN1RJi8Y6CjgImTd49bB7GbR7/qiksoB6G3C0xvJ3cR9X y76UzzksFCsIXLCXYAm48Ui1GELWl0NyictWSXXP71am1DKRt/QMWJkP976JgwzB 5ekHsdoajKWjMOHtNlpkEHblVHwH0g2d6KhfdRupL2agjCUJlNR7HAILigz1CrTe tiBX91nNXxzT7PdtdSYvPteLEYR5COA01DCvM/mgC4W3OfIiJCkikmuTCrO9zJAf NtIPJA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dun71jg34-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Apr 2026 05:51:43 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-362eaa3aa61so549202a91.0 for ; Wed, 29 Apr 2026 22:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777528303; x=1778133103; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GBo8ysA1qyB2SNrMg3M4cw+4GiEHzW7353RLYSNaXxk=; b=STjD+HeIJUgtNq+hBQVDZgpi4Gb6iHMXiqIeT8mLVNcJP2TJPhCy5o5LLX67JsBAMZ Ud2GAsYqeLqpjlG/gr6Oif9SSikPJMQduZwaXdK73r1lgWtHR7KH7ox482+d9oPl/kcN XmIDKAArHsn1S3zfkGWRV27t2LEA2/oRec2PvCn17q0xEef4rvaKDp7OsfA77fbMEvIg OgaVqOrpUiqX409SbWG9uzmtCsldunEKTkHCEgfgX1meMTiC/fSneVWN+v0960mT6y1m qxmv9bq6rG/pwmELu7I0Hh+mrosqepauQZdSBCWTJKzGInda156X07pCeJBiNL1CCVaB AHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777528303; x=1778133103; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GBo8ysA1qyB2SNrMg3M4cw+4GiEHzW7353RLYSNaXxk=; b=lHioX3A5jrHn2vxuhix+8sFfAMLn0PDD8qL73rRbvP7KwFrO0DlHm7G3J8KgTlnzDd zFztGNKVDCwizTP8R1joW7rSd3csjgnRMkA3gg/xGQ3yJfJlJacOtgduZvyRqfTap/Ck JsAaFw3nrPX+Ao3uuPxcg+O3xtPcEw2gkCyQhGji5YLtIO3XlUilQ2m6HXGfBUcRV38W CC3+TRh6A6T2V6bNBk2EA71aoX4fepMmNu8b1mEikMm9kCz/sAYEczFPhYceRvt2NLsh CgYYL5NXwZeOSh4+fdVvEc9OatL+DU5rQx7XlARtDEsVi6blgaIltN+sZewmliesQPt4 1XFw== X-Forwarded-Encrypted: i=1; AFNElJ/tlP6+nHl8OpV1gZrFVvP0jTXd/dM2e0nNhtpGAjmpeiU2w+kAg4WgEu//vQn8J69TaykcZ3Eu5PD4OhM=@vger.kernel.org X-Gm-Message-State: AOJu0YzDoIs/+gRCiMf+W8ksAb2vm7GKgEsDdoD8XOTWjbnsaLpOuETc lMPuKVEIaaLlaUdDLmkEOzA7y0ggtN/htz0bfeIaBuc5Ib/FymzqOapuCLjamj3EQl3XA/rBnhT qoE6rCCsJ6oonz0ZQOCr5OayRsvru3YUdWIi+4ZvXJJZlHofxqGRzBDKBvVlfTTE4ApM= X-Gm-Gg: AeBDieuUg03kjMsizo9WO8aar/kPl70YytFqu/enr7EcN7DOY+dtmWRTmCYnzhnjx4T FNgv+Vsq/HvH3gzkh6q+zHY9VI3YWyWD1F2uVMFx25frbqUM3CkdBTpgrIjAFa6vz0ieFNQKU27 wxijBE7S4ErbntaDGkIT1GyVBh7DZHslqVn0hj1J14bSJHwwodRDKTi7rKl0PKt/nBXrLr+t5kW 24I6UQ8R4QfHdscjGztOq9hjiuAXvyE/lbs8kqlO04btRivGewybZd5pb6Gw7vuup4vIL0JL24b kxElDCK1VIQHGGr9T6Ep32e3agLe/TUBiYVjj1spsnTyEmDv2poxIuFT7iBEz5jLB1jmtB5mTBg It3lavwSI3qlOJ+VBbzXYq7luYu9xhGk6El500pwY39GwAzIxn3QdrphuJAYAzWRQ X-Received: by 2002:a17:90b:2ecd:b0:35b:e550:e68a with SMTP id 98e67ed59e1d1-364c2f8cf70mr1346450a91.3.1777528302985; Wed, 29 Apr 2026 22:51:42 -0700 (PDT) X-Received: by 2002:a17:90b:2ecd:b0:35b:e550:e68a with SMTP id 98e67ed59e1d1-364c2f8cf70mr1346420a91.3.1777528302532; Wed, 29 Apr 2026 22:51:42 -0700 (PDT) Received: from [10.217.216.47] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364c3fa0240sm361576a91.5.2026.04.29.22.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 22:51:41 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 11:21:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] clk: qcom: dispcc-sdm845: set GENPD_FLAG_NO_STAY_ON flag for MDSS domain To: David Heidelberg , Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Ulf Hansson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org References: <20260217-sdm845-hdk-v1-0-866f1965fef7@oss.qualcomm.com> <20260217-sdm845-hdk-v1-1-866f1965fef7@oss.qualcomm.com> <857f0582-8b46-4bfa-8c62-5ca6f3d0aec5@oss.qualcomm.com> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NEDVTf7dsOm1yRDwgMmQSdEwFu6WGjba X-Proofpoint-ORIG-GUID: NEDVTf7dsOm1yRDwgMmQSdEwFu6WGjba X-Authority-Analysis: v=2.4 cv=TvHWQjXh c=1 sm=1 tr=0 ts=69f2edef cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=MnzUK-aiO01mxYzieDsA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDMwMDA1NSBTYWx0ZWRfX6D4BPF/QmLtF OtPfr3hSEFAVNVWlUZyw5iG6cyApr4uyg71yccR2TjdCLA9Aq6yMcGmvXKlR40GgqOcB7lrEqHr m94g/1AAiAhKKfd7qLXG+AFuRWw5DDLbVp1ato4PHxi3+dM3Dw/9V+J8JIWR3ic+hNMvx+t1gb5 vGWpJse37Mg+sN9Ncuji/5c3TXWcAo9kqICdxkt87QdcaiZryyo/8H2EsgvTwHmQrhQZBHgltaU dOshVPSOwZR8yPhQYdaVjAx8U0o+nHu/TEL83bNpZRR8JLY/LzRy2np0XsvR6VJEq3S83eErvRC MM4RDDM9lQo1hCsiWeOaxlalmn8N1+mpKk6sUd+IPyXT7mF0pmZhb8TE1EpJAa95lRB6rA62XAc JPS5PdCu5zuvETzVrXwltLu8EJIedkPIaZ5E/ltL9GHxfL1QEWd44gu3NKCqH7IQ+vxuJy5F2cy CxzE91tV1cfw9DSvjmw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-30_01,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300055 On 4/29/2026 8:52 PM, David Heidelberg wrote: > On 23/02/2026 02:27, Dmitry Baryshkov wrote: >> On Thu, Feb 19, 2026 at 11:41:06PM +0530, Jagadeesh Kona wrote: >>> >>> >>> On 2/18/2026 9:28 PM, Dmitry Baryshkov wrote: >>>> On Wed, Feb 18, 2026 at 08:49:34AM -0600, Bjorn Andersson wrote: >>>>> On Tue, Feb 17, 2026 at 11:20:42PM +0200, Dmitry Baryshkov wrote: >>>>>> Since the commit 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds >>>>>> on until late_initcall_sync") setting of the display clocks is partially >>>>>> broken. For example, when on SDM845-HDK the bootloader leaves display >>>>>> enabled, later the kernel can't set up DSI clocks, ending up with the >>>>>> broken display, blinking blue. >>>>> >>>>> This describes how the problem manifest itself. Can you please document >>>>> why clocks are partially broken and how that relate to the GDSC state, >>>>> and why setting GENPD_FLAG_NO_STAY_ON solves this? >>>> >>>> Probably the best answer (for the second part of the question): I don't >>>> know (yet). >>>> >>> >>> RCG update typically gets stuck if the new/old source is OFF while the RCG is ON; but >>> if the RCG is already OFF, the update proceeds safely even if new/old source is OFF. >>> >>> A possible theory is that if the GDSC is in OFF state, the branch clocks will be OFF, >>> due to this RCG also will be in OFF state, preventing the update stuck issue even if >>> the new/old source is OFF. But, if the GDSC remains on until sync_state, the branches >>> and RCG likely stays ON, leading to update stuck issue if the new/old source is OFF. >>> >>> Ideally, if both old and new RCG sources are ON during the update configuration, the >>> update should succeed regardless of the GDSC status. >> >> Both pclkN_clk_src clocks have CLK_OPS_PARENT_ENABLE set, so the parents >> must be on. > > Should this patch go in as is then? Yes, this change keeps the display GDSC behavior similar to earlier code(i.e prior to commit 13a4b7fb6260), so can be mainlined. Thanks, Jagadeesh