From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Denis Benato <denis.benato@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
"Limonciello, Mario" <mario.limonciello@amd.com>,
"Luke D . Jones" <luke@ljones.dev>,
Alok Tiwari <alok.a.tiwari@oracle.com>,
Derek John Clark <derekjohn.clark@gmail.com>,
Mateusz Schyboll <dragonn@op.pl>,
porfet828@gmail.com, Denis Benato <benato.denis96@gmail.com>
Subject: Re: [PATCH 1/2] platform/x86: asus-armoury: remove unused macro parameter
Date: Wed, 12 Nov 2025 14:32:22 +0200 (EET) [thread overview]
Message-ID: <a488f1e9-11f2-d6ca-49a6-91eac3c3a053@linux.intel.com> (raw)
In-Reply-To: <20251111191104.1401105-1-denis.benato@linux.dev>
On Tue, 11 Nov 2025, Denis Benato wrote:
> Increase consistency of macros used to get/set uint attributes: remove the unused _fmt macro parameter.
>
> Signed-off-by: Denis Benato <denis.benato@linux.dev>
> ---
> drivers/platform/x86/asus-armoury.c | 4 ++--
> drivers/platform/x86/asus-armoury.h | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index d57fbb5dc3d3..9f67218ecd14 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -527,7 +527,7 @@ static ssize_t gpu_mux_mode_current_value_store(struct kobject *kobj,
>
> return count;
> }
> -ASUS_WMI_SHOW_INT(gpu_mux_mode_current_value, "%u\n", asus_armoury.gpu_mux_dev_id);
> +ASUS_WMI_SHOW_INT(gpu_mux_mode_current_value, asus_armoury.gpu_mux_dev_id);
> ASUS_ATTR_GROUP_BOOL(gpu_mux_mode, "gpu_mux_mode", "Set the GPU display MUX mode");
>
> static ssize_t dgpu_disable_current_value_store(struct kobject *kobj,
> @@ -561,7 +561,7 @@ static ssize_t dgpu_disable_current_value_store(struct kobject *kobj,
>
> return count;
> }
> -ASUS_WMI_SHOW_INT(dgpu_disable_current_value, "%d\n", ASUS_WMI_DEVID_DGPU);
> +ASUS_WMI_SHOW_INT(dgpu_disable_current_value, ASUS_WMI_DEVID_DGPU);
> ASUS_ATTR_GROUP_BOOL(dgpu_disable, "dgpu_disable", "Disable the dGPU");
>
> /* Values map for eGPU activation requests. */
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 5e1ab729277a..8f7e5da087a6 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -81,7 +81,7 @@ ssize_t armoury_attr_uint_show(struct kobject *kobj, struct kobj_attribute *attr
> _max, NULL, _wmi); \
> }
>
> -#define ASUS_WMI_SHOW_INT(_attr, _fmt, _wmi) \
> +#define ASUS_WMI_SHOW_INT(_attr, _wmi) \
> static ssize_t _attr##_show(struct kobject *kobj, \
> struct kobj_attribute *attr, char *buf) \
> { \
> @@ -101,7 +101,7 @@ ssize_t armoury_attr_uint_show(struct kobject *kobj, struct kobj_attribute *attr
> __ASUS_ATTR_RO(_attrname, _prop)
>
> #define __ATTR_RO_INT_GROUP_ENUM(_attrname, _wmi, _fsname, _possible, _dispname)\
> - ASUS_WMI_SHOW_INT(_attrname##_current_value, "%d\n", _wmi); \
> + ASUS_WMI_SHOW_INT(_attrname##_current_value, _wmi); \
> static struct kobj_attribute attr_##_attrname##_current_value = \
> __ASUS_ATTR_RO(_attrname, current_value); \
> __ATTR_SHOW_FMT(display_name, _attrname, "%s\n", _dispname); \
> @@ -122,7 +122,7 @@ ssize_t armoury_attr_uint_show(struct kobject *kobj, struct kobj_attribute *attr
> #define __ATTR_RW_INT_GROUP_ENUM(_attrname, _minv, _maxv, _wmi, _fsname,\
> _possible, _dispname) \
> __WMI_STORE_INT(_attrname##_current_value, _minv, _maxv, _wmi); \
> - ASUS_WMI_SHOW_INT(_attrname##_current_value, "%d\n", _wmi); \
> + ASUS_WMI_SHOW_INT(_attrname##_current_value, _wmi); \
> static struct kobj_attribute attr_##_attrname##_current_value = \
> __ASUS_ATTR_RW(_attrname, current_value); \
> __ATTR_SHOW_FMT(display_name, _attrname, "%s\n", _dispname); \
> @@ -227,7 +227,7 @@ ssize_t armoury_attr_uint_show(struct kobject *kobj, struct kobj_attribute *attr
> }
>
> #define ASUS_ATTR_GROUP_INT_VALUE_ONLY_RO(_attrname, _fsname, _wmi, _dispname) \
> - ASUS_WMI_SHOW_INT(_attrname##_current_value, "%d\n", _wmi); \
> + ASUS_WMI_SHOW_INT(_attrname##_current_value, _wmi); \
> static struct kobj_attribute attr_##_attrname##_current_value = \
> __ASUS_ATTR_RO(_attrname, current_value); \
> __ATTR_SHOW_FMT(display_name, _attrname, "%s\n", _dispname); \
>
I've folded these into the the original commits (to the 2nd & 9th change).
--
i.
prev parent reply other threads:[~2025-11-12 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 19:11 [PATCH 1/2] platform/x86: asus-armoury: remove unused macro parameter Denis Benato
2025-11-11 19:11 ` [PATCH 2/2] platform/x86: asus-armoury: add support for FX507VV Denis Benato
2025-11-12 12:32 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a488f1e9-11f2-d6ca-49a6-91eac3c3a053@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=alok.a.tiwari@oracle.com \
--cc=benato.denis96@gmail.com \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dragonn@op.pl \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=porfet828@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox