public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Szilard Fabian <szfabian@bluemarch.art>
Cc: LKML <linux-kernel@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,  jwoithe@just42.net,
	Hans de Goede <hdegoede@redhat.com>,
	W_Armin@gmx.de
Subject: Re: [PATCH v4] platform/x86/fujitsu-laptop: Add battery charge control support
Date: Tue, 27 Feb 2024 12:18:16 +0200 (EET)	[thread overview]
Message-ID: <a4b35e55-1f29-6c98-745c-df6896e49270@linux.intel.com> (raw)
In-Reply-To: <170834440647.4050.13047961348645894978.b4-ty@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Mon, 19 Feb 2024, Ilpo Järvinen wrote:

> On Thu, 15 Feb 2024 20:31:43 +0000, Szilard Fabian wrote:
> 
> > This patch adds battery charge control support on Fujitsu notebooks
> > via the S006 method of the FUJ02E3 ACPI device. With this method it's
> > possible to set charge_control_end_threshold between 50 and 100%.
> > 
> > Tested on Lifebook E5411 and Lifebook U728. Sadly I can't test this
> > patch on a dual battery one, but I didn't find any clue about
> > independent battery charge control on dual battery Fujitsu notebooks
> > either. And by that I mean checking the DSDT table of various Lifebook
> > notebooks and reverse engineering FUJ02E3.dll.
> > 
> > [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/1] platform/x86/fujitsu-laptop: Add battery charge control support
>       commit: 9b716ef48c90446b8d6d86726c6c3f0141e53091

Hi,

Can you please take a look at the two build failures LKP has brought up. 
They looked like some depends on and/or select clauses missing from 
Kconfig.

I'll be merging the patches that fix those into the original commit so 
don't spend too much fine-tuning the commit message.

-- 
 i.

  reply	other threads:[~2024-02-27 10:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 16:36 [RFC PATCH] platform/x86/fujitsu-laptop: Add battery charge control support Szilard Fabian
2024-01-29 18:00 ` [RFC PATCH v2] " Szilard Fabian
2024-01-30  2:02   ` Armin Wolf
2024-02-03  0:17     ` Szilard Fabian
2024-02-05 17:07       ` Armin Wolf
2024-02-05 23:37         ` Jonathan Woithe
2024-02-07  2:32   ` [RFC PATCH v3] " Szilard Fabian
2024-02-07  8:57     ` Hans de Goede
2024-02-08  1:56       ` Szilard Fabian
2024-02-08  9:11         ` Hans de Goede
2024-02-15 11:34     ` Ilpo Järvinen
2024-02-15 20:12       ` Szilard Fabian
2024-02-16  9:27         ` Ilpo Järvinen
2024-02-15 20:31     ` [PATCH v4] " Szilard Fabian
2024-02-18  4:47       ` Jonathan Woithe
2024-02-19 12:06       ` Ilpo Järvinen
2024-02-27 10:18         ` Ilpo Järvinen [this message]
2024-02-27 12:04           ` Szilard Fabian
2024-02-27 12:05       ` [PATCH v5] " Szilard Fabian
2024-02-27 12:53         ` Ilpo Järvinen
2024-02-27 21:47         ` Jonathan Woithe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4b35e55-1f29-6c98-745c-df6896e49270@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=jwoithe@just42.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=szfabian@bluemarch.art \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox