Re: [PATCH 10/10] iio: dac: add mcf54415 DAC

Greg Ungerer
2026-05-05T02:07:01Z

On 5/5/26 03:27, Arnd Bergmann wrote:
> On Mon, May 4, 2026, at 19:16, Angelo Dureghello wrote:
>
>> +static void mcf54415_dac_exit(void *data)
>> +{
>> + struct mcf54415_dac *info = data;
>> + int val;
>> +
>> + val = readw(info->regs + MCF54415_DAC_CR);
>> + val |= MCF54415_DAC_CR_PDN;
>> + writew(val, info->regs + MCF54415_DAC_CR);
>> +}
>
> We've recently discussed changing the MMIO accessors on coldfire
> to behave like all the other ones, which makes readw() and writew()
> have an implicit byteswap. An additional driver means one more
> place to change during the conversion. Maybe you can use the
> new mcf_readw()/mcf_writew() helpers that Greg has started
> introducing? Those will keep using native big-endian register
> definitions.

Yes, please :-)
Those newly introduced mcf_readX/mcf_writeX are in the for-next branch
of the m68knommu git tree now, they have not hit mainline yet, hopefully
in the next merge cycle.

Somewhat related, I will have patches out for the other affected drivers
over the next few days.

Regards
Greg