public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shardul Bankar <shardulsb08@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	 Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf 1/1] bpf: liveness: Handle ERR_PTR from get_outer_instance() in propagate_to_outer_instance()
Date: Mon, 20 Oct 2025 11:43:08 +0530	[thread overview]
Message-ID: <a4fd6596e4a646d7c3a19b4a8f398b970f27e8db.camel@gmail.com> (raw)
In-Reply-To: <69d2c22ed0cac19a2fc13d422597d781281e4625.camel@gmail.com>

On Thu, 2025-10-16 at 10:43 -0700, Eduard Zingerman wrote:
> We can land this change to avoid confusion, but the fixes tag is
> unnecessary.
> 
> [1]
> https://lore.kernel.org/bpf/8430f47f73d8d55a698e85341ece81955355c1fd.camel@gmail.com/
> 
Thanks, Eduard, for the clarification and reference.

That makes sense — since update_instance() guarantees the outer
instance’s existence, this case wouldn’t be hit in normal execution.

I agree, the Fixes: tag can be dropped. The check mainly serves to make
the intent explicit and avoid future confusion.

I’ve resent the patch without the Fixes: tag.
Link:
https://lore.kernel.org/all/20251020060712.4155702-1-shardulsb08@gmail.com/

Thanks again,
Shardul

      reply	other threads:[~2025-10-20  6:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 10:13 [PATCH bpf 0/1] Follow-up fix for potential error pointer dereference in propagate_to_outer_instance() Shardul Bankar
2025-10-16 10:13 ` [PATCH bpf 1/1] bpf: liveness: Handle ERR_PTR from get_outer_instance() " Shardul Bankar
2025-10-16 17:43   ` Eduard Zingerman
2025-10-20  6:13     ` Shardul Bankar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4fd6596e4a646d7c3a19b4a8f398b970f27e8db.camel@gmail.com \
    --to=shardulsb08@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox