[PATCH] Make IP-Config work without ip= supplied

[PATCH] Make IP-Config work without ip= supplied

[Krzysztof Rusocki]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]


Hi,

Just noticed that IP-Config behavior when no ip= parm is used has changed in
2.2.18.

Up to 2.2.17 IP-Config was enabled even when ip= was omitted. I think that
it's good for use in i.e. diskless nodes.

Since 2.2.18, IP-Config does nothing at all until ip= is passed to the
kernel, however Documentation/nfsroot.txt still says that IP-Config is
enabled by default. Was that intentional change?

Such behavior remains in both 2.2.20 and 2.4.18-rc1. Following patches
(against these two kernel trees) make IP-Config enabled by default.

Cheers,
Krzysztof

PS
please CC, not a subscriber.

PS2
this was also sent to linux-net but got spamfiltered, i suppose
(checked on marc.theaimsgroup.com)

[-- Attachment #2: ipconfig.c.diff-2.4.18-rc1 --]
[-- Type: text/plain, Size: 393 bytes --]

--- linux/net/ipv4/ipconfig.c~	Sun Feb 17 20:29:00 2002
+++ linux/net/ipv4/ipconfig.c	Sun Feb 17 20:35:27 2002
@@ -102,7 +102,7 @@
  */
 int ic_set_manually __initdata = 0;		/* IPconfig parameters set manually */
 
-int ic_enable __initdata = 0;			/* IP config enabled? */
+int ic_enable __initdata = 1;			/* IP config enabled? */
 
 /* Protocol choice */
 int ic_proto_enabled __initdata = 0

[-- Attachment #3: ipconfig.c.diff-2.2.20 --]
[-- Type: text/plain, Size: 353 bytes --]

--- linux/net/ipv4/ipconfig.c.orig	Sun Mar 25 18:31:12 2001
+++ linux/net/ipv4/ipconfig.c	Sun Feb 17 20:42:32 2002
@@ -87,7 +87,7 @@
  * Public IP configuration
  */
 
-int ic_enable __initdata = 0;			/* IP config enabled? */
+int ic_enable __initdata = 1;			/* IP config enabled? */
 
 /* Protocol choice */
 static int ic_proto_enabled __initdata = 0

Re: [PATCH] Make IP-Config work without ip= supplied

[H. Peter Anvin]

Followup to:  <20020218222451.GA23899@main.braxis.co.uk>
By author:    Krzysztof Rusocki <kszysiu@main.braxis.co.uk>
In newsgroup: linux.dev.kernel
> 
> Hi,
> 
> Just noticed that IP-Config behavior when no ip= parm is used has changed in
> 2.2.18.
> 
> Up to 2.2.17 IP-Config was enabled even when ip= was omitted. I think that
> it's good for use in i.e. diskless nodes.
> 
> Since 2.2.18, IP-Config does nothing at all until ip= is passed to the
> kernel, however Documentation/nfsroot.txt still says that IP-Config is
> enabled by default. Was that intentional change?
> 
> Such behavior remains in both 2.2.20 and 2.4.18-rc1. Following patches
> (against these two kernel trees) make IP-Config enabled by default.
> 

I don't think this is a good idea.  The current behaviour should work
across the board.  Diskless nodes should use a diskless bootloader
which support command lines -- that way you get to specify the mode as
well.  *ALL* nodes should use the command line these days.

Can we get rid of the g----d bootsect.S, please?

	-hpa
-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>