From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FAD34750E for ; Thu, 9 Jul 2026 06:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579994; cv=none; b=lEDeLm8nEkQtAqx0tM9s02dNv9o3m3VaxQcl3j1zh5snlIvxi98IF3gpNgOgppFGEXhSXvyYWQKETeQOAdgorzVbkt+wCvSKomo0DRxzrK5HXiKPBoNhvsBM72rdMtVAXvmhdXgEMhd1fqXQLwTrCmBJcF5SBx4h4sTCHCe/ZN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579994; c=relaxed/simple; bh=0MrSCfJAMpyLYv15273OrHr+LAmPjdrF1+VNBtMmVGI=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=F+uXgAg9M3EIwDunv00gPhTnamsKM9SlGE/fh6Qf/BHHoZP5qztulHuW6nwQ3yah5TetI7XehKWG8H1JzOv0Abm9ftanXgMKGN7dwbaxszZmHdUqHQENPjzsPbuAf+13ioM2FSfGaEv+Xk4tVJnAjHc4Xm3w5On5NyYBHALkpkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dsvxAJ1t; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dsvxAJ1t" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cc891373e0so14710335ad.2 for ; Wed, 08 Jul 2026 23:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783579993; x=1784184793; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=H/iB0CTfSp9a9nTqlLe96q2zaF0MNosazIzO7zY5cfs=; b=dsvxAJ1tesa1NbMNYxLmAT2EbSfHCAybC68K+Y2m3wCE2+onbTN9apQUnccW7yUfYj gZzxhg4awBlKZzyv3wsXQhVwVdq8/tpN8Y2DemejkdbapAcP0eYbYW0FXK1Xyu2lO3Ei DuVZbY5HgTCS4gfLvjxBvC9u8YzSZlwVbwJOf2lkomeLLXBQOsZgWWR2h0fOrgqNRy1V 6IHAohfmmNyLtOpc3iEeBoHLJa5dmBun7woeAyHJoBXk6PJXNsIEJpmifvV0PkG//n+n 7g01Pxx3TSGHA6UZBiwtp1GAoRldn5aA9cNr2UJepbAzegQmljmTj87bR6nDcnDlEqXa nOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783579993; x=1784184793; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H/iB0CTfSp9a9nTqlLe96q2zaF0MNosazIzO7zY5cfs=; b=EUkjxBETwaLSy6We4vjzvCKUkWBeVT7pPpfeO9lV7Dggv0LFM4l6bcDjakz1P7PAui 434df7qTpRp+lXDLNgcikaOaRK3fYWmpTGotKl60USM+xOfXDT1VDH/uGmY4xo5BGYQA ri6N6AgZEwr0+WUtiPMmxKGjUBkvIVFXrhTDdNgokl93FMI9VjCjXJyQOXax8T5kZjLK yddG7osAxv/jtOEkX0oG+LLvQlzMApDAxa/anqnLhDdfuDj4i1pYcdo41ZvHiIcm4lQK V2CGD/mfn0O6d8NcSvp+T4CZ3lrRAwhIf0OJpx+GNk13Xaxah62S5Vj6lN5vEPj7uKfo nn+A== X-Forwarded-Encrypted: i=1; AHgh+RpMYkC6RcVHJJG/o2pgvhM5I4lFzNUi1RHpBNomZdX40uqzMDgeSTStrO7LsxfFu3PCKQk4MOU2LnOcBqY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLkvRqLXr/wGmdhrrPm2LK6KShsy4/UuzGN+36wTm+LSYsLlYD 66UnEchuBfXomA0P68uI4fkWyjF2DRAQI2camqFOyfk0dk9K2MotrGra X-Gm-Gg: AfdE7cmh8l4xtuoi6erXtuKbhvwNqSuz9zGRmBJhbtoggfnrhPBVcGxpioP7/+EZLnP +wX8FOEDRo7J40GlnX2xNj19cnjS/gcgVfKnXLTiJN7gcMH006S9q+BBgS/NZzrtbI2xpd4OR4+ 6S1QQHDy8VEwUoFBPhDvFfJv+HOXQgtlv/FTE65M/tAIAwGBMaSZ0uxtx5azBuWJqTNbhSI69gD MCRf8WiG8XwDFE4VYQ03MC1WCi1HM0a+Dyog6SKEBaMgQYTEWIBpBkOBYtonbobZiyfOdVsijZW rVoaDNpu5Zwlrg8EUoYLgAOUk88x8ev45rkUnNJ3QKrX46pFsM+5kFHssT7uGiA6qNq5Cmz6aIg owoDcnKlAftnFQa878iH+qFCzYilm5RXo/dCXmaTueSIdnDwV1AEW0v970a/qduuVFGAxemONKh 5eprMSXH/MFcM= X-Received: by 2002:a05:6a21:6b02:b0:3c0:9c19:65a4 with SMTP id adf61e73a8af0-3c0bd29275bmr7271216637.76.1783579993048; Wed, 08 Jul 2026 23:53:13 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31198cb2b99sm9457437eec.26.2026.07.08.23.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:53:12 -0700 (PDT) From: Ritesh Harjani (IBM) To: Thorsten Blum , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Josh Boyer , Grant Likely , Tony Breeds , Alistair Popple , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: Re: [PATCH 3/3] powerpc/boot: Fix treeboot-akebono CPU node lookup check In-Reply-To: <20260702211554.56923-6-thorsten.blum@linux.dev> Date: Thu, 09 Jul 2026 12:22:52 +0530 Message-ID: References: <20260702211554.56923-4-thorsten.blum@linux.dev> <20260702211554.56923-6-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thorsten Blum writes: > fdt_node_offset_by_prop_value() returns a negative error code on > failure - fix the check accordingly. > > Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") > Signed-off-by: Thorsten Blum Looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) > --- > arch/powerpc/boot/treeboot-akebono.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/treeboot-akebono.c b/arch/powerpc/boot/treeboot-akebono.c > index e3cc2599869c..1b529037480f 100644 > --- a/arch/powerpc/boot/treeboot-akebono.c > +++ b/arch/powerpc/boot/treeboot-akebono.c > @@ -146,7 +146,7 @@ void platform_init(char *userdata) > > node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type", > "cpu", sizeof("cpu")); > - if (!node) > + if (node < 0) > fatal("Cannot find cpu node\n"); > timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size); > if (timebase && (size == 4))