From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board
Date: Thu, 4 Jul 2024 08:28:29 +0200 [thread overview]
Message-ID: <a508cc82-5596-4771-af49-ff994ce59a57@kernel.org> (raw)
In-Reply-To: <20240703210524.776455-3-heiko@sntech.de>
On 03/07/2024 23:05, Heiko Stuebner wrote:
> +/ {
> + model = "Radxa ROCK 5 ITX";
> + compatible = "radxa,rock-5itx", "rockchip,rk3588";
> +
> + aliases {
> + mmc0 = &sdhci;
> + mmc1 = &sdmmc;
> + mmc2 = &sdio;
> + };
> +
> + chosen {
> + stdout-path = "serial2:1500000n8";
> + };
> +
> + adc_keys: adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&saradc 0>;
> + io-channel-names = "buttons";
> + keyup-threshold-microvolt = <1800000>;
> + poll-interval = <100>;
> + status = "okay";
Looks like status can be dropped.
> +
> + button-maskrom {
> + label = "Mask Rom";
> + linux,code = <KEY_SETUP>;
> + press-threshold-microvolt = <1750>;
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-04 6:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:05 [PATCH 0/2] Rock 5 ITX devicetree Heiko Stuebner
2024-07-03 21:05 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board Heiko Stuebner
2024-07-03 21:11 ` Dragan Simic
2024-07-04 6:26 ` Krzysztof Kozlowski
2024-07-03 21:05 ` [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board Heiko Stuebner
2024-07-03 21:16 ` Dragan Simic
2024-07-04 6:28 ` Krzysztof Kozlowski [this message]
2024-07-04 9:38 ` Diederik de Haas
2024-07-04 10:05 ` Heiko Stübner
2024-07-04 11:43 ` Alex Bee
2024-07-04 12:05 ` Heiko Stübner
2024-07-04 13:04 ` Alex Bee
2024-07-04 10:52 ` Alex Bee
2024-07-04 11:21 ` Heiko Stübner
2024-07-04 12:04 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a508cc82-5596-4771-af49-ff994ce59a57@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox