From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbcHXMTh (ORCPT ); Wed, 24 Aug 2016 08:19:37 -0400 Received: from mail-by2nam03on0063.outbound.protection.outlook.com ([104.47.42.63]:18032 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754406AbcHXMTe (ORCPT ); Wed, 24 Aug 2016 08:19:34 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [RFC PATCH v1 18/28] crypto: add AMD Platform Security Processor driver To: Herbert Xu , Brijesh Singh References: <147190820782.9523.4967724730957229273.stgit@brijesh-build-machine> <147190844204.9523.14931918358168729826.stgit@brijesh-build-machine> <20160823071458.GC392@gondor.apana.org.au> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: Tom Lendacky Message-ID: Date: Wed, 24 Aug 2016 07:02:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160823071458.GC392@gondor.apana.org.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR08CA0054.namprd08.prod.outlook.com (10.172.144.16) To BN6PR12MB1139.namprd12.prod.outlook.com (10.168.226.141) X-MS-Office365-Filtering-Correlation-Id: e6598271-747f-4339-33a9-08d3cc168def X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;2:2mIqE8voWKkn5+G7LS7JEWJgMgQqW8q1L0QmWuV6wxlEOB9/4fH6zf0ZRzkKRxRRrzUzR2TGaXrNH540pfAlF2w7iKoRWa0dxg+imk2Sss840YRyqs8qxuDO+7txloGJRCdxLpteeZdCJjGlZ11ljHDxG2VIuevgqV1Ccyf3N+ttG953520atj5UVVSAqPOr;3:NzkL1mfg3b/qK19sOsFRkkE0lR1Il3y38WD/QEeV8CadGeW1v8w3XZzg6UMcoZkCwB+Q5yhG6S7/1hIk5Kp+MhG3QeAT5iZ65AmQfACEwsHYqJNpkPn6TVml/g//4bBl X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1139; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;25:VCpu0ZlHgMXgf+IIzgW9GjOAITYOdClGxubnZ9UqYxdIfoWaH6yPAdDBlVY0xbKMnjMhxkurrm8NKCdkvIK0HnwgYS8kmeAmOyQT0ef6428HK89k16Ocv2dEXQcV3vSavUI2OrwxUMNUn246boBCGxwsPJclqrYZQDT3hCtIbdMU7wfXAg4rFm4R03NhM7Dad4TKvXKjLibUtt/5e2jxEoQ7u+CTPZA4P+CVlfcXr9YJkWdgk97NPS7bstmyLs3LpNsM9Uv57jAwwGG99es4T6rwYHiL20d3muwWGcNIr6skb89TFs96/4lK2/5BP4SqnD5Ev2zh7fZTjveOV2z4Gnp9bYxBmhTtaPYLKpXgLhlWsVkrNNREVJArgFlafvOnYfNWC7PG460ZUp9q3Mn9irYSzR8DP6qXHOHghclW/aqmUzusA9CQZHaVKiLWN/53D4DHB6A3dfOg2yzJ/BuaYZ9VHW54rdsgk576DKGfxduecrN+lWsc7Cdos5OHQwgvYRqtST7QUfnIHE8FWIiS1KGRxh+n537CeT6F0qAWptQ5BlFIFmNUEsgm4lY14qUMDQKS//ZOL5+G3e1BmnIZCuTClmBWhsGkqs7gsgJVtDYVX7Pc6avgnloAqB7B/nRHZWGEKrbGGNqFTh0P7qsLTQgScWBCcjDT2zYHVT/+OhTweib3hIsMb473tnNBOrzrczNVse88ljHLr9QJiryyWPOTTcaiRVivjRzIDJFsD94= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;31:CZxhNCjLB48CsMEKaYLPK1xAhDAt14ADP/57MeCcU0TOiVC5OOr1RzVqUoj8UvTgqYlk8TrJRbRD3L6dDlJfQitAUZjnfc0ohaXTDR9/fqerxKdRZjperc1OTejAdXkgxGqCcdhtF8evy3fmjJ6/3JOSHB6QDaczRQNZ8vOrXudhU1i2P64mTmTDBTyT6MdBVaLSR+5HfW+cRmuDdfTDi9rDWzMVdWSAUQFnNTqeXgc=;20:mzyTQk5B02BQAzn/c6fAeYXDD2MmReH+adT0Lhb920VYRRjpe9WS6DxK2DUMidgUtwUXtTkteT0+H0wEAFuBdXhFq4l28rS5NLd7pIdbpp7HY5AIBGHBFh1A3pynfR1nLYdO3FUaQ7+X8T6U/bW6BdiPQ8xIy1+Tt7zd5c7YE+GvEI9GinGIP/wDYqZvAsb3XFmzWprsLX7i2D3XjdsZRwelz2MtKN8MTNFLT/+AXHylWBNKwiWOxNgxGcgrknKhMSyO2GNMomk8E7QvBwzGttPCUriR5D0qjsDqPppmaj07J6A19huwJg6YKN6w2BKDJUNwUpP2NhuBIHhY3+ucLnUwDD5PprpJESu5FcxZ340WgZG/ZFKQWVwMzv7cXpPF1A3iVjy82OHcE3FmDWhkLtRe3rbY+ekS+Tn9/VPGxlTuDuOymL2z/dMJ/tP208IKdGsmzqAKAuYlvZo/0Vr9s+LXFSzAPWC2iyq3/QHp7swXhwCrEYTI7Sm9idenDOo3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BN6PR12MB1139;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1139; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;4:fSs1fdeqnWf2qTq/qo5QPL2nB12w9HZWpZDPMwHtnOzUlmn3a0GBDCHbAqaJ9Fqik51XFzhYd755wdrB903GTlAqfDoFTmx7T/QfjeOSV8BaCF5eUrqgP7Fdmb0zu/Oxg+tJLSoBp+TUcp2nW1fWkn449zGzL+yO+YGXzgdUQT7gIIErRauox665UUYgja6MuGfCnfEdnLEocJc74F4hjnmo7SyYtANHvzsNM/s00+TVvFuIvrma0QZbDRHBhhmFUyXCFFAz6glEo7wCm6LA5FWAOuaDmHB5TUSjuaQ7GBjn8gX37l4wJhwLmgTmb+HovZAfRrOkq2d2ZterkSKTLVbWtiLa18hjUMf9YadxR2B8LR1Cf306affcxh5AuwYmQt0gNXXDOm0MsR7iVcvjjz9bnL5JH2Vk2Sa2iHMjON0AJFYCHmyJo5/ZpwIsAd1Na6qfk95u3O60tznwC1awgx4lDZbVBj+pt4X3/lTWYds= X-Forefront-PRVS: 0044C17179 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(377454003)(199003)(189002)(7736002)(4001350100001)(2906002)(7406005)(68736007)(47776003)(4326007)(31686004)(7416002)(42186005)(83506001)(31696002)(33646002)(19580395003)(106356001)(305945005)(66066001)(65806001)(230700001)(105586002)(7846002)(5001770100001)(19580405001)(50466002)(65956001)(101416001)(86362001)(36756003)(77096005)(76176999)(5660300001)(3846002)(64126003)(50986999)(6116002)(54356999)(189998001)(2950100001)(97736004)(8676002)(81166006)(23746002)(586003)(92566002)(81156014)(65826006)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1139;H:[10.236.18.82];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1139;23:z0OkcABxnf5L69m/G4uVh1jnTCN8H+r3DqT2Y?= =?Windows-1252?Q?sefeSIw7dp9XcL68pzWscqaI1c3tX55cdoiIWMJL4PNE6sLh9DIwLGMw?= =?Windows-1252?Q?TZj+eDqJkk+NGvBVO7x7KSkWB3JMHc0C/yegJeGfJ5rNr2EdHPIl/5aX?= =?Windows-1252?Q?g/6rJ2yGKn+DfkOIWs6LtBngqyNdgXdhNFm/H36Q7c3DUm0gwmsUuYWj?= =?Windows-1252?Q?BmMgVDic/dTvoYZWthyyCcjQ5cLKy5xUwGwB6EbEHVb2aG8y69eYcq+D?= =?Windows-1252?Q?ef88iNlcf8Vzh+Se3lnf5Km9bH1JsDpOTcR8UQh5gSpzGZJkcA4JHZnP?= =?Windows-1252?Q?pTTT6v1sDs0nVFqFw3wPCKVouAMq9Mo0PJZHITTqlcrFqaXJX4q+Qcug?= =?Windows-1252?Q?VRHajyVD7kOFbJQqvDJHrMCUYLx989pRVMNUORUcLPTAo2itLxoIC1cw?= =?Windows-1252?Q?BqVkT1u+jvFEZAtE5VZ3V/47TwGM5dMUroQ4q8D7e64PFBgRQNor5riN?= =?Windows-1252?Q?iPfdDhbSHuLtI+SBgrTOUr5t8eipJ5hotq2/cqa5ZtJTj4P58vcKnczK?= =?Windows-1252?Q?ESJoOhh+OAjeqf1Mvi7QySbqvVmMzuy3ZPFzgbKQPcJ2D8WZTudfI35m?= =?Windows-1252?Q?W3VLtlfviykfeXfD/brh1+Pe7CvVdy4FjdSmFAvNFf7nVZ7Kedxlg38S?= =?Windows-1252?Q?JHDWnQ72QmCXgmbCCvIXsFNT1Cbt92NXhJ9TOKxTZsb5Fq5es4zjERxT?= =?Windows-1252?Q?GLXbG25mz7+D4DBfpaMMIZdlMwYC4xZmlzwRcYuZZlx/6i4WsnRNuGYc?= =?Windows-1252?Q?GSC9KEmMIvUZC5VwldB7BWxN8GefHQQ6qPbAuF7z+uzi6RrtlMhZYwdk?= =?Windows-1252?Q?JP7RJRSbCmteFwzOzKLqryvX0OG697T3cvyz56t6fjCh94jqDAVh9BTI?= =?Windows-1252?Q?EncmpyYjkvUgwIi3cYMXlm0t0baHcNjHhiUPxp7ti2FbN8jM47a41MDp?= =?Windows-1252?Q?kMZtTwYVoYUPx97y+dr800n8lsgrcSDiLAPpyadPsEqYSxggaPOUKZFe?= =?Windows-1252?Q?dJ2oLR/83eE6CxSHnkd+oI9HY8M0tSVEwh3lVW5c5UYXkS8ZLcwcVIQ3?= =?Windows-1252?Q?2v3z4cCeRYH8Wl2Hvq+a6hxc5x/LNeHRbPzmZ4/QyuQ4mq59FAabVkOm?= =?Windows-1252?Q?YuVnmP9DpaB4EgIm5DsWREcFHGVch8IwFWBvibY6GGGCTfNBrjWArtvg?= =?Windows-1252?Q?wX9hagpi78e0xI6359IGZdnKdpv1apsuwQuXCdQ8qQetST4GmP8BQQrp?= =?Windows-1252?Q?+WaAKa6PlDqwFrOxIaBpwzNSdxiVL6lbUI7Jn1aCyNR4CXU+KM7xgJuv?= =?Windows-1252?Q?UEj68DGZErHPDXfoqe4+eMa3Vp063wHs3tXkj4PAd6nyRpki8UWV5iVQ?= =?Windows-1252?Q?PIQRrqvdqv2m4iTzl5gWExQtmPnaSH8GMuNresguw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;6:+bl+mjW0FqJ0MNjfMSBfEDpyp+Bky3kNHmORf3ofEKM9Ot1UkfauyFMgMQjRo8Mz/DGDoksjH9wk5wUW9A2BJIDMbk/m7VsJoQJopE1Du3gY+GUQ4UOVz1987qZIc08xHuU4qG9Ao8EAE8OhCQzhL2la5buCrAmJdPJscW2rr4sk4nx+LhMm7yK+dtQEeNgQCo2JPurCwz5oM5g0e04W/CcI6N4ed9uw8k9/6SF317bDNpRsDAxxQjqkiXDLIKS3GAjgBVzGnBi+X0G25TvB926Undl34zdFz5neVa/NnHXOBc3moc9+BKUKQLACjqEeVL4iZL0wPVjd4LbdmnyzyA==;5:PirTBFkxtNrr9NsQSoPIEF0By8SWPy90ctkFTEOGw0v6g5iqQGzEcmPW+CojvmlAC50KdOrPpuXUgz9TrSqUkrfTle2ALVwY/Yj7SVxEDd0feQ6oQkzzc8ozBQel2BcqnOCvo9fGanyZlX+Sxz2kvQ==;24:4Af0rYVUX5DJxfYbGgcNZxbQe8Qnku4+fHNKB/7JR0JPaV2XGmixnEOTV65jugszx4BB2gGF5ts6MjBv11qNBWlnOBTZaqbghln/kWRrY3w=;7:F6V98jlyIKIjtq3grhGEZGAVDugbMfdwXIYMArRKImYZ8c8lHY894V34d2atgbALAMieOQJQRcwv/OEANEH47S/gtDVzsga0PAeOk4iHY0QdL0KSX7Id7CVj5TSppjooLbagNrLnYzG8UtvPQSc32L48b4SG1EoJUTd7y0D3mhIHPu6BV51b9MZz0d8IcGg8UcxN597HilEZMFyRbQEIFU1qc4MMN4z+hGTzJL2ZDU/k35GWUrh6ZRn8H1CDW5Wg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1139;20:bSat3zS8MIDti+b+m8kemt4Q4ZasYSHAuXwTxK0aiAMcMN0K2XKNK+eV/4dQmHGDAS4AqiM1MK7xqOqFIZOWQSMSU96x+74Z8VNA+kwI3bantDNghPD7UpGOksDJAgHiwhOSLzmWPN+ZsjVnhVNLMjDWjS+aKM81DPiwjldEi14XQAWMbRvf+AiCea0h9x2sk5hkJ2JUx+TZgelTjNbtd+0JEx3SeX9LkL0+fUP0Fxc5Iza9VxrhBSwkQL0sasgB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2016 12:02:41.0434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/2016 02:14 AM, Herbert Xu wrote: > On Mon, Aug 22, 2016 at 07:27:22PM -0400, Brijesh Singh wrote: >> The driver to communicate with Secure Encrypted Virtualization (SEV) >> firmware running within the AMD secure processor providing a secure key >> management interface for SEV guests. >> >> Signed-off-by: Tom Lendacky >> Signed-off-by: Brijesh Singh > > This driver doesn't seem to hook into the Crypto API at all, is > there any reason why it should be in drivers/crypto? Yes, this needs to be cleaned up. The PSP and the CCP share the same PCI id, so this has to be integrated with the CCP. It could either be moved into the drivers/crypto/ccp directory or both the psp and ccp device specific support can be moved somewhere else leaving just the ccp crypto API related files in drivers/crypto/ccp. Thanks, Tom > > Thanks, >