From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com,
hariramp@quicinc.com, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v6 4/5] arm64: dts: qcom: sc7280: Add support for camss
Date: Wed, 27 Nov 2024 19:32:24 +0100 [thread overview]
Message-ID: <a51b99a3-bfa3-42d7-ba6e-fed5b2c25646@kernel.org> (raw)
In-Reply-To: <20241127100421.3447601-5-quic_vikramsa@quicinc.com>
On 27/11/2024 11:04, Vikram Sharma wrote:
> Add changes to support the camera subsystem on the SC7280.
>
> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 170 +++++++++++++++++++++++++++
> 1 file changed, 170 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 55db1c83ef55..9376755ac43e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4426,6 +4426,176 @@ cci1_i2c1: i2c-bus@1 {
> };
> };
>
> + camss: camss@acaf000 {
> + compatible = "qcom,sc7280-camss";
> +
> + reg = <0x0 0x0acb3000 0x0 0x1000>,
You received feedback to really start testing your code with tools.
Nothing improved. Do you have troubles running tools or something in
feedback was not clear? If first - ask. If second - respond to our
comments, so we can clarify.
Repeating the same mistake over and over and asking us to point you the
same issue is waste of our time. Sorry, that's not acceptable to me.
NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-27 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 10:04 [PATCH v6 0/5] media: qcom: camss: Add sc7280 support Vikram Sharma
2024-11-27 10:04 ` [PATCH v6 1/5] media: dt-bindings: Add qcom,sc7280-camss Vikram Sharma
2024-11-27 12:57 ` Vladimir Zapolskiy
2024-11-27 23:31 ` Bryan O'Donoghue
2024-11-28 8:54 ` Vladimir Zapolskiy
[not found] ` <af043a60-adac-41da-8c7c-1ae5272ffeb1@quicinc.com>
2024-11-28 10:09 ` Krzysztof Kozlowski
2024-11-27 10:04 ` [PATCH v6 2/5] media: qcom: camss: Sort camss version enums and compatible strings Vikram Sharma
2024-11-27 10:04 ` [PATCH v6 3/5] media: qcom: camss: Add support for camss driver on sc7280 Vikram Sharma
2024-11-27 10:04 ` [PATCH v6 4/5] arm64: dts: qcom: sc7280: Add support for camss Vikram Sharma
2024-11-27 18:32 ` Krzysztof Kozlowski [this message]
2024-11-27 18:38 ` Krzysztof Kozlowski
[not found] ` <993cea98-24bc-4f86-835f-099c5009c3b8@quicinc.com>
2024-11-28 7:04 ` Krzysztof Kozlowski
2024-11-27 10:04 ` [PATCH v6 5/5] arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Add vision mezzanine Vikram Sharma
2024-11-27 10:26 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a51b99a3-bfa3-42d7-ba6e-fed5b2c25646@kernel.org \
--to=krzk@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox